[GitHub] metamodel pull request #150: Feature/quote columns

2017-07-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metamodel/pull/150 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] metamodel pull request #150: Feature/quote columns

2017-07-22 Thread tomatophantastico
Github user tomatophantastico commented on a diff in the pull request: https://github.com/apache/metamodel/pull/150#discussion_r128903712 --- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/DefaultQueryRewriter.java --- @@ -101,7 +101,7 @@ public String

[GitHub] metamodel pull request #150: Feature/quote columns

2017-07-22 Thread tomatophantastico
Github user tomatophantastico commented on a diff in the pull request: https://github.com/apache/metamodel/pull/150#discussion_r128903688 --- Diff: jdbc/src/test/java/org/apache/metamodel/jdbc/HsqldbTest.java --- @@ -417,4 +418,98 @@ public void testInterpretationOfNull() throws

[GitHub] metamodel pull request #150: Feature/quote columns

2017-07-22 Thread tomatophantastico
Github user tomatophantastico commented on a diff in the pull request: https://github.com/apache/metamodel/pull/150#discussion_r128903693 --- Diff: jdbc/src/test/java/org/apache/metamodel/jdbc/HsqldbTest.java --- @@ -417,4 +418,98 @@ public void testInterpretationOfNull() throws

[GitHub] metamodel pull request #150: Feature/quote columns

2017-07-22 Thread tomatophantastico
Github user tomatophantastico commented on a diff in the pull request: https://github.com/apache/metamodel/pull/150#discussion_r128903665 --- Diff: core/pom.xml --- @@ -32,6 +32,10 @@ under the License. slf4j-api +

[GitHub] metamodel pull request #150: Feature/quote columns

2017-07-22 Thread kaspersorensen
Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/150#discussion_r128901008 --- Diff: core/pom.xml --- @@ -32,6 +32,10 @@ under the License. slf4j-api +

[GitHub] metamodel pull request #150: Feature/quote columns

2017-07-22 Thread kaspersorensen
Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/150#discussion_r128900988 --- Diff: jdbc/src/test/java/org/apache/metamodel/jdbc/HsqldbTest.java --- @@ -417,4 +418,98 @@ public void testInterpretationOfNull() throws

[GitHub] metamodel pull request #150: Feature/quote columns

2017-07-22 Thread kaspersorensen
Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/150#discussion_r128900981 --- Diff: jdbc/src/test/java/org/apache/metamodel/jdbc/HsqldbTest.java --- @@ -417,4 +418,98 @@ public void testInterpretationOfNull() throws

[GitHub] metamodel pull request #150: Feature/quote columns

2017-07-22 Thread kaspersorensen
Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/150#discussion_r128900965 --- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/DefaultQueryRewriter.java --- @@ -101,7 +101,7 @@ public String

[GitHub] metamodel pull request #150: Feature/quote columns

2017-07-21 Thread tomatophantastico
GitHub user tomatophantastico opened a pull request: https://github.com/apache/metamodel/pull/150 Feature/quote columns Working on a problem similar to METAMODEL-1143 ,this is my solution for HSQLDB and select queries. You can merge this pull request into a Git repository by