[GitHub] metamodel issue #163: METAMODEL-1165: Fixed queries w/o table names (syntax:...

2017-10-04 Thread kaspersorensen
Github user kaspersorensen commented on the issue: https://github.com/apache/metamodel/pull/163 Before I go ahead and merge this based on Lazy Concensus, I'd like to ask one more time if anyone has any feedback on the new feature. To me it seems pretty cool, but others may feel

[GitHub] metamodel issue #163: METAMODEL-1165: Fixed queries w/o table names (syntax:...

2017-10-04 Thread LosD
Github user LosD commented on the issue: https://github.com/apache/metamodel/pull/163 Anyway, up to you. I still think it's a horrible idea, a small convenience is no worth it for a major source of bugs in client code... Even bugs that will show itself at unexpected times (again, try

[GitHub] metamodel issue #163: METAMODEL-1165: Fixed queries w/o table names (syntax:...

2017-10-04 Thread LosD
Github user LosD commented on the issue: https://github.com/apache/metamodel/pull/163 On the way home now, will take a proper look when I'm home. ---

[GitHub] metamodel issue #163: METAMODEL-1165: Fixed queries w/o table names (syntax:...

2017-10-04 Thread kaspersorensen
Github user kaspersorensen commented on the issue: https://github.com/apache/metamodel/pull/163 If I was to paraphrase then you're saying that just because not every `List` is ordered, you shouldn't have a `get(int)` method? I don't think that's reasonable :-) I agree that it might

[GitHub] metamodel issue #156: Checkstyle integration

2017-10-04 Thread kaspersorensen
Github user kaspersorensen commented on the issue: https://github.com/apache/metamodel/pull/156 I don't think we can just do that. ASF owns the Travis instance and the builds are only automatically triggered AFAIK. ---

[GitHub] metamodel-membrane pull request #12: METAMODEL-1166: TenantContext caching

2017-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metamodel-membrane/pull/12 ---

[GitHub] metamodel issue #163: METAMODEL-1165: Fixed queries w/o table names (syntax:...

2017-10-04 Thread LosD
Github user LosD commented on the issue: https://github.com/apache/metamodel/pull/163 Every list IS ordered. That's part of the contract of the List interface... ---

[GitHub] metamodel issue #156: Checkstyle integration

2017-10-04 Thread LosD
Github user LosD commented on the issue: https://github.com/apache/metamodel/pull/156 Ah, that might be. ---