[GitHub] metron issue #723: METRON-1141: NameError: metronProfilerHost is not defined...

2017-08-30 Thread anandsubbu
Github user anandsubbu commented on the issue: https://github.com/apache/metron/pull/723 Closing this pull request, since it is the same as https://github.com/apache/metron/pull/722 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] metron pull request #723: METRON-1141: NameError: metronProfilerHost is not ...

2017-08-30 Thread anandsubbu
Github user anandsubbu closed the pull request at: https://github.com/apache/metron/pull/723 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] metron issue #717: METRON-1134: Allow parser command line options to be spec...

2017-08-30 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/717 Thanks for the writeup on ValueSupplier. I think you went above and beyond documenting it and I appreciate that. it makes sense now that I have my head around it :) I noticed the

Re: [DISCUSS] Feature Branch Setup

2017-08-30 Thread Otto Fowler
Also a Why? section, which has children discussing design questions (WIP) On August 30, 2017 at 18:22:19, Otto Fowler (ottobackwa...@gmail.com) wrote: I would like to use this thread to describe and discuss what is being done or tried in the parser extension feature branch effort. This is our

[GitHub] metron pull request #717: METRON-1134: Allow parser command line options to ...

2017-08-30 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/717#discussion_r136208967 --- Diff: metron-platform/metron-parsers/README.md --- @@ -103,6 +103,15 @@ then it is assumed to be a regex and will match any topic matching the pattern

[GitHub] metron pull request #717: METRON-1134: Allow parser command line options to ...

2017-08-30 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/717#discussion_r136208891 --- Diff: metron-platform/metron-management/src/test/java/org/apache/metron/management/ConfigurationFunctionsTest.java --- @@ -81,7 +81,15 @@ private

[DISCUSS] Feature Branch Setup

2017-08-30 Thread Otto Fowler
I would like to use this thread to describe and discuss what is being done or tried in the parser extension feature branch effort. This is our first time doing this, and there are some differences with reviewing pull requests that we will have to work through, such as there not always being a pull

Re: Feature Branch: Extension System for Metron and Metron Parsers

2017-08-30 Thread Otto Fowler
I have created an area in confluence for feedback when there is no PR to comment on: https://cwiki.apache.org/confluence/display/METRON/Review+Feedback On August 30, 2017 at 11:59:21, Otto Fowler (ottobackwa...@gmail.com) wrote: Ok. The initial PR is landed and the branch is up to date, with a

[GitHub] metron issue #719: METRON-1137: Build RPM for Metron MaaS as a part of rpm-d...

2017-08-30 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/719 +1 I launched Full Dev, built the RPMs and then installed the MaaS RPM on Full Dev. The contents of the RPM matched what @anandsubbu documented. I then started MaaS to make sure

[GitHub] metron pull request #724: METRON-1142: Add Geo Hashing functions to stellar

2017-08-30 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/metron/pull/724 METRON-1142: Add Geo Hashing functions to stellar ## Contributor Comments Adding geo hashing functions to stellar would be a nice complement to the geo enrichment. Furthermore, geo hashing

[GitHub] metron pull request #722: METRON-1139 Fixed service advisor profilerHost var...

2017-08-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/722 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] metron issue #722: METRON-1139 Fixed service advisor profilerHost variable

2017-08-30 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/722 +1 by inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] metron issue #717: METRON-1134: Allow parser command line options to be spec...

2017-08-30 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/717 Alright, I've added both a comment about the supplier abstraction and support for num workers and num ackers. --- If your project is set up for it, you can reply to this email and have your reply

Re: Feature Branch: Extension System for Metron and Metron Parsers

2017-08-30 Thread Otto Fowler
Ok. The initial PR is landed and the branch is up to date, with a clean commit log etc and ready for reviews, new or old. On August 30, 2017 at 10:39:55, Nick Allen (n...@nickallen.org) wrote: Just to be safe (and not to violate any community bylaws) I would say yes, for any PR. But maybe I

Re: [DISCUSS] Metron release 0.4.1

2017-08-30 Thread Michael Miklavcic
I have some work around fixing how we handle config with Ambari that I'd like to see go in. No PR yet, but coming soon. I expect to have this by the RC deadline. Mike On Wed, Aug 30, 2017 at 8:57 AM, Nick Allen wrote: > The following PRs are usability enhancements for the

Re: [DISCUSS] Metron release 0.4.1

2017-08-30 Thread Casey Stella
Yeah, I'm not sure we need to hold up the release necessarily, but I think it'd be a nice capability. I expect it'll get done prior to friday as it's pretty close. On Tue, Aug 29, 2017 at 8:59 PM, Matt Foley wrote: > Okay, just to be clear, you’re requesting we wait until

Re: [DISCUSS] Feature Branches and updating from Master

2017-08-30 Thread Nick Allen
I think opening PRs is the way to go. We're going to have maybe three kinds of merges when we sync a feature branch with master. - The *good* kind when there are no conflicts. Yay! Easy review, no problems, quick +1. - The *bad* kind when there are conflicts. This will take some

[GitHub] metron issue #720: METRON-1136 Initial Merge of Metron Extensions and Parser...

2017-08-30 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/720 https://github.com/apache/metron/commit/ffcb91ed09c36d25008cfe57f06a9568d278f2f4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] metron pull request #720: METRON-1136 Initial Merge of Metron Extensions and...

2017-08-30 Thread ottobackwards
Github user ottobackwards closed the pull request at: https://github.com/apache/metron/pull/720 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [DISCUSS] Metron release 0.4.1

2017-08-30 Thread Nick Allen
The following PRs are usability enhancements for the Profiler. They are fairly simple and I think are very helpful for troubleshooting. I don't want to hold up the release, but it would be a "nice to have" to get these in. If anyone has cycles, I would appreciate some reviews of these PRs.

[GitHub] metron issue #720: METRON-1136 Initial Merge of Metron Extensions and Parser...

2017-08-30 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/720 Thanks, @ottobackwards . This looks ready to commit to our new feature branch. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[DISCUSS] Feature Branches and updating from Master

2017-08-30 Thread Otto Fowler
How are we going to keep Feature Branches up to date with master? Do we need a PR? Is it just a behind the scenes commit from a committer? Can a committer also optionally update master as part of landing another PR? We are trailblazing here, so we can work with this to get an idea before we

Re: Feature Branch: Extension System for Metron and Metron Parsers

2017-08-30 Thread Nick Allen
Just to be safe (and not to violate any community bylaws) I would say yes, for any PR. But maybe I am misunderstanding. I would be happy to get you some +1s in short order to help move things along. On Wed, Aug 30, 2017 at 10:32 AM Otto Fowler wrote: > Right, I mean

[GitHub] metron issue #711: METRON-1127: Add ability to escalate alerts for external ...

2017-08-30 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/711 @ottobackwards Those are all important points to consider. I just don't know that we need to think through all of that right now. I am thinking of this PR as a very basic, first pass. Let's

Re: Feature Branch: Extension System for Metron and Metron Parsers

2017-08-30 Thread Otto Fowler
Right, I mean the initial PR that moves the other branches in. I don’t think we expect that pr to get reviewed. On August 30, 2017 at 10:26:00, Nick Allen (n...@nickallen.org) wrote: Yes, I think you still need +1s. The same PR rules apply to the feature branch PRs. The only difference

Re: Feature Branch: Extension System for Metron and Metron Parsers

2017-08-30 Thread Nick Allen
Yes, I think you still need +1s. The same PR rules apply to the feature branch PRs. The only difference being that as a reviewer/committer I won't expect the same level of quality, documentation, etc to get my +1 for a PR that is destined for a feature branch. And of course, each

[GitHub] metron issue #711: METRON-1127: Add ability to escalate alerts for external ...

2017-08-30 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/711 part of the issue is there is no use case for how this is going to be used beyond the general. How often do analysts that have possibly 1000s of alerts find the one magic alert? I

[GitHub] metron issue #711: METRON-1127: Add ability to escalate alerts for external ...

2017-08-30 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/711 @ottobackwards agreed, this is very separate from the management ui (won't touch, or be used by anything in the management ui). Also agreed this is a separate entity, but one that will be

Re: Feature Branch: Extension System for Metron and Metron Parsers

2017-08-30 Thread Otto Fowler
So the question is: Can I commit the PR or do I need some +1’s to rubber stamp it? On August 29, 2017 at 10:01:13, Otto Fowler (ottobackwa...@gmail.com) wrote: And finally : https://github.com/apache/metron/pull/720 On August 28, 2017 at 10:24:43, Otto Fowler (ottobackwa...@gmail.com) wrote:

[GitHub] metron issue #700: METRON-1077: Use column meta data end point in alerts ui

2017-08-30 Thread iraghumitra
Github user iraghumitra commented on the issue: https://github.com/apache/metron/pull/700 @merrimanr I moved the rest-api calls to services --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] metron issue #723: METRON-1141: NameError: metronProfilerHost is not defined...

2017-08-30 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/723 +1 by inspection, my bad! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] metron pull request #723: METRON-1141: NameError: metronProfilerHost is not ...

2017-08-30 Thread anandsubbu
GitHub user anandsubbu opened a pull request: https://github.com/apache/metron/pull/723 METRON-1141: NameError: metronProfilerHost is not defined in stack_advisor.py ## Contributor Comments ** Testing Done ** - Modified `service_advisor.py` on the Ambari host with the mpack