Re: new committer: Raghu Mitra

2017-10-20 Thread Otto Fowler
Congratulations! On October 20, 2017 at 12:10:42, James Sirota (jsir...@apache.org) wrote: The Project Management Committee (PMC) for Apache Metron has invited Raghu Mitra to become a committer and we are pleased to announce that he has accepted. Being a committer enables easier

Re: new committer: Raghu Mitra

2017-10-20 Thread zeo...@gmail.com
Congratulations, Raghu! Jon On Fri, Oct 20, 2017, 12:11 Simon Elliston Ball wrote: > Congratulations Raghu. Well deserved with all that awesome UI work that’s > coming in. > > Simon > > > On 20 Oct 2017, at 17:10, James Sirota wrote: > > > > >

[GitHub] metron issue #810: METRON-1270 fix for warnings missing @return tag argument...

2017-10-20 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/810 +1 by inspection ---

[GitHub] metron issue #804: METRON-1260 Include Alerts UI in Ambari Service Check

2017-10-20 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/804 +1 by inspection, great job here. ---

[GitHub] metron pull request #800: METRON-1251: Typo and formatting fixes for metron-...

2017-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/800 ---

[GitHub] metron issue #800: METRON-1251: Typo and formatting fixes for metron-rest RE...

2017-10-20 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/800 +1 by inspection. Good job here! ---

[GitHub] metron issue #809: METRON-1266 Profiler - SASL Authentication Failed

2017-10-20 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/809 oh god, that's weird. +1 by inspection, let's get this in master asap ---

[GitHub] metron pull request #795: METRON-1241: Enable the REST API to use a cache fo...

2017-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/795 ---

[GitHub] metron pull request #797: METRON-1243: Add a REST endpoint which allows us t...

2017-10-20 Thread cestella
Github user cestella closed the pull request at: https://github.com/apache/metron/pull/797 ---

[GitHub] metron issue #795: METRON-1241: Enable the REST API to use a cache for the z...

2017-10-20 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/795 +1 It looks great. Thanks! ---

[GitHub] metron issue #795: METRON-1241: Enable the REST API to use a cache for the z...

2017-10-20 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/795 Alright, changes included. Did I miss anything @nickwallen ? ---

[GitHub] metron pull request #810: METRON-1270 fix for warnings missing @return tag a...

2017-10-20 Thread dbist
GitHub user dbist opened a pull request: https://github.com/apache/metron/pull/810 METRON-1270 fix for warnings missing @return tag argument in metron-analytics/metron-profiler-common and metron-profiler-client ## Contributor Comments [WARNING]

[GitHub] metron pull request #808: METRON-1267: Alerts UI returns a 404 when refreshi...

2017-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/808 ---

[GitHub] metron pull request #795: METRON-1241: Enable the REST API to use a cache fo...

2017-10-20 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/795#discussion_r146031435 --- Diff: metron-platform/metron-zookeeper/src/main/java/org/apache/metron/zookeeper/ZKCache.java --- @@ -0,0 +1,141 @@ +/** + * Licensed to the

[GitHub] metron pull request #809: METRON-1266 Profiler - SASL Authentication Failed

2017-10-20 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/809 METRON-1266 Profiler - SASL Authentication Failed When running the Profiler on a cluster that has multiple nodes and is secured by Kerberos, it was observed that the HBaseBolt was unable to

[GitHub] metron issue #806: METRON-1262: Unable to add comment for a alert in a meta-...

2017-10-20 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/806 +1 by inspection. Thank for contributing! ---

[GitHub] metron pull request #795: METRON-1241: Enable the REST API to use a cache fo...

2017-10-20 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/795#discussion_r146021528 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/zookeeper/configurations/ProfilerUpdater.java --- @@ -0,0 +1,114 @@

[GitHub] metron pull request #795: METRON-1241: Enable the REST API to use a cache fo...

2017-10-20 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/795#discussion_r146021013 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/zookeeper/configurations/ProfilerUpdater.java --- @@ -0,0 +1,114 @@

[GitHub] metron pull request #795: METRON-1241: Enable the REST API to use a cache fo...

2017-10-20 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/795#discussion_r146020850 --- Diff: metron-platform/metron-zookeeper/src/main/java/org/apache/metron/zookeeper/ZKCache.java --- @@ -0,0 +1,141 @@ +/** + * Licensed to the

[GitHub] metron pull request #795: METRON-1241: Enable the REST API to use a cache fo...

2017-10-20 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/795#discussion_r146020712 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/zookeeper/configurations/IndexingUpdater.java --- @@ -0,0 +1,88 @@ +/**

[GitHub] metron pull request #795: METRON-1241: Enable the REST API to use a cache fo...

2017-10-20 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/795#discussion_r146020428 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/zookeeper/configurations/ProfilerUpdater.java --- @@ -0,0 +1,114 @@

[GitHub] metron issue #808: METRON-1267: Alerts UI returns a 404 when refreshing the ...

2017-10-20 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/808 +1 by inspection. Thanks for fixing this. It can be a little annoying. ---

[GitHub] metron pull request #795: METRON-1241: Enable the REST API to use a cache fo...

2017-10-20 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/795#discussion_r146019541 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/zookeeper/configurations/ProfilerUpdater.java --- @@ -0,0 +1,114 @@

[GitHub] metron pull request #795: METRON-1241: Enable the REST API to use a cache fo...

2017-10-20 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/795#discussion_r146018459 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/zookeeper/configurations/ProfilerUpdater.java --- @@ -0,0 +1,114 @@

[GitHub] metron pull request #795: METRON-1241: Enable the REST API to use a cache fo...

2017-10-20 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/795#discussion_r146017385 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/zookeeper/configurations/IndexingUpdater.java --- @@ -0,0 +1,88 @@

[GitHub] metron issue #795: METRON-1241: Enable the REST API to use a cache for the z...

2017-10-20 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/795 Alright, great reviews. I think I have reacted to the comments; let me know if I missed anything. ---

[GitHub] metron pull request #795: METRON-1241: Enable the REST API to use a cache fo...

2017-10-20 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/795#discussion_r146012465 --- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/StormControllerIntegrationTest.java --- @@ -179,6 +181,8 @@ public

[GitHub] metron pull request #795: METRON-1241: Enable the REST API to use a cache fo...

2017-10-20 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/795#discussion_r146012300 --- Diff: metron-platform/metron-zookeeper/src/main/java/org/apache/metron/zookeeper/ZKCache.java --- @@ -0,0 +1,141 @@ +/** + * Licensed to the

[GitHub] metron pull request #795: METRON-1241: Enable the REST API to use a cache fo...

2017-10-20 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/795#discussion_r146010894 --- Diff: metron-platform/metron-zookeeper/src/main/java/org/apache/metron/zookeeper/ZKCache.java --- @@ -0,0 +1,141 @@ +/** + * Licensed to the

Re: new committer: Raghu Mitra

2017-10-20 Thread Simon Elliston Ball
Congratulations Raghu. Well deserved with all that awesome UI work that’s coming in. Simon > On 20 Oct 2017, at 17:10, James Sirota wrote: > > > > The Project Management Committee (PMC) for Apache Metron > has invited Raghu Mitra to become a committer and we are pleased

new committer: Raghu Mitra

2017-10-20 Thread James Sirota
The Project Management Committee (PMC) for Apache Metron has invited Raghu Mitra to become a committer and we are pleased to announce that he has accepted. Being a committer enables easier contribution to the project since there is no need to go via the patch submission process. This should

[GitHub] metron pull request #795: METRON-1241: Enable the REST API to use a cache fo...

2017-10-20 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/795#discussion_r145992573 --- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/StormControllerIntegrationTest.java --- @@ -179,6 +181,8 @@ public

[GitHub] metron issue #795: METRON-1241: Enable the REST API to use a cache for the z...

2017-10-20 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/795 I tested this thoroughly and everything works as expected. I made one small comment that I feel is optional. This is an awesome PR. +1 ---

[GitHub] metron issue #803: Metron-1252: Build ui for grouping alerts into meta alert...

2017-10-20 Thread james-sirota
Github user james-sirota commented on the issue: https://github.com/apache/metron/pull/803 I filed the following follow-on PRs per your comments: https://issues.apache.org/jira/browse/METRON-1268 https://issues.apache.org/jira/browse/METRON-1269 ---