[GitHub] metron pull request #960: METRON-1424: Kerberos: Solr

2018-03-09 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/960 METRON-1424: Kerberos: Solr ## Contributor Comments This PR adds Kerberos support for Solr in Metron. This has been verified in full dev using the following steps: 1. Spin up full

[GitHub] metron pull request #957: METRON-1482: Update REST to work with Solr

2018-03-08 Thread merrimanr
Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/957 ---

[GitHub] metron pull request #945: METRON-1464: Convert schemas to be compatible with...

2018-03-08 Thread merrimanr
Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/945 ---

[GitHub] metron issue #949: METRON-1471: Migrate shuffle connections to local or shuf...

2018-03-08 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/949 +1 thanks! ---

[GitHub] metron issue #957: METRON-1482: Update REST to work with Solr

2018-03-08 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/957 I've been maintaining this branch for a while and have been merging in other branches before they were committed to master. I think that's why you see all these commits. I merged in feature

[GitHub] metron pull request #957: METRON-1482: Update REST to work with Solr

2018-03-07 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/957 METRON-1482: Update REST to work with Solr ## Contributor Comments This PR updates the REST start script to properly include the correct indexing jar on the classpath depending

[GitHub] metron issue #949: METRON-1471: Migrate shuffle connections to local or shuf...

2018-03-07 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/949 I still see a SHUFFLE grouping (spout -> enrichmentSplit) in the legacy enrichment topology flux file. Maybe we end up switching to the new enrichment topology so not important in that case. ---

[GitHub] metron issue #949: METRON-1471: Migrate shuffle connections to local or shuf...

2018-03-07 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/949 There are also shuffle groupings in the enrichment and profiler topologies. Do we want to update those too? ---

[GitHub] metron issue #952: METRON-1480 Add yarn as default build tool for the fronte...

2018-03-07 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/952 I think we are on board with switching to yarn so no concerns there. There was a discussion on it but if anyone now feels differently, speak up. Sounds like we still have a lot of work

[GitHub] metron pull request #952: METRON-1480 Add yarn as default build tool for the...

2018-03-07 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/952#discussion_r172937150 --- Diff: metron-interface/metron-config/package.json --- @@ -33,6 +28,11 @@ "@angular/platform-browser": "2.0.0",

[GitHub] metron issue #945: METRON-1464: Convert schemas to be compatible with Solr 5...

2018-03-07 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/945 When looking at the reference guide, it's not obvious to me what the differences are between Point and Trie fields as it relates to our use case. Point field types for the corresponding Trie

[GitHub] metron pull request #952: METRON-1480 Add yarn as default build tool for the...

2018-03-07 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/952#discussion_r172934046 --- Diff: metron-interface/metron-config/package.json --- @@ -33,6 +28,11 @@ "@angular/platform-browser": "2.0.0",

[GitHub] metron issue #952: METRON-1480 Add yarn as default build tool for the fronte...

2018-03-07 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/952 I'm having trouble understanding what this PR actually does. I see that package-lock.json was removed and yarn.lock was added. Is that all that's needed to switch to yarn? Do we need to also

[GitHub] metron pull request #952: METRON-1480 Add yarn as default build tool for the...

2018-03-07 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/952#discussion_r172927751 --- Diff: metron-interface/metron-alerts/package.json --- @@ -27,8 +27,8 @@ "core-js": "^2.4.1", &qu

[GitHub] metron pull request #952: METRON-1480 Add yarn as default build tool for the...

2018-03-07 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/952#discussion_r172927486 --- Diff: metron-interface/metron-config/package.json --- @@ -33,6 +28,11 @@ "@angular/platform-browser": "2.0.0",

[GitHub] metron issue #950: METRON-1470: Update jquery to version 3+

2018-03-06 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/950 I ran this up in full dev and tested several different features. I could not find any regressions. Thanks @xyztdanid4! +1 ---

[GitHub] metron issue #943: METRON-1462: Separate ES and Kibana from Metron Mpack

2018-03-06 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/943 I spun this up in full dev and everything worked as expected. The organization looks good to me and I can't find anything wrong with it. +1 ---

[GitHub] metron issue #941: METRON-1355: Convert metron-elasticsearch to new infrastr...

2018-03-06 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/941 Sorry I should have documented this better in the PR description. The docker-machine ip address needs to be substituted in ElasticsearchTestUtils temporarily if you want to run this on your local

[GitHub] metron issue #853: METRON-1337: List of facets should not be hardcoded

2018-03-01 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/853 Any other feedback @ottobackwards or is this ready to go? ---

[GitHub] metron pull request #934: METRON-1423: Ambari work to handle Solr configurat...

2018-03-01 Thread merrimanr
Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/934 ---

[GitHub] metron pull request #945: METRON-1464: Convert schemas to be compatible with...

2018-02-28 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/945 METRON-1464: Convert schemas to be compatible with Solr 5.5.2 ## Contributor Comments This PR makes the Solr schema compatible with Solr 5.5.2. The client code worked as is (compiled

[GitHub] metron issue #940: METRON-1460: Create a complementary non-split-join enrich...

2018-02-26 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/940 I tested this in full dev and worked as expected. +1 ---

[GitHub] metron pull request #934: METRON-1423: Ambari work to handle Solr configurat...

2018-02-23 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/934#discussion_r170365518 --- Diff: metron-platform/metron-solr/src/main/scripts/create_collection.sh --- @@ -0,0 +1,27 @@ +#!/bin/bash +# +# Licensed to the Apache

[GitHub] metron pull request #934: METRON-1423: Ambari work to handle Solr configurat...

2018-02-23 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/934#discussion_r170272344 --- Diff: metron-platform/metron-solr/src/main/scripts/create_collection.sh --- @@ -0,0 +1,27 @@ +#!/bin/bash +# +# Licensed to the Apache

[GitHub] metron pull request #853: METRON-1337: List of facets should not be hardcode...

2018-02-22 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/853#discussion_r170120909 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/AlertServiceImpl.java --- @@ -37,15 +47,21 @@ @Service

[GitHub] metron pull request #858: METRON-1344: Externalize the infrastructural compo...

2018-02-22 Thread merrimanr
Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/858 ---

[GitHub] metron pull request #941: METRON-1355: Convert metron-elasticsearch to new i...

2018-02-22 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/941 METRON-1355: Convert metron-elasticsearch to new infrastructure ## Contributor Comments This PR switches metron-elasticsearch integration tests from using in-memory components to the e2e

[GitHub] metron issue #924: METRON-1299 In MetronError tests, don't test for HostName...

2018-02-22 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/924 +1 pending @cestella's approval. Thanks @ottobackwards. ---

[GitHub] metron issue #895: METRON-1394:Create Rest endpoint to add the ACL for curre...

2018-02-21 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/895 +1 by inspection. Thanks @MohanDV! ---

[GitHub] metron pull request #853: METRON-1337: List of facets should not be hardcode...

2018-02-20 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/853#discussion_r169455383 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/AlertServiceImpl.java --- @@ -37,15 +47,21 @@ @Service

[GitHub] metron issue #853: METRON-1337: List of facets should not be hardcoded

2018-02-20 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/853 I took @ottobackwards's suggestion and added a "type" parameter that can be used to independently manage user settings for different types of clients. I moved the users settings for the

[GitHub] metron pull request #853: METRON-1337: List of facets should not be hardcode...

2018-02-16 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/853#discussion_r168817020 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/config/HBaseConfig.java --- @@ -0,0 +1,61 @@ +/** + * Licensed

[GitHub] metron pull request #853: METRON-1337: List of facets should not be hardcode...

2018-02-16 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/853#discussion_r168816712 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/search/SearchRequest.java --- @@ -101,16 +99,16 @@ public void

[GitHub] metron pull request #853: METRON-1337: List of facets should not be hardcode...

2018-02-16 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/853#discussion_r168816212 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/rest_commands.py

[GitHub] metron issue #853: METRON-1337: List of facets should not be hardcoded

2018-02-16 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/853 I think it's a fair question @ottobackwards. Anything that might affect how the HBase table is laid out should be worked out now or we're back to altering tables during upgrades. Currently

[GitHub] metron issue #853: METRON-1337: List of facets should not be hardcoded

2018-02-16 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/853 The latest commit switches the persistence for storing user settings to HBase rather than a RDBMS as discussed on the dev list. Instead of fields being stored in RDBMS columns, the user settings

[GitHub] metron issue #937: METRON-1455: Patch and Replace methods in the REST Update...

2018-02-15 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/937 I verified this works in full dev. Thanks for fixing this! +1 ---

[GitHub] metron issue #934: METRON-1423: Ambari work to handle Solr configuration

2018-02-12 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/934 I agree with @justinleet. I would prefer we use Solr 6+. At some point HDP Search will move to 6+ and we can easily switch to the Mpack since installing Solr is a manual step now. Happy

[GitHub] metron pull request #934: METRON-1423: Ambari work to handle Solr configurat...

2018-02-09 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/934 METRON-1423: Ambari work to handle Solr configuration ## Contributor Comments This PR allows support for Metron-related Solr configuration and management through Ambari. That does

[GitHub] metron issue #929: METRON-1448: Update SolrWriter to conform to new collecti...

2018-02-08 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/929 Yes I pushed the change to zookeeper with Swagger. Probably just a minor detail he missed in his instructions. You can use either "localhost:9983" or "node1:9983&

[GitHub] metron issue #929: METRON-1448: Update SolrWriter to conform to new collecti...

2018-02-08 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/929 +1 from me pending approval from others. Tested this in full dev and worked fine. ---

[GitHub] metron issue #932: METRON-1451: On Centos full dev, Metron Indexing shows up...

2018-02-08 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/932 I spun this up and I know longer see the Indexing component as red. +1 as soon as @nickwallen's build finishes and it's working there too. ---

[GitHub] metron issue #922: METRON-1441: Create complementary Solr schemas for the ma...

2018-02-06 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/922 Looks good to me. +1 ---

[GitHub] metron issue #922: METRON-1441: Create complementary Solr schemas for the ma...

2018-02-05 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/922 I would say collection for each parser and an error collection. It's similar to ES templates where we define fields, types, etc. ---

[GitHub] metron issue #922: METRON-1441: Create complementary Solr schemas for the ma...

2018-02-05 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/922 The errors I found happened when I tried to create collections with each schema. The error related to the `guid` field happens because it is defined as the unique key but not included in the list

[GitHub] metron issue #922: METRON-1441: Create complementary Solr schemas for the ma...

2018-02-02 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/922 I tested this in full dev using the install script in https://github.com/apache/metron/pull/918. I was able to create collections for each schema except for "error". For that to work p

[GitHub] metron pull request #911: METRON-1419: Create a SolrDao

2018-02-01 Thread merrimanr
Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/911 ---

[GitHub] metron issue #918: METRON-1436: Manually Install Solr Cloud in Full Dev

2018-01-31 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/918 I tested it out and worked fine. I think it's a good start. +1 as long as other commenters are satisfied. ---

[GitHub] metron issue #911: METRON-1419: Create a SolrDao

2018-01-31 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/911 I believe all feedback has been addressed. The ElasticsearchDao refactor was not trivial and was more complex than the SolrDao. There were more dependencies between the various Daos so it's

[GitHub] metron pull request #911: METRON-1419: Create a SolrDao

2018-01-31 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/911#discussion_r165142091 --- Diff: metron-platform/metron-solr/src/test/java/org/apache/metron/solr/integration/components/SolrComponent.java --- @@ -158,4 +162,16 @@ public

[GitHub] metron pull request #911: METRON-1419: Create a SolrDao

2018-01-31 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/911#discussion_r165141979 --- Diff: metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrSearchDao.java --- @@ -0,0 +1,315 @@ +/** + * Licensed

[GitHub] metron pull request #911: METRON-1419: Create a SolrDao

2018-01-31 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/911#discussion_r165142013 --- Diff: metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrUpdateDao.java --- @@ -0,0 +1,101 @@ +/** + * Licensed

[GitHub] metron pull request #911: METRON-1419: Create a SolrDao

2018-01-31 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/911#discussion_r165142049 --- Diff: metron-platform/metron-solr/src/test/java/org/apache/metron/solr/integration/SolrSearchIntegrationTest.java --- @@ -0,0 +1,152

[GitHub] metron pull request #911: METRON-1419: Create a SolrDao

2018-01-31 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/911#discussion_r165141915 --- Diff: metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrSearchDao.java --- @@ -0,0 +1,315 @@ +/** + * Licensed

[GitHub] metron pull request #911: METRON-1419: Create a SolrDao

2018-01-31 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/911#discussion_r165141548 --- Diff: metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrSearchDao.java --- @@ -0,0 +1,315 @@ +/** + * Licensed

[GitHub] metron pull request #911: METRON-1419: Create a SolrDao

2018-01-31 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/911#discussion_r165141296 --- Diff: metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/dao/SearchIntegrationTest.java --- @@ -655,83 +699,54 @@ public void

[GitHub] metron pull request #911: METRON-1419: Create a SolrDao

2018-01-31 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/911#discussion_r165141322 --- Diff: metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrDao.java --- @@ -0,0 +1,118 @@ +/** + * Licensed to the Apache

[GitHub] metron pull request #917: METRON-1435: Management UI cannot save json object...

2018-01-30 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/917 METRON-1435: Management UI cannot save json objects in advanced config ## Contributor Comments This PR fixes a bug in the Management UI that limits a user to only entering strings

[GitHub] metron pull request #911: METRON-1419: Create a SolrDao

2018-01-30 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/911#discussion_r164881484 --- Diff: metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/dao/SearchIntegrationTest.java --- @@ -443,11 +495,11 @@ public void

[GitHub] metron pull request #911: METRON-1419: Create a SolrDao

2018-01-30 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/911#discussion_r164881237 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/search/SearchDao.java --- @@ -0,0 +1,34

[GitHub] metron pull request #911: METRON-1419: Create a SolrDao

2018-01-29 Thread merrimanr
Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/911 ---

[GitHub] metron pull request #911: METRON-1419: Create a SolrDao

2018-01-29 Thread merrimanr
GitHub user merrimanr reopened a pull request: https://github.com/apache/metron/pull/911 METRON-1419: Create a SolrDao ## Contributor Comments This PR is an initial attempt at creating a SolrDao that implements the IndexDao interface, is functionally equivalent

[GitHub] metron pull request #911: METRON-1419: Create a SolrDao

2018-01-26 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/911 METRON-1419: Create a SolrDao ## Contributor Comments This PR is an initial attempt at creating a SolrDao that implements the IndexDao interface, is functionally equivalent

[GitHub] metron issue #892: METRON-1392 Fix a test case to expect an Exception when r...

2018-01-26 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/892 +1 by inspection. Thanks for fixing this @MohanDV. The original test didn't even make sense. ---

[GitHub] metron issue #898: METRON-1398:Exclude the basic-error-controller from being...

2018-01-26 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/898 +1 by inspection. Thanks @MohanDV! ---

[GitHub] metron issue #909: METRON-1429: SearchIntegrationTest refactor

2018-01-25 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/909 I think this is useful outside of any Solr work and I intended for it to go into master. ---

[GitHub] metron pull request #909: METRON-1429: SearchIntegrationTest refactor

2018-01-25 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/909#discussion_r163859481 --- Diff: metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/dao/SearchIntegrationTest.java --- @@ -724,6 +503,52 @@ public void

[GitHub] metron pull request #909: METRON-1429: SearchIntegrationTest refactor

2018-01-25 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/909#discussion_r163859462 --- Diff: metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/dao/SearchIntegrationTest.java --- @@ -724,6 +503,52 @@ public void

[GitHub] metron pull request #909: METRON-1429: SearchIntegrationTest refactor

2018-01-24 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/909 METRON-1429: SearchIntegrationTest refactor ## Contributor Comments This PR cleans up SearchIntegrationTest which will make it easier to create a Solr implementation. Changes include

[GitHub] metron issue #853: METRON-1337: List of facets should not be hardcoded

2018-01-23 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/853 I will address 6 shortly. For 5, should we explore a more flexible store in this PR? Or at least validate that an RDBMS is the right choice? I think this is something we should tackle now

[GitHub] metron issue #891: METRON-1282 creating a new topic using the rest end point...

2018-01-18 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/891 I think a separate PR is fine. Can you at least move it to a separate method? ---

[GitHub] metron issue #853: METRON-1337: List of facets should not be hardcoded

2018-01-09 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/853 Here are my thoughts on your responses. 1. I think we're in agreement. This is how this PR currently works. 2. No, saved searches are currently stored client-side. I think the plan

[GitHub] metron issue #891: METRON-1282 creating a new topic using the rest end point...

2018-01-09 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/891 @MohanDV this is a good start and will be a nice feature to have. I have a couple suggestions. First, can we move this to it's own function/endpoint? I think this would be useful

[GitHub] metron issue #853: METRON-1337: List of facets should not be hardcoded

2018-01-09 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/853 Done ---

[GitHub] metron issue #840: METRON-939: Upgrade ElasticSearch and Kibana

2018-01-08 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/840 I ran this up in full dev again and verified the e2e tests now work similar to how they do in master. I also manually tested several other areas including the Alerts UI, Kibana and Swagger

[GitHub] metron issue #786: METRON-1231: Separate Sensor name and topic in the Manage...

2018-01-08 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/786 We don't have e2e tests for the management UI. We do have unit tests and I added tests for these fixes there. ---

[GitHub] metron issue #786: METRON-1231: Separate Sensor name and topic in the Manage...

2018-01-05 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/786 @justinleet 1, 2, and 3 have been addressed with the latest commit. I also added a couple unit tests for good measure. I wasn't able to easily reproduce 4 so I didn't fix that one

[GitHub] metron issue #884: METRON-1382 Run Stellar in a Zeppelin Notebook

2018-01-05 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/884 I spun this up again and all the issues I found have been resolved. Great work. +1 ---

[GitHub] metron issue #786: METRON-1231: Separate Sensor name and topic in the Manage...

2018-01-05 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/786 I believe 2 and 4 are preexisting but I'm happy to fix them here. Will update when I have resolved these issues. ---

[GitHub] metron issue #840: METRON-939: Upgrade ElasticSearch and Kibana

2018-01-04 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/840 I spun this up in full dev and spent all day testing it. From a functional perspective, I can not find anything wrong with it. I ran through the test plan in this PR and everything worked

[GitHub] metron issue #884: METRON-1382 Run Stellar in a Zeppelin Notebook

2018-01-03 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/884 I also noticed that functions returning a list only display the first item in both the shell and Zeppelin output. For example, the expression `MAP([ 'foo', 'bar'], (x) -> TO_UPPE

[GitHub] metron issue #884: METRON-1382 Run Stellar in a Zeppelin Notebook

2018-01-03 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/884 I think this is an excellent start. So far I have only reviewed it from a user perspective and it's working well so far. I've spun it up in full dev (not sure that's even necessary

[GitHub] metron issue #831: METRON-1302: Split up Indexing Topology into batch and ra...

2018-01-02 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/831 I ran this up in full dev and everything worked as advertised. I only noticed a couple minor issues and left comments for those. I also am a little confused by the ra/batch vs es/hdfs

[GitHub] metron pull request #831: METRON-1302: Split up Indexing Topology into batch...

2018-01-02 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/831#discussion_r159322924 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/templates/hdfs.properties.j2

[GitHub] metron pull request #831: METRON-1302: Split up Indexing Topology into batch...

2018-01-02 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/831#discussion_r159321881 --- Diff: metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/integration/IndexingIntegrationTest.java --- @@ -197,9 +140,7

[GitHub] metron pull request #886: METRON-1385: Missing "properties" in index templat...

2018-01-02 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/886 METRON-1385: Missing "properties" in index template causes ElasticsearchColumnMetadataDao.getColumnMetadata to fail ## Contributor Comments A bug was recently discovered that ca

[GitHub] metron issue #857: METRON-1340: Improve e2e tests for metron alerts

2018-01-02 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/857 @justinleet I believe @iraghumitra is still working on the SELENIUM_PROMISE_MANAGER change proposed above but I will defer to him. ---

[GitHub] metron issue #858: METRON-1344: Externalize the infrastructural components u...

2018-01-02 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/858 @cestella are you good with merging this in to the feature branch? I believe I addressed your comments. ---

[GitHub] metron pull request #858: METRON-1344: Externalize the infrastructural compo...

2017-12-14 Thread merrimanr
Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/858 ---

[GitHub] metron pull request #858: METRON-1344: Externalize the infrastructural compo...

2017-12-14 Thread merrimanr
GitHub user merrimanr reopened a pull request: https://github.com/apache/metron/pull/858 METRON-1344: Externalize the infrastructural components using integration tests ## Contributor Comments This PR will add infrastructure to our Travis build that will allow the Alerts UI

[GitHub] metron pull request #859: METRON-1345: Update EC2 README for custom Ansible ...

2017-12-13 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/859#discussion_r156744095 --- Diff: metron-deployment/amazon-ec2/README.md --- @@ -126,6 +126,10 @@ To provision only subsets of the entire Metron deployment, Ansible tags can be s

[GitHub] metron issue #863: METRON-1347: Indexing Topology should fail tuples without...

2017-12-13 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/863 I would like to hear feedback from @ottobackwards on other required fields but this looks good to me otherwise. ---

[GitHub] metron pull request #863: METRON-1347: Indexing Topology should fail tuples ...

2017-12-13 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/863#discussion_r156674159 --- Diff: metron-platform/metron-writer/src/main/java/org/apache/metron/writer/bolt/BulkMessageWriterBolt.java --- @@ -229,17 +239,30 @@ public void

[GitHub] metron issue #857: METRON-1340: Improve e2e tests for metron alerts

2017-12-12 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/857 I was reviewing the protractor documentation [here](http://www.protractortest.org/#/async-await) and I noticed this: > Don’t forget to turn off control_flow, you cannot use a

[GitHub] metron issue #834: METRON-1306: When index template install fails, we should...

2017-12-12 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/834 After reading this whole thread I agree with @ottobackwards. If we installed and started all services and THEN installed our parsers separately this whole issue goes away. If a parser's template

[GitHub] metron issue #853: METRON-1337: List of facets should not be hardcoded

2017-12-12 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/853 Ambari does not manage this config. It is only included in the base application.yml as a default setting. I don't feel like this setting should be in Ambari for a couple reasons: changing

[GitHub] metron pull request #858: METRON-1344: Externalize the infrastructural compo...

2017-12-12 Thread merrimanr
GitHub user merrimanr reopened a pull request: https://github.com/apache/metron/pull/858 METRON-1344: Externalize the infrastructural components using integration tests ## Contributor Comments This PR will add infrastructure to our Travis build that will allow the Alerts UI

[GitHub] metron pull request #858: METRON-1344: Externalize the infrastructural compo...

2017-12-12 Thread merrimanr
Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/858 ---

[GitHub] metron issue #853: METRON-1337: List of facets should not be hardcoded

2017-12-12 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/853 Each environment will have it's own application.yaml. Full dev has one, our testing environment has one, Ambari ships one etc. There is also a base application.yaml that has the defaults

[GitHub] metron pull request #858: METRON-1344: Externalize the infrastructural compo...

2017-12-11 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/858#discussion_r156215449 --- Diff: metron-interface/metron-alerts/protractor.conf.js --- @@ -25,27 +25,28 @@ var SpecReporter = require('jasmine-spec-reporter').SpecReporter

  1   2   3   4   5   >