[GitHub] metron issue #946: METRON-1465:Support for Elasticsearch X-pack

2018-03-15 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/946 thanks @mmiklavc ---

[GitHub] metron issue #964: METRON-1491: The indexing topology restart logic is wrong

2018-03-15 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/964 Yes, lets get it in there ---

[GitHub] metron issue #964: METRON-1491: The indexing topology restart logic is wrong

2018-03-15 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/964 Should we think about exposing them as separate things in ambari over all? Go all the way with this? ---

[GitHub] metron issue #946: METRON-1465:Support for Elasticsearch X-pack

2018-03-09 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/946 @cestella " Yeah, I think that's the approach, however, there's a snag. Storm requires us to create uber jars, so probably what we want to do is have users actually put the xpath tran

[GitHub] metron issue #946: METRON-1465:Support for Elasticsearch X-pack

2018-03-09 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/946 would this have any effect on people using x-pack alternatives? ---

[GitHub] metron issue #946: METRON-1465:Support for Elasticsearch X-pack

2018-03-09 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/946 wait, does this PR mean we *require* x-pack from now on? ---

[GitHub] metron issue #951: Metron-1479 Add editorconfig - create guideline for code ...

2018-03-07 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/951 Why are there so many changes to the package locks vs. to the package files themselves? ---

[GitHub] metron issue #943: METRON-1462: Separate ES and Kibana from Metron Mpack

2018-03-06 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/943 What about upgrading.md? ---

[GitHub] metron issue #942: METRON-1461: Modify the MIN, MAX Stellar methods to take ...

2018-03-06 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/942 Maybe making this function so generic is going to necessitate it being so complicated that it is harder to maintain etc. ---

[GitHub] metron issue #940: METRON-1460: Create a complementary non-split-join enrich...

2018-03-05 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/940 Maybe the issue has to do with our keys, and their distribution as the size get's larger? Maybe when we get larger sizes we get more collisions and end up calling equals() more or something. ---

[GitHub] metron issue #940: METRON-1460: Create a complementary non-split-join enrich...

2018-03-05 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/940 This should have the equiv. diagram and documentation ( i believe as shown above ) to the original split join strategy. ---

[GitHub] metron-bro-plugin-kafka pull request #6: Configurable JSON timestamps and de...

2018-03-05 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/6#discussion_r172243410 --- Diff: src/KafkaWriter.cc --- @@ -54,20 +66,49 @@ KafkaWriter::KafkaWriter(WriterFrontend* frontend): WriterBackend(frontend

[GitHub] metron issue #940: METRON-1460: Create a complementary non-split-join enrich...

2018-03-02 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/940 have we thought to send a mail to the storm dev list and ask if anyone has done this? potential issues? ---

[GitHub] metron issue #940: METRON-1460: Create a complementary non-split-join enrich...

2018-03-02 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/940 If we integrated storm with yarn this would also be a problem, as our resource management may be at odds with yarn's. I think? What would be nice is if storm could manage the pool

[GitHub] metron issue #853: METRON-1337: List of facets should not be hardcoded

2018-03-01 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/853 +1 by inspection ---

[GitHub] metron issue #853: METRON-1337: List of facets should not be hardcoded

2018-03-01 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/853 Sorry, I'll try to get back to this today ---

[GitHub] metron issue #943: METRON-1462: Separate ES and Kibana from Metron Mpack

2018-02-23 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/943 I think I mentioned contrib. They don't have to go in contrib, I think at the time someone mentioned not wanting to maintain them.. If we don't then I thought contrib would make sense. We

[GitHub] metron pull request #853: METRON-1337: List of facets should not be hardcode...

2018-02-22 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/853#discussion_r170125479 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/AlertServiceImpl.java --- @@ -37,15 +47,21 @@ @Service

[GitHub] metron pull request #940: Single bolt split join poc

2018-02-22 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/940#discussion_r170056794 --- Diff: metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/bolt/UnifiedEnrichmentBolt.java --- @@ -0,0 +1,323

[GitHub] metron pull request #853: METRON-1337: List of facets should not be hardcode...

2018-02-20 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/853#discussion_r169515112 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/AlertServiceImpl.java --- @@ -37,15 +47,21 @@ @Service

[GitHub] metron issue #853: METRON-1337: List of facets should not be hardcoded

2018-02-20 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/853 This looks great, one small comment from review ---

[GitHub] metron pull request #853: METRON-1337: List of facets should not be hardcode...

2018-02-20 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/853#discussion_r169441455 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/AlertServiceImpl.java --- @@ -37,15 +47,21 @@ @Service

[GitHub] metron issue #939: [BUG-96727] xpack support (for discussion only)

2018-02-19 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/939 It is almost like hw has a different issue tracking system ---

[GitHub] metron issue #939: [BUG-96727] xpack support (for discussion only)

2018-02-19 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/939 BUG- is not a valid title for this project. ---

[GitHub] metron issue #939: [BUG-96727] xpack support (for discussion only)

2018-02-19 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/939 Can you put some kind of description in here? What does that BUG refer to? ---

[GitHub] metron issue #579: METRON-941 native PaloAlto parser corrupts message when h...

2018-02-16 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/579 +1 one. Thank you @ctramnitz. I know how it can be to have a long review process. This is really good work and I look forward to seeing what you do next ;) ---

[GitHub] metron issue #853: METRON-1337: List of facets should not be hardcoded

2018-02-16 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/853 I am not an expert in hbase, I cannot say how i'd implement it. The version thing we can leave out, it will be just as good or bad as what we have in zookeeper right? I think

[GitHub] metron pull request #579: METRON-941 native PaloAlto parser corrupts message...

2018-02-16 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/579#discussion_r168779259 --- Diff: Upgrading.md --- @@ -19,6 +19,24 @@ limitations under the License. This document constitutes a per-version listing of changes

[GitHub] metron issue #579: METRON-941 native PaloAlto parser corrupts message when h...

2018-02-16 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/579 maybe regression isn't the right word - "Until we have something generic to (pre-)parse syslog before it reaches the message parser I assumed the messages will be stripped off the s

[GitHub] metron issue #853: METRON-1337: List of facets should not be hardcoded

2018-02-16 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/853 Of course re-reading your comment, I see you specifically didn't account for these, but I think there are some basic tweaks to allow for this that don't presuppose far flung 20% use cases. ---

[GitHub] metron issue #853: METRON-1337: List of facets should not be hardcoded

2018-02-16 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/853 First, nice work. Second, I have this question: Since we will have some unknown number of rest clients, that may want to save 'configuration' associated with a user, and not just

[GitHub] metron issue #579: METRON-941 fix PaloAltoParser

2018-02-16 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/579 after that I'll merge ---

[GitHub] metron issue #579: METRON-941 fix PaloAltoParser

2018-02-16 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/579 @ctramnitz one thing, since this is a regression, technically, we need to update the release notes / upgrade guide. Can you add a note to the Upgrading.md about the removal of the Syslog

[GitHub] metron issue #579: METRON-941 fix PaloAltoParser

2018-02-13 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/579 Im +1 on this. I would like to get comment from @simonellistonball et al on the change for syslog ---

[GitHub] metron issue #934: METRON-1423: Ambari work to handle Solr configuration

2018-02-12 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/934 I would just like it documented as to why we are not using the HDP solr mpack. Although, I would think we would be using that mpack as the example for ours? ---

[GitHub] metron issue #934: METRON-1423: Ambari work to handle Solr configuration

2018-02-11 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/934 Can I ask a question : why aren't we using https://docs.hortonworks.com/HDPDocuments/HDP2/HDP-2.6.4/bk_solr-search-installation/content/ch_hdp-search-install-ambari.html? Is there a reason

[GitHub] metron issue #934: METRON-1423: Ambari work to handle Solr configuration

2018-02-11 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/934 Ran through test, everything worked fine. +1 On the questions: - What Solr parameters do we expose in Ambari? All of them? People are going to want to tune indexing

[GitHub] metron issue #929: METRON-1448: Update SolrWriter to conform to new collecti...

2018-02-08 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/929 +1 ---

[GitHub] metron issue #929: METRON-1448: Update SolrWriter to conform to new collecti...

2018-02-08 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/929 @merrimanr did you push the configs to zookeeper? ---

[GitHub] metron issue #929: METRON-1448: Update SolrWriter to conform to new collecti...

2018-02-08 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/929 Everything worked, just wondering about the questions above before I check off. ---

[GitHub] metron issue #929: METRON-1448: Update SolrWriter to conform to new collecti...

2018-02-08 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/929 don't we have to push the new config to zookeeper? ---

[GitHub] metron issue #929: METRON-1448: Update SolrWriter to conform to new collecti...

2018-02-08 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/929 Why is it "solr.zookeeper" : "localhost:9983" and not solr.ip? ---

[GitHub] metron issue #914: METRON-1397 Support for JSON Path and complex documents i...

2018-02-08 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/914 Um, it is updated. ---

[GitHub] metron issue #914: METRON-1397 Support for JSON Path and complex documents i...

2018-02-07 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/914 Just a note on parser docs, part of the mythical 777 is support for per parser readme, that would be nice here. ---

[GitHub] metron issue #929: METRON-1448: Update SolrWriter to conform to new collecti...

2018-02-07 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/929 Cool, I'll run the test plan ---

[GitHub] metron issue #914: METRON-1397 Support for JSON Path and complex documents i...

2018-02-07 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/914 yeah, you said in the docs, will do ---

[GitHub] metron issue #914: METRON-1397 Support for JSON Path and complex documents i...

2018-02-07 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/914 http://goessner.net/articles/JsonPath/ https://github.com/json-path/JsonPath http://jsonpath.herokuapp.com https://docs.spring.io/spring-boot/docs/current/reference/html/boot

[GitHub] metron issue #929: METRON-1448: Update SolrWriter to conform to new collecti...

2018-02-07 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/929 See, we explored it. Thanks!! ---

[GitHub] metron issue #929: METRON-1448: Update SolrWriter to conform to new collecti...

2018-02-07 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/929 Sorry, maybe I misunderstood what I have read here: https://lucidworks.com/2013/08/23/understanding-transaction-logs-softcommit-and-commit-in-sorlcloud/ I thought that you could

[GitHub] metron issue #929: METRON-1448: Update SolrWriter to conform to new collecti...

2018-02-07 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/929 Should we explore auto-commit? Also, maybe we should rename all this stuff to SolrCloud, since Solr and SolrCloud *are* different in some use of terms and concepts? ---

[GitHub] metron issue #928: METRON-1444: Add Ubuntu Repositories for Elasticsearch to...

2018-02-07 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/928 I'll add 2 smileys next time, to help get my point across. I would have expected a response more along the lines of: "Upgrading Ambari to the 2.6 release line shows little risk w

[GitHub] metron issue #928: METRON-1444: Add Ubuntu Repositories for Elasticsearch to...

2018-02-07 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/928 Shouldn't the title of this PR be "Update ambari from 2.5.x to 2.6.x"? That seems the bigger thing :) ---

[GitHub] metron issue #922: METRON-1441: Create complementary Solr schemas for the ma...

2018-02-05 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/922 So, the idea is that we have a 'core' for each parser? and for errors? ---

[GitHub] metron pull request #924: METRON-1299 In MetronError tests, don't test for H...

2018-02-02 Thread ottobackwards
GitHub user ottobackwards opened a pull request: https://github.com/apache/metron/pull/924 METRON-1299 In MetronError tests, don't test for HostName if getHostName wouldn't work MetronError ignores exceptions from InetAddress.getLocalHost().getHostName() and leaves the field unset

[GitHub] metron issue #865: METRON-1212 The bundle System and Maven Plugin (Feature B...

2018-02-02 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/865 Hey @JonZeolla how is it going? ---

[GitHub] metron pull request #922: METRON-1441: Create complementary Solr schemas for...

2018-02-02 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/922#discussion_r165662614 --- Diff: metron-platform/metron-solr/src/test/java/org/apache/metron/solr/schema/SchemaTranslatorTest.java --- @@ -0,0 +1,188

[GitHub] metron pull request #920: METRON-1438 Move SHELL functions from metron-manag...

2018-02-02 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/920#discussion_r165662017 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/ShellFunctionsTest.java --- @@ -40,8 +45,8

[GitHub] metron pull request #920: METRON-1438 Move SHELL functions from metron-manag...

2018-02-02 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/920#discussion_r165661676 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/ShellFunctionsTest.java --- @@ -40,8 +45,8

[GitHub] metron pull request #920: METRON-1438 Move SHELL functions from metron-manag...

2018-02-02 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/920#discussion_r165659854 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/shell/cli/PausableInput.java --- @@ -36,8 +37,8

[GitHub] metron pull request #922: METRON-1441: Create complementary Solr schemas for...

2018-02-01 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/922#discussion_r165548937 --- Diff: metron-platform/metron-solr/src/test/java/org/apache/metron/solr/schema/SchemaTranslatorTest.java --- @@ -0,0 +1,188

[GitHub] metron pull request #922: METRON-1441: Create complementary Solr schemas for...

2018-02-01 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/922#discussion_r165548986 --- Diff: metron-platform/metron-solr/src/test/java/org/apache/metron/solr/schema/SchemaTranslatorTest.java --- @@ -0,0 +1,188

[GitHub] metron pull request #920: METRON-1438 Move SHELL functions from metron-manag...

2018-02-01 Thread ottobackwards
GitHub user ottobackwards opened a pull request: https://github.com/apache/metron/pull/920 METRON-1438 Move SHELL functions from metron-management to stellar-common Part of making stellar more modular and stand alone is consolidation of stellar functionality scattered through

[GitHub] metron issue #919: METRON-1439: Turn off git pager in platform-info script

2018-02-01 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/919 No, I am sorry, I thought that was understood. I have not reviewed, but I would go ahead based on @cestella ---

[GitHub] metron issue #919: METRON-1439: Turn off git pager in platform-info script

2018-02-01 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/919 this is a user utility though, not a dev one. I would create a new support-scripts folder ---

[GitHub] metron issue #579: METRON-941 fix PaloAltoParser

2018-02-01 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/579 @ctramnitz thank you! Let us know where you are at and if we can help ---

[GitHub] metron issue #857: METRON-1340: Improve e2e tests for metron alerts

2018-01-31 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/857 What is the status of this pr? it is 29 day without comment, and conflicted, literally, and perhaps figuratively ---

[GitHub] metron pull request #856: METRON-1339 Stellar Shell functionality to verify ...

2018-01-31 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/856#discussion_r165048687 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/validation/StellarZookeeperBasedValidator.java

[GitHub] metron issue #873: METRON-1367 Stellar should have some instrumentation of f...

2018-01-30 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/873 bump ---

[GitHub] metron issue #690: METRON-1091 Package STELLAR shell as stand alone

2018-01-30 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/690 Done, let me know if the changes are sufficient @JonZeolla ---

[GitHub] metron issue #830: METRON-1298: TimeRange Picker doesn't work on Safari

2018-01-30 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/830 Can you take master again? This pr still builds metron twice when doing vagrant up. ---

[GitHub] metron issue #684: DO NOT MERGE: METRON-1086: Create a Blockly-based user in...

2018-01-30 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/684 We should make this a feature branch ---

[GitHub] metron issue #775: [METRON-1214] rpm build fails due to npm absence in Docke...

2018-01-30 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/775 @DimDroll any reproduction? Is this still happening for you? ---

[GitHub] metron issue #670: METRON-1065 grok pattern for cisco asa parser expects sys...

2018-01-30 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/670 Deconflict and bump? ---

[GitHub] metron issue #890: METRON-1391 Fix for README.md in Metron Management

2018-01-30 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/890 Thanks! please take care of the jira ---

[GitHub] metron issue #858: METRON-1344: Externalize the infrastructural components u...

2018-01-30 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/858 Re-upping what I said before ---

[GitHub] metron issue #789: METRON-1233: Remove description of Global configuration f...

2018-01-30 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/789 This needs deconflict, and a relevant check ---

[GitHub] metron issue #912: METRON-1431 Adding REGEX_REPLACE(input, regex, value) to ...

2018-01-29 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/912 please remember to take care of your jira ---

[GitHub] metron issue #912: METRON-1431 Adding REGEX_REPLACE(input, regex, value) to ...

2018-01-29 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/912 +1 by inspection. Thank you for the contribution ---

[GitHub] metron pull request #914: METRON-1397 Support for JSON Path and complex docu...

2018-01-29 Thread ottobackwards
GitHub user ottobackwards opened a pull request: https://github.com/apache/metron/pull/914 METRON-1397 Support for JSON Path and complex documents in JSONMapParser It would be useful for implementors to have the ability to ingest more complex documents without having to stand up

[GitHub] metron pull request #912: METRON-1431 Adding REGEX_REPLACE(input, regex, val...

2018-01-28 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/912#discussion_r164303375 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/RegExFunctionsTest.java --- @@ -68,4 +68,19 @@ public

[GitHub] metron pull request #912: METRON-1431 Adding REGEX_REPLACE(input, regex, val...

2018-01-28 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/912#discussion_r164303393 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/RegExFunctions.java --- @@ -100,4 +100,39 @@ public

[GitHub] metron issue #903: METRON-1370 Create Full Dev Equivalent for Ubuntu

2018-01-26 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/903 +1 still stands ---

[GitHub] metron issue #903: METRON-1370 Create Full Dev Equivalent for Ubuntu

2018-01-25 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/903 +1 -> ran up both images, everything checked out Ship it ---

[GitHub] metron issue #901: METRON-1410 [MPACK] Check for existing HBASE tables befor...

2018-01-25 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/901 I'm going to wait for @lvets a chance to try his scenario ---

[GitHub] metron issue #903: METRON-1370 Create Full Dev Equivalent for Ubuntu

2018-01-25 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/903 Sure. Question. Do we expect there to be issues with 2.6? Is this PR and Casey's 2.6 pr going to conflict or have issues? How will we know to retest this after that one lands

[GitHub] metron issue #902: METRON-1413 Add Metron Commit Tool

2018-01-25 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/902 +1 ---

[GitHub] metron issue #910: METRON-1430: Isolate jackson from being used as arguments...

2018-01-25 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/910 This looks awesome at first look. I'm a big fan of doing this regardless of the shading issue. The only thought that comes to mind is that there is a tipping point where a *Utils class isn't

[GitHub] metron issue #903: METRON-1370 Create Full Dev Equivalent for Ubuntu

2018-01-25 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/903 @nickwallen let me know when you feel ok about it, I'll run it through again. ---

[GitHub] metron issue #903: METRON-1370 Create Full Dev Equivalent for Ubuntu

2018-01-25 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/903 Failure during vagrant up for metron-on-ubuntu ``` 2018-01-25 10:41:49,302 p=37541 u=ottofowler | fatal: [node1]: FAILED! => {"changed": true,

[GitHub] metron issue #903: METRON-1370 Create Full Dev Equivalent for Ubuntu

2018-01-25 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/903 Trying this now. Only comment on the content here is there is a _lot_ going on in this pr. A lot of while I'm here I might as well work. It might have been better to have kept

[GitHub] metron pull request #901: METRON-1410 Check for existing HBASE tables before...

2018-01-25 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/901#discussion_r163868868 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/enrichment_commands.py

[GitHub] metron issue #902: METRON-1413 Add Metron Commit Tool

2018-01-25 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/902 I have another script I want to add for tracking master in feature branches after this as well ---

[GitHub] metron issue #902: METRON-1413 Add Metron Commit Tool

2018-01-24 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/902 I can almost always be bought off with a jira number ---

[GitHub] metron issue #888: METRON-1389: Zeppelin notebook import does not work with ...

2018-01-24 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/888 +1 by inspection ---

[GitHub] metron pull request #901: METRON-1410 Check for existing HBASE tables before...

2018-01-24 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/901#discussion_r163616902 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/enrichment_commands.py

[GitHub] metron issue #873: METRON-1367 Stellar should have some instrumentation of f...

2018-01-22 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/873 ok, it is MAGIC_TIME! @simonellistonball ---

[GitHub] metron issue #873: METRON-1367 Stellar should have some instrumentation of f...

2018-01-22 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/873 Plus it lets me get away with ```java public static final String MAGIC_TIME = "%time"; ``` so bonus ---

[GitHub] metron issue #873: METRON-1367 Stellar should have some instrumentation of f...

2018-01-22 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/873 well, %timing seem to make sense to me, as it is the timing of the last statement. %time didn't occur to me. I don't use Jupyter, and don't time things in the shell that often. I

[GitHub] metron issue #690: METRON-1091 Package STELLAR shell as stand alone

2018-01-22 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/690 @JonZeolla this should be set ---

[GitHub] metron issue #870: METRON-1364: Add an implementation of Robust PCA outlier ...

2018-01-22 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/870 Looking for tests and deconflict ---

  1   2   3   4   5   6   7   8   9   10   >