On top of this, refactoring under another PR’s goals tends to be less
documented as to the intent
and effect.
+1 for the idea, we should have a vote round or edit round on the doc’s
specific text.
Although I will say, that some things it doesn’t matter how much you break
them up wrt reviews.
We sh
I want to bring up the subject of code refactoring and how we should manage
this in PR's as our product evolves. As Metron matures, it's only natural
that we'll have and increasing number of contributors, and subsequently
contributions affecting many hardened parts of the code base. We've
generally
Just a question, do we need anything new in the Upgrading.md for this
release? Any migration that we expect people to do?
On Tue, May 29, 2018 at 11:30 AM Nick Allen wrote:
> METRON-1544 was just merged into master.
>
>
> On Tue, May 29, 2018 at 2:16 PM, Justin Leet
> wrote:
>
> > I'm going to
METRON-1544 was just merged into master.
On Tue, May 29, 2018 at 2:16 PM, Justin Leet wrote:
> I'm going to go ahead and cancel RC1, since METRON-1544 looks pretty set.
>
> A new release candidate will be cut.
>
> Results (including my own vote):
> +1
> Nick Allen
>
>
> -1
> Otto Fowler
> Justi
I'm going to go ahead and cancel RC1, since METRON-1544 looks pretty set.
A new release candidate will be cut.
Results (including my own vote):
+1
Nick Allen
-1
Otto Fowler
Justin Leet
On Tue, May 29, 2018 at 10:39 AM, Justin Leet wrote:
> I didn't realize METRON-1544 wasn't in. I'm definit
I didn't realize METRON-1544 wasn't in. I'm definitely okay with
cancelling the vote, and kicking out a new RC.
On Tue, May 29, 2018 at 7:11 AM, Otto Fowler
wrote:
> -1 (binding)
>
> My yield for building this it terrible. 1 in 3.
>
> I propose https://github.com/apache/metron/pull/1015 inclus
-1 (binding)
My yield for building this it terrible. 1 in 3.
I propose https://github.com/apache/metron/pull/1015 inclusion.
On May 27, 2018 at 17:50:43, Nick Allen (n...@nickallen.org) wrote:
No, the PR for this transient issue is still under review.
On Sun, May 27, 2018 at 10:53 AM, Otto F
