Github user xyztdanid4 commented on a diff in the pull request:
https://github.com/apache/metron/pull/952#discussion_r173710125
--- Diff: metron-interface/metron-alerts/pom.xml ---
@@ -35,36 +35,36 @@
com.github.eirslett
Github user xyztdanid4 commented on the issue:
https://github.com/apache/metron/pull/952
@merrimanr
As we agreed yesterday I did the required changes in the pom xml-s.
I had to update the node dependency of the projects, otherwise the build
was failed, cause one
GitHub user xyztdanid4 opened a pull request:
https://github.com/apache/metron/pull/956
METRON-1474 Add normalizecss
## Contributor Comments
This PR adds normalizecss to the frontend projects. It is useful to bridge
the differences between browsers.
## Pull
Github user xyztdanid4 closed the pull request at:
https://github.com/apache/metron/pull/955
---
Github user xyztdanid4 commented on the issue:
https://github.com/apache/metron/pull/952
@merrimanr
although it should work with npm as well, cause then it will use the
package.json to install the dependencies.
---
Github user xyztdanid4 commented on a diff in the pull request:
https://github.com/apache/metron/pull/952#discussion_r172936489
--- Diff: metron-interface/metron-config/package.json ---
@@ -33,6 +28,11 @@
"@angular/platform-browser": "2.0.0",
Github user xyztdanid4 commented on the issue:
https://github.com/apache/metron/pull/952
@merrimanr
Yes this is the right way to switch to yarn.
Yes we have install yarn locally.
I did not know that we have so much dependency on npm. But for me it was
hard to add new
Github user xyztdanid4 commented on the issue:
https://github.com/apache/metron/pull/952
@merrimanr
---
Github user xyztdanid4 commented on a diff in the pull request:
https://github.com/apache/metron/pull/952#discussion_r172932830
--- Diff: metron-interface/metron-config/package.json ---
@@ -33,6 +28,11 @@
"@angular/platform-browser": "2.0.0",
Github user xyztdanid4 commented on a diff in the pull request:
https://github.com/apache/metron/pull/952#discussion_r172879403
--- Diff: metron-interface/metron-alerts/package-lock.json ---
@@ -1,6427 +0,0 @@
-{
--- End diff --
I think that was the problem
Github user xyztdanid4 commented on the issue:
https://github.com/apache/metron/pull/952
@simonellistonball I am not sure. Probably no.
---
GitHub user xyztdanid4 opened a pull request:
https://github.com/apache/metron/pull/955
METRON-1474 Add normalizecss
THIS IS WIP. FIRST #952 SHOULD BE MERGED.
## Contributor Comments
This PR adds normalizecss to the frontend projects. It is useful to bridge
the differences
GitHub user xyztdanid4 opened a pull request:
https://github.com/apache/metron/pull/954
METRON-1478 Move type definitions to dev-dependencies
## Contributor Comments
Types definitions should not be in dependencies. I moved them to
dev-dependencies.
## Pull Request
GitHub user xyztdanid4 opened a pull request:
https://github.com/apache/metron/pull/953
Metron 1472 Add stylelint support
THIS IS WIP. FIRST #952 SHOULD MERGED.
Added support for stylelint to be able to validate scss syntax.
## Pull Request Checklist
Thank
Github user xyztdanid4 commented on the issue:
https://github.com/apache/metron/pull/951
@ottobackwards
In my next PR the build tool will change to yarn. So package.json will be
gone soon, and replaced by yarn.lock which is smaller of course.
---
Github user xyztdanid4 commented on the issue:
https://github.com/apache/metron/pull/951
@ottobackwards
I am not sure, but the I guess this is the normal way of locking
dependencies.
---
GitHub user xyztdanid4 opened a pull request:
https://github.com/apache/metron/pull/952
Metron-1480 Add yarn as default build tool for the frontend
Updated the build tool to yarn for the frontend project to avoid npm
instability during dependency adding.
### For all
GitHub user xyztdanid4 opened a pull request:
https://github.com/apache/metron/pull/951
Metron-1479 Introduce editorconfig, and format all of the code in alerts
and config projects
It is necessary to use editorconfig, code should be look like the same in
all files
GitHub user xyztdanid4 opened a pull request:
https://github.com/apache/metron/pull/950
METRON-1470: Update jquery to version 3+
I updated jquerry dependency of the project due to security reason.
- [X] Is there a JIRA ticket associated with this PR? If not one needs
19 matches
Mail list logo
