Github user cestella commented on the issue:
https://github.com/apache/metron/pull/650
Committed, but I wanted to make a comment about the BiFunction. Honestly,
I like the notion of providing candy for 2-arg functions like we did for
single-arg functions. I think it'll make it
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/650
+1, lgtm. By the way, my mentions of BiFunction were incorrect because
MathFunction takes an array of numbers as its (sole) argument. But glad to see
you added Min Args as well as Max Args.
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/650
Ok, I reacted to @mattf-horton and @justinleet 's comments:
* adjusted some naming and made the documentation match up
* adjusted the `ROUND` documentation to indicate half-up rounding.
Github user simonellistonball commented on the issue:
https://github.com/apache/metron/pull/650
I would like it to be committed to make it much easier for me to port my PR
to it so +1 (non-binding)
---
If your project is set up for it, you can reply to this email and have your
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/650
Any comments or review here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/650
Ok, I broke this abstraction out a bit and made it easier to add
non-single-arg functions (a la POW, which is a separate PR by
@simonellistonball ). I also went ahead and added `ROUND` and `EXP`.
