Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/872
Nice addition! +1 from me as well, via inspection.
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/872
+1. Thanks for the contribution, this is valuable to have.
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/872
@justinleet I think that was just an alternative implementation with
streams rather than explicit loops. I interpreted it as not a suggested
change, but a cool new way to compute entropy.
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/872
@cestella Any response to the comment by @ottobackwards ? I glanced over
it, and I like it and think it's valuable, but he's hitting at the core impl,
so I don't want to +1 anything.
---
