[GitHub] metron issue #911: METRON-1419: Create a SolrDao

2018-02-01 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/911 actually, it may be that feature branch PRs don't automatically close..or hmm, not sure. Anyway, close it please :) ---

[GitHub] metron issue #911: METRON-1419: Create a SolrDao

2018-02-01 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/911 well, I botched the stupid commit message and put `apache/metron` when I meant `apache/feature/METRON-1416-upgrade-solr`. Can you close this PR @merrimanr ? ---

[GitHub] metron issue #911: METRON-1419: Create a SolrDao

2018-02-01 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/911 I looked over the changes and refactor. Thanks a lot for taking care of that, it looks a lot better and is definitely easier to grok, imo, than the old way. I'm +1 on merging this into