[GitHub] metron pull request #606: METRON-980: Short circuit operations for Stellar

2017-06-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/606 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] metron pull request #606: METRON-980: Short circuit operations for Stellar

2017-06-08 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/606#discussion_r121049130 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/stellar/StellarCompiler.java --- @@ -76,14 +93,80 @@ public

[GitHub] metron pull request #606: METRON-980: Short circuit operations for Stellar

2017-06-08 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/606#discussion_r120926071 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/stellar/StellarCompiler.java --- @@ -76,14 +93,80 @@ public

[GitHub] metron pull request #606: METRON-980: Short circuit operations for Stellar

2017-06-07 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/606#discussion_r120623833 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/stellar/StellarCompiler.java --- @@ -76,14 +92,80 @@ public

[GitHub] metron pull request #606: METRON-980: Short circuit operations for Stellar

2017-06-07 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/606#discussion_r120623722 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/stellar/StellarCompiler.java --- @@ -40,14 +40,22 @@ import static

[GitHub] metron pull request #606: METRON-980: Short circuit operations for Stellar

2017-06-07 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/606#discussion_r120622230 --- Diff: metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/window/WindowProcessor.java --- @@ -89,7 +89,7 @@ public

[GitHub] metron pull request #606: METRON-980: Short circuit operations for Stellar

2017-06-06 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/606#discussion_r119960003 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/stellar/StellarCompiler.java --- @@ -76,14 +92,80 @@ public

[GitHub] metron pull request #606: METRON-980: Short circuit operations for Stellar

2017-06-06 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/606#discussion_r119928459 --- Diff: metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/window/WindowProcessor.java --- @@ -89,7 +89,7 @@

[GitHub] metron pull request #606: METRON-980: Short circuit operations for Stellar

2017-06-06 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/606#discussion_r119928654 --- Diff: metron-platform/metron-common/src/main/antlr4/org/apache/metron/common/stellar/generated/Stellar.g4 --- @@ -139,9 +139,21 @@

[GitHub] metron pull request #606: METRON-980: Short circuit operations for Stellar

2017-06-06 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/606#discussion_r119931000 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/stellar/StellarCompiler.java --- @@ -40,14 +40,22 @@ import static

[GitHub] metron pull request #606: METRON-980: Short circuit operations for Stellar

2017-06-06 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/606#discussion_r119948393 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/stellar/StellarCompiler.java --- @@ -40,14 +40,22 @@ import static

[GitHub] metron pull request #606: METRON-980: Short circuit operations for Stellar

2017-06-02 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/606#discussion_r119832707 --- Diff: metron-platform/metron-common/src/test/java/org/apache/metron/common/stellar/StellarTest.java --- @@ -634,6 +679,40 @@ public void

[GitHub] metron pull request #606: METRON-980: Short circuit operations for Stellar

2017-06-02 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/606#discussion_r119831834 --- Diff: metron-platform/metron-common/src/test/java/org/apache/metron/common/stellar/StellarTest.java --- @@ -33,19 +31,66 @@ import

[GitHub] metron pull request #606: METRON-980: Short circuit operations for Stellar

2017-06-01 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/metron/pull/606 METRON-980: Short circuit operations for Stellar ## Contributor Comments Stellar does not currently contain short circuit operations. In most languages, this is an important optimization, but