Re: PR Review Request

2019-10-02 Thread Shane Ardell
I reviewed this PR and left a +1. Great work, Tibor! Because of the size of the PR (ie. near the threshold of being big enough to require a feature branch), I'm going to leave it open until tomorrow for others to chime in if they want. Given your detailed description and great work, I'm sure

PR Review Request

2019-09-23 Thread Tibor Meller
Hi all, Could some of our committers take a look at this? Tamas (ruffle1996) already left a non-binding +1. https://github.com/apache/metron/pull/1514 I found a few issue in the master what I would like to fix in the top of this. (Tickets created and mentioned in the PR desc). Thanks in