[GitHub] incubator-metron pull request #543: METRON-857 Ability to completely build p...

[dlyle65535]

Github user dlyle65535 commented on a diff in the pull request:

https://github.com/apache/incubator-metron/pull/543#discussion_r112808661
  
--- Diff: metron-deployment/packaging/docker/rpm-docker/pom.xml ---
@@ -227,4 +183,97 @@
 
 
 
+
+
+InDocker
+
+
+
+/.dockerenv
+
+
+
+
+
+org.codehaus.mojo
+exec-maven-plugin
+1.5.0
+
+
+rpm-build
+package
+
+exec
+
+
+/bin/bash
+
+-c
+./build.sh 
${project.version}
+
+
+
+
+
+
+
+
+
+NeedsDocker
+
--- End diff --

Won't doing this break the Ansible deployment for quick-dev and full-dev? 
Couldn't you just leave the build-rpms profile and add your 'InDocker' profile?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-metron pull request #543: METRON-857 Ability to completely build p...

[JonZeolla]

Github user JonZeolla commented on a diff in the pull request:

https://github.com/apache/incubator-metron/pull/543#discussion_r112808520
  
--- Diff: metron-deployment/packaging/docker/ansible-docker/Dockerfile ---
@@ -21,10 +21,10 @@ RUN yum install -y tar
 RUN yum install -y wget
 RUN yum groupinstall -y "Development tools"
 RUN yum install -y zlib-dev openssl-devel sqlite-devel bzip2-devel 
libffi-devel
-RUN wget https://www.python.org/ftp/python/2.7.10/Python-2.7.10.tgz -O 
/usr/src/Python-2.7.10.tgz
+RUN wget https://www.python.org/ftp/python/2.7.12/Python-2.7.12.tgz -O 
/usr/src/Python-2.7.12.tgz
--- End diff --

I thought we were pinning to 2.7.11 generally.  I know it's a bit pedantic, 
as the differences are minimal, but perhaps we should just stay with a single 
version across all of our builds?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---