[GitHub] metron pull request #606: METRON-980: Short circuit operations for Stellar
GitHub user cestella opened a pull request: https://github.com/apache/metron/pull/606 METRON-980: Short circuit operations for Stellar ## Contributor Comments Stellar does not currently contain short circuit operations. In most languages, this is an important optimization, but for Stellar on Metron, this is a requirement due to the fact that some variables may be null legitimately and we cannot create multi-line conditionals or temporary variables at the moment. The short circuit operations supported: * short circuited `or` (e.g. `true or FUNC(...)` would never execute `FUNC`) * short circuited `and` (e.g. `false and FUNC(...)` would never execute `FUNC`) * short circuited if/then/else (e.g. `if true then FUNC(...) else FUNC2(...)` will never call `FUNC2`) This should be tested entirely via the unit tests for Stellar. Please review the tests and ensure I've not missed a test case, reviewers. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via: ``` mvn -q clean integration-test install && build_utils/verify_licenses.sh ``` - [x] Have you written or updated unit tests and or integration tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cestella/incubator-metron short_circuit_stellar Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/606.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #606 commit c2a65b200c49a0ab748edf116f23a51b4811e66f Author: cstellaDate: 2017-05-15T16:18:07Z Added test to verify shortcutting works. commit 0c86c2a93216b9f0418e22b78de56c0facb6f55a Author: cstella Date: 2017-05-23T17:59:41Z Merge branch 'master' into short_circuit_stellar commit d038f5c8738b11bba61d3f6cf07abf78b434f883 Author: cstella Date: 2017-06-02T04:21:30Z Short circuit operations. commit ac9ee328ba56296621a982d279a7c356d8a6d82c Author: cstella Date: 2017-06-02T04:21:54Z Merge branch 'master' into short_circuit_stellar commit 7fe0e9b636e3fc6e7642af36de5d57261f6f3b78 Author: cstella Date: 2017-06-02T04:31:46Z Updating some docs. --- If your project is set up for it, you can reply to
[GitHub] metron issue #604: METRON-978: Management UI init script uses hard-coded MET...
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/604 +1 by inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #605: Metron-979 markdown errors in site-book
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/605 Opened a PR against your branch. Generated the documentation and did a fair amount of manual review and couldn't find any broken code blocks, links, etc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron pull request #605: Metron-979 markdown errors in site-book
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/605#discussion_r119767454 --- Diff: metron-deployment/Kerberos-manual-setup.md --- @@ -382,18 +380,18 @@ Push Data 1. Push some sample data to one of the parser topics. E.g for Bro we took raw data from [metron/metron-platform/metron-integration-test/src/main/sample/data/bro/raw/BroExampleOutput](../metron-platform/metron-integration-test/src/main/sample/data/bro/raw/BroExampleOutput) ``` - cat sample-bro.txt | ${KAFKA_HOME}/kafka-broker/bin/kafka-console-producer.sh \ - --broker-list ${BROKERLIST} - --security-protocol SASL_PLAINTEXT \ +cat sample-bro.txt | ${KAFKA_HOME}/kafka-broker/bin/kafka-console-producer.sh \ +--broker-list ${BROKERLIST} --- End diff -- Unrelated to your change, but you throw a '\' at the end of this line while you're in here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [INCOMING] Metron 0.4.0 release (RC3)
I would also appreciate a +1 on https://github.com/apache/metron/pull/605 On 6/1/17, 4:02 PM, "Matt Foley"wrote: The METRON-976 patch looks short and sweet. If someone familiar with that chunk of code can +1 it, it can go in too. On 6/1/17, 3:23 PM, "zeo...@gmail.com" wrote: What about 976, which follows the Kerberized trend for this release? Jon On Thu, Jun 1, 2017, 6:03 PM Nick Allen wrote: > Sounds good, Matt. Looking forward to cutting this release. > > On Thu, Jun 1, 2017 at 5:17 PM, Matt Foley wrote: > > > Hi all, > > > > Now that METRON-844 is in, I plan to proceed with the 0.4.0 release > > candidate. I think 844 was the last item we considered a must-have for > the > > 0.4.0 release, and we want to post this release before incorporating > > several broad changes that should go in the NEXT release not this one > > (METRON-777, 942, 975, 876, etc.). > > > > > > > > Let me know if anything else is considered must-have for 0.4.0, but I’m > > going to proceed unless I hear otherwise. Current HEAD is SHA1= > 85872bd686 > > (METRON-858), I’ll go from there. > > > > > > > > Thanks, > > > > --Matt > > > > > -- Jon
Re: [INCOMING] Metron 0.4.0 release (RC3)
The METRON-976 patch looks short and sweet. If someone familiar with that chunk of code can +1 it, it can go in too. On 6/1/17, 3:23 PM, "zeo...@gmail.com"wrote: What about 976, which follows the Kerberized trend for this release? Jon On Thu, Jun 1, 2017, 6:03 PM Nick Allen wrote: > Sounds good, Matt. Looking forward to cutting this release. > > On Thu, Jun 1, 2017 at 5:17 PM, Matt Foley wrote: > > > Hi all, > > > > Now that METRON-844 is in, I plan to proceed with the 0.4.0 release > > candidate. I think 844 was the last item we considered a must-have for > the > > 0.4.0 release, and we want to post this release before incorporating > > several broad changes that should go in the NEXT release not this one > > (METRON-777, 942, 975, 876, etc.). > > > > > > > > Let me know if anything else is considered must-have for 0.4.0, but I’m > > going to proceed unless I hear otherwise. Current HEAD is SHA1= > 85872bd686 > > (METRON-858), I’ll go from there. > > > > > > > > Thanks, > > > > --Matt > > > > > -- Jon
Re: [INCOMING] Metron 0.4.0 release (RC3)
What about 976, which follows the Kerberized trend for this release? Jon On Thu, Jun 1, 2017, 6:03 PM Nick Allenwrote: > Sounds good, Matt. Looking forward to cutting this release. > > On Thu, Jun 1, 2017 at 5:17 PM, Matt Foley wrote: > > > Hi all, > > > > Now that METRON-844 is in, I plan to proceed with the 0.4.0 release > > candidate. I think 844 was the last item we considered a must-have for > the > > 0.4.0 release, and we want to post this release before incorporating > > several broad changes that should go in the NEXT release not this one > > (METRON-777, 942, 975, 876, etc.). > > > > > > > > Let me know if anything else is considered must-have for 0.4.0, but I’m > > going to proceed unless I hear otherwise. Current HEAD is SHA1= > 85872bd686 > > (METRON-858), I’ll go from there. > > > > > > > > Thanks, > > > > --Matt > > > > > -- Jon
[GitHub] metron pull request #604: added env file source to script
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/604 added env file source to script ## Contributor Comments Fixes a minor bug in the management UI init script. That scripts now matches the REST init script. Tested in full dev. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [ ] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via: ``` mvn -q clean integration-test install && build_utils/verify_licenses.sh ``` - [x] Have you written or updated unit tests and or integration tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/merrimanr/incubator-metron METRON-978 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/604.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #604 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron pull request #570: METRON-937 Pycapa Consume Messages from Begin, End...
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/570 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #570: METRON-937 Pycapa Consume Messages from Begin, End, or St...
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/570 +1, ran through steps. Thanks for the contribution! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron pull request #603: METRON-569: Enrichment topology duplicates message...
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/603 METRON-569: Enrichment topology duplicates messages ## Contributor Comments This issue was discovered a while ago but a PR with a fix was never accepted. In summary, the JoinBolt is acking the last tuple of a split message instead of the tuple containing the original message sent directly from the SplitBolt. This is a problem because the tuple with the original message is anchored in the SplitBolt and the other tuples that go to enrichment bolts are not. The major change in this PR involves storing the tuples in the cache instead of just the message. This way the tuple from the SplitBolt can be retrieved and acked once all the parts have been received in the JoinBolt. A couple other minor changes are also included. I refactored the JoinBoltTest to make it easier to follow and maintain. If anyone thinks this is worse than what we currently have I can revert that. I also bumped up the default cache sizes for the JoinBolts from 10,000 to 100,000. The low initial cache size was causing failures in full dev if I let it run for a while. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [ ] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via: ``` mvn -q clean integration-test install && build_utils/verify_licenses.sh ``` - [x] Have you written or updated unit tests and or integration tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/merrimanr/incubator-metron tuple-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/603.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #603 commit c9ef4f3d9bf023801754267716f108af96827077 Author: merrimanrDate: 2017-05-18T15:17:11Z added logging for unexpected cache issues commit 35f9d6878e07ed604212b0af1877b57cad5871e2 Author: merrimanr Date: 2017-05-22T20:04:52Z Merge remote-tracking branch 'mirror/master' into tuple-fix commit 8c99f70c871a150d7d763eb5c16716f01f3bec06 Author: merrimanr Date: 2017-05-22T20:05:23Z saving tuples instead of messages commit 99ee88697d853aae0f57904660f3ebaf9ea39dee Author: merrimanr Date: 2017-05-22T20:15:30Z
[GitHub] metron issue #547: METRON-858 bro-plugin-kafka is throwing segfaults
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/547 +1 Works like a charm. Tested basic functioning on a multi-node cluster against 1 gbps of canned traffic. Thanks for the contribution @JonZeolla ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #547: METRON-858 bro-plugin-kafka is throwing segfaults
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/547 +1 - although I can't do the stress testing part. Steps followed correctly work perfectly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #570: METRON-937 Pycapa Consume Messages from Begin, End, or St...
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/570 Please take a look-see. I'd like to get this fix in. Travis CI has passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron pull request #570: METRON-937 Pycapa Consume Messages from Begin, End...
Github user nickwallen closed the pull request at: https://github.com/apache/metron/pull/570 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron pull request #570: METRON-937 Pycapa Consume Messages from Begin, End...
GitHub user nickwallen reopened a pull request: https://github.com/apache/metron/pull/570 METRON-937 Pycapa Consume Messages from Begin, End, or Stored Offsets ## Changes * I have altered Pycapa so that it can consume messages from either the beginning, end or the previously stored offsets of a topic. This can be done using the `-o` or `--kafka-offset` flag that can be either `begin`, `end`, or `stored`. This defaults to `end`. * Added additional information when using the `--pretty-print` flag. It will now show the partition and offset for a packet, both on the producer-side (sending packets to Kafka) or the consumer-side (receiving packets from Kafka). ## Testing 1. Install Pycapa. 1. Launch a Kafka Broker on your localhost. For example, using Kafka installed via Brew on my Mac. ``` export KAFKA_HOME=/usr/local/Cellar/kafka/0.10.1.1/ export KAFKA_CONF=$KAFKA_HOME/libexec/config zookeeper-server-start $KAFKA_CONF/zookeeper.properties kafka-server-start $KAFKA_CONF/server.properties ``` 1. Produce some packets. Assumes you're actively using `en0` and Kafka is at `localhost:9092`. Let it run until it completes and captures 50 packets. ``` pycapa --producer \ --interface en0 \ --kafka-broker localhost:9092 \ --kafka-topic pcap \ --max-packets 50 ``` 1. Run the consumer. The consumer will not consume any packets. It starts from the end of the topic, by default, and since there are no active producers, there is nothing new to consume. ``` pycapa --consumer \ --kafka-broker localhost:9092 \ --kafka-topic pcap --pretty-print 1 ``` 1. Run the consumer again, but start from the beginning of the topic. You should be able to consume all 50 packets. ``` pycapa --consumer \ --kafka-broker localhost:9092 \ --kafka-topic pcap --pretty-print 1 --kafka-offset begin ``` ## Pull Request Checklist - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via: - [x] Have you written or updated unit tests and or integration tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: You can merge this pull request into a Git repository by running: $ git pull https://github.com/nickwallen/metron METRON-937 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/570.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #570 commit 23af8e9535ee396ce1a722b51672d4e8a9a69b4d Author: Nick AllenDate: 2017-05-05T21:51:05Z METRON-937 Pycapa Consume Messages from Begin, End, or Stored Offsets --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #600: METRON-976 KafkaUtils doesn't handle SASL_PLAINTEXT
Github user cestella commented on the issue: https://github.com/apache/metron/pull/600 I will happily assign over credit to you. Thanks for catching the bug @justinleet --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #547: METRON-858 bro-plugin-kafka is throwing segfaults
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/547 Just ran through the instructions from scratch and it works for me, can you give it another shot from the beginning? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---