[GitHub] metron pull request #795: METRON-1241: Enable the REST API to use a cache fo...

2017-10-09 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/metron/pull/795 METRON-1241: Enable the REST API to use a cache for the zookeeper config similar to the Bolts ## Contributor Comments Currently, our bolts use a TreeCache to capture and update internal state.

[GitHub] metron pull request #794: METRON-1240 address javadoc warnings in metron-pla...

2017-10-09 Thread dbist
GitHub user dbist opened a pull request: https://github.com/apache/metron/pull/794 METRON-1240 address javadoc warnings in metron-platform and metron-analytics ## Contributor Comments [WARNING] /Users/aervits/NetBeansProjects/METRON/metron/metron-platform/metron-storm-k

Re: who is having problems installing?

2017-10-09 Thread Ronirose Caryll De Castro
That sounds great! Thanks James. *Thank you!* *Caryll* *Ronirose Caryll G. De Castro* *Technical Security Group* Email: ronirose.decas...@pointwest.com.ph Website: www.pointwest.com.ph 9F Rockwell Business Ctr.Tower 3., Brgy. Ugong Ortigas Ave. Pasig City. CONFIDENTIALITY NOTICE: This email

[GitHub] metron pull request #785: METRON-1230: As a stopgap prior to METRON-777, add...

2017-10-09 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/785#discussion_r143585182 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/util/ParserIndex.java --- @@ -0,0 +1,92 @@ +/** + * Licensed to the Apa

[GitHub] metron issue #792: METRON-1237 address javadoc warnings in metron-maas-commo...

2017-10-09 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/792 +1 ---

[GitHub] metron issue #768: Metron 1123: Add group by option using faceted search cap...

2017-10-09 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/768 To handle the missing grouping aggregation. https://www.elastic.co/guide/en/elasticsearch/reference/2.3/search-aggregations-bucket-missing-aggregation.html I *think* this is a backend chan

[GitHub] metron issue #768: Metron 1123: Add group by option using faceted search cap...

2017-10-09 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/768 When grouping, we are implicitly filtering any alerts that do not have a value defined for the 'group by' field. For example, in this screenshot there are roughly 44k alarms. I have gr

[GitHub] metron pull request #768: Metron 1123: Add group by option using faceted sea...

2017-10-09 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/768#discussion_r143565157 --- Diff: metron-interface/metron-alerts/src/app/alerts/alerts-list/tree-view/tree-view.component.ts --- @@ -0,0 +1,319 @@ +/** + * Licensed to t

[GitHub] metron pull request #785: METRON-1230: As a stopgap prior to METRON-777, add...

2017-10-09 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/785#discussion_r143555806 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/MergeAndShadeTransformer.java --- @@ -0,0 +1,90 @@ +/** +

[GitHub] metron pull request #785: METRON-1230: As a stopgap prior to METRON-777, add...

2017-10-09 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/785#discussion_r143555784 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/MergeAndShadeTransformer.java --- @@ -0,0 +1,90 @@ +/** +

[GitHub] metron pull request #785: METRON-1230: As a stopgap prior to METRON-777, add...

2017-10-09 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/785#discussion_r143555770 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/MergeAndShadeTransformer.java --- @@ -0,0 +1,90 @@ +/** +

[GitHub] metron pull request #792: METRON-1237 address javadoc warnings in metron-maa...

2017-10-09 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/792#discussion_r143555210 --- Diff: metron-analytics/metron-maas-common/src/main/java/org/apache/metron/maas/discovery/ServiceDiscoverer.java --- @@ -329,7 +324,7 @@ public ModelEnd

[GitHub] metron pull request #792: METRON-1237 address javadoc warnings in metron-maa...

2017-10-09 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/792#discussion_r143555348 --- Diff: metron-analytics/metron-maas-common/src/main/java/org/apache/metron/maas/queue/QueueHandler.java --- @@ -42,7 +42,7 @@ /** * Creat

[GitHub] metron pull request #792: METRON-1237 address javadoc warnings in metron-maa...

2017-10-09 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/792#discussion_r14321 --- Diff: metron-analytics/metron-maas-common/src/main/java/org/apache/metron/maas/config/MaaSConfig.java --- @@ -50,7 +50,7 @@ public void setServiceRoot(

[GitHub] metron pull request #792: METRON-1237 address javadoc warnings in metron-maa...

2017-10-09 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/792#discussion_r143554825 --- Diff: metron-analytics/metron-maas-common/src/main/java/org/apache/metron/maas/discovery/ServiceDiscoverer.java --- @@ -219,7 +214,7 @@ public void unr

[GitHub] metron pull request #785: METRON-1230: As a stopgap prior to METRON-777, add...

2017-10-09 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/785#discussion_r143555004 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/ParserTopologyCLI.java --- @@ -285,7 +285,14 @@ public static Opt

[GitHub] metron pull request #785: METRON-1230: As a stopgap prior to METRON-777, add...

2017-10-09 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/785#discussion_r143554494 --- Diff: metron-interface/metron-rest/src/main/scripts/metron-rest.sh --- @@ -47,6 +55,15 @@ rest_jar_pattern="${METRON_HOME}/lib/metron-rest*.jar" res

[GitHub] metron pull request #785: METRON-1230: As a stopgap prior to METRON-777, add...

2017-10-09 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/785#discussion_r143554015 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/MergeAndShadeTransformer.java --- @@ -0,0 +1,90 @@ +/** +

[GitHub] metron issue #792: METRON-1237 address javadoc warnings in metron-maas-commo...

2017-10-09 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/792 Ah, you are correct, e.g. ``` [WARNING] /Users/mmiklavcic/devprojects/metron/metron-analytics/metron-maas-common/src/main/java/org/apache/metron/maas/queue/QueueHandler.java:46: warning

[GitHub] metron pull request #785: METRON-1230: As a stopgap prior to METRON-777, add...

2017-10-09 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/785#discussion_r143553954 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/ParserTopologyCLI.java --- @@ -285,7 +285,14 @@ public static Opt

[GitHub] metron pull request #785: METRON-1230: As a stopgap prior to METRON-777, add...

2017-10-09 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/785#discussion_r143552937 --- Diff: metron-interface/metron-rest/pom.xml --- @@ -163,6 +163,7 @@ org.apache.metron metron-parsers ${

[GitHub] metron pull request #785: METRON-1230: As a stopgap prior to METRON-777, add...

2017-10-09 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/785#discussion_r143544318 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/SensorParserConfigServiceImpl.java --- @@ -122,29 +123,15 @@ publi

[GitHub] metron pull request #785: METRON-1230: As a stopgap prior to METRON-777, add...

2017-10-09 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/785#discussion_r143546323 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/ParserTopologyCLI.java --- @@ -285,7 +285,14 @@ public static Opt

[GitHub] metron pull request #785: METRON-1230: As a stopgap prior to METRON-777, add...

2017-10-09 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/785#discussion_r143542088 --- Diff: metron-interface/metron-rest/pom.xml --- @@ -163,6 +163,7 @@ org.apache.metron metron-parsers ${

[GitHub] metron pull request #785: METRON-1230: As a stopgap prior to METRON-777, add...

2017-10-09 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/785#discussion_r143550601 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/MergeAndShadeTransformer.java --- @@ -0,0 +1,90 @@ +/** +

[GitHub] metron pull request #785: METRON-1230: As a stopgap prior to METRON-777, add...

2017-10-09 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/785#discussion_r143547079 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/MergeAndShadeTransformer.java --- @@ -0,0 +1,90 @@ +/** +

[GitHub] metron pull request #785: METRON-1230: As a stopgap prior to METRON-777, add...

2017-10-09 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/785#discussion_r143552344 --- Diff: metron-interface/metron-rest/src/main/scripts/metron-rest.sh --- @@ -47,6 +55,15 @@ rest_jar_pattern="${METRON_HOME}/lib/metron-rest*.jar" res

[GitHub] metron pull request #785: METRON-1230: As a stopgap prior to METRON-777, add...

2017-10-09 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/785#discussion_r143549913 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/MergeAndShadeTransformer.java --- @@ -0,0 +1,90 @@ +/** +

[GitHub] metron pull request #785: METRON-1230: As a stopgap prior to METRON-777, add...

2017-10-09 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/785#discussion_r143550076 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/MergeAndShadeTransformer.java --- @@ -0,0 +1,90 @@ +/** +

[GitHub] metron pull request #785: METRON-1230: As a stopgap prior to METRON-777, add...

2017-10-09 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/785#discussion_r143549304 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/MergeAndShadeTransformer.java --- @@ -0,0 +1,90 @@ +/** +

[GitHub] metron pull request #785: METRON-1230: As a stopgap prior to METRON-777, add...

2017-10-09 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/785#discussion_r143546668 --- Diff: metron-platform/metron-parsers/pom.xml --- @@ -125,6 +125,12 @@ org.apache.storm +stor

[GitHub] metron pull request #787: METRON-1232: Alert status changes are not reflecte...

2017-10-09 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/787#discussion_r143541485 --- Diff: metron-interface/metron-alerts/e2e/alerts-list/alerts-list.po.ts --- @@ -231,10 +231,12 @@ export class MetronAlertsPage { } c

[GitHub] metron pull request #787: METRON-1232: Alert status changes are not reflecte...

2017-10-09 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/787#discussion_r143535792 --- Diff: metron-interface/metron-alerts/src/app/shared/directives/alert-search.directive.ts --- @@ -130,7 +130,7 @@ export class AlertSearchDirective im

[GitHub] metron issue #792: METRON-1237 address javadoc warnings in metron-maas-commo...

2017-10-09 Thread dbist
Github user dbist commented on the issue: https://github.com/apache/metron/pull/792 @mmiklavc my understanding is that if we leave off @return tag, javadoc will still throw a warning about a missing return tag, please advise, I'm impartial. ---

[GitHub] metron issue #789: METRON-1233: Remove description of Global configuration f...

2017-10-09 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/789 Thanks for the contribution @DimDroll. Can you take a look at https://github.com/apache/metron/pull/791 - does this help? There are some relevant global config options for enrichment. ---

[GitHub] metron issue #792: METRON-1237 address javadoc warnings in metron-maas-commo...

2017-10-09 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/792 Might it be better to leave off the @return altogether where the methods are self-describing? ---

[GitHub] metron issue #793: METRON-1226 Searching Can Errantly Query the Wrong Indice...

2017-10-09 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/793 This is looking pretty good by inspection. Good minor refactorings and javadoc additions as well. I'd like to run it up in full dev when I get a moment. ---

Re: Metron 0.4.2 release date

2017-10-09 Thread Michael Miklavcic
Hey Ali, I'm currently deep in ES 5.x migration work. If you have any specific concerns or requests that have not yet been covered on the mailing list, please feel free to comment. Best, Mike On Mon, Oct 9, 2017 at 9:05 AM, James Sirota wrote: > I would expect ES 5.x support to be in the next v

Re: Metron 0.4.2 release date

2017-10-09 Thread James Sirota
I would expect ES 5.x support to be in the next version of Metron 08.10.2017, 18:18, "zeo...@gmail.com" : > There's an ongoing conversation regarding client support in Metron here >

Re: who is having problems installing?

2017-10-09 Thread James Sirota
Ok. In that case instead of having a meeting I'll clean up the docs. I'll try to finish this up by the end of the week. Thanks, James 06.10.2017, 13:44, "zeo...@gmail.com" : > First would be to migrate docs from the wiki into the site-book so we have > a more concise place to point people to r

[GitHub] metron pull request #793: METRON-1226 Searching Can Errantly Query the Wrong...

2017-10-09 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/793#discussion_r143481097 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/utils/ElasticsearchUtils.java --- @@ -45,15 +49,30 @@ public

[GitHub] metron pull request #793: METRON-1226 Searching Can Errantly Query the Wrong...

2017-10-09 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/793#discussion_r143473906 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/utils/ElasticsearchUtils.java --- @@ -45,15 +49,30 @@ public s

[GitHub] metron pull request #793: METRON-1226 Searching Can Errantly Query the Wrong...

2017-10-09 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/793#discussion_r143473489 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java --- @@ -154,9 +134,9 @@ protected Se

[GitHub] metron issue #793: METRON-1226 Searching Can Errantly Query the Wrong Indice...

2017-10-09 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/793 cool, just making sure :) ---

[GitHub] metron issue #793: METRON-1226 Searching Can Errantly Query the Wrong Indice...

2017-10-09 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/793 @cestella Not that I am aware of. I launched Full Dev and was able to submit queries and use the Alerts UI as before. I will add that to the "Test" section for completeness. ---

[GitHub] metron issue #793: METRON-1226 Searching Can Errantly Query the Wrong Indice...

2017-10-09 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/793 Does this cause any issues in the alerts UI? ---

[GitHub] metron pull request #788: METRON-1223: Support for adding comments to alerts

2017-10-09 Thread simonellistonball
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/788#discussion_r143470175 --- Diff: metron-interface/metron-alerts/src/app/alerts/alert-details/alert-details.component.ts --- @@ -133,6 +173,40 @@ export class AlertDetail

[GitHub] metron pull request #791: METRON-1235: Document the properties pulled from t...

2017-10-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/791 ---

[GitHub] metron pull request #793: METRON-1226 Searching Can Errantly Query the Wrong...

2017-10-09 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/793 METRON-1226 Searching Can Errantly Query the Wrong Indices The ElasticsearchDAO can errantly query the wrong indices under certain conditions. This can occur when there are at least two different

Re: Quick Dev

2017-10-09 Thread Justin Leet
Created METRON-1239 to track this. On Fri, Oct 6, 2017 at 8:59 AM, Simon Elliston Ball < si...@simonellistonball.com> wrote: > I think the codelab build might be more Metron archeologist! > > +1 to a big old clearout, especially on the wiki. > >

[GitHub] metron issue #768: Metron 1123: Add group by option using faceted search cap...

2017-10-09 Thread iraghumitra
Github user iraghumitra commented on the issue: https://github.com/apache/metron/pull/768 @merrimanr Added e2e tests for escalation actions in tree view ---