[GitHub] metron issue #862: METRON-1343: Swagger UI for User Controller needs request...

2017-12-12 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/862 Thanks @ottobackwards . Updated the manual verification steps. ---

Re: [DISCUSS] Community Meetings

2017-12-12 Thread larry mccay
Not sure about posting the recordings - you will need to check and make sure that doesn't violate anything. Just a friendly reminder... It is important that meetings have notes and a summary that is sent out describing topics to be decided on the mailing list. No decisions can be made in the

[GitHub] metron pull request #864: METRON-1348 Metron Service Checks Use Wrong Hostna...

2017-12-12 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/864#discussion_r156526514 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/status_params.py ---

[GitHub] metron pull request #864: METRON-1348 Metron Service Checks Use Wrong Hostna...

2017-12-12 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/864 METRON-1348 Metron Service Checks Use Wrong Hostname The Metron service check can often use the incorrect hostname when checking the Alerts UI, Management UI, and REST services. This results in

[GitHub] metron issue #857: METRON-1340: Improve e2e tests for metron alerts

2017-12-12 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/857 I was reviewing the protractor documentation [here](http://www.protractortest.org/#/async-await) and I noticed this: > Don’t forget to turn off control_flow, you cannot use a mix of

New Travis Build Image

2017-12-12 Thread Otto Fowler
The new Trusty image in travis that just landed breaks the build for one of my PR’s. I am not sure why, but I verified that going back to the old image resolves the problem. If you see a build fail, and it works locally or it is failing in a strange way, be wary. ottO

Re: [DISCUSS] Upcoming Release

2017-12-12 Thread zeo...@gmail.com
So I was looking at some of the docs and saw that Upgrading.md has a dangling section that maybe should be removed. Link , link Jon On Tue, Dec 12, 2017 at 2:21 PM Matt Foley

[GitHub] metron issue #857: METRON-1340: Improve e2e tests for metron alerts

2017-12-12 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/857 OK, I was able to get the tests to run. First run I get a single error. @merrimanr and I are talking through it now. ``` [INFO] Test spec for login page [INFO] ✗ should

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-12-12 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/774 The new Trusty image breaks my build. I need to figure out why exactly, so I'll be trying a few things. ---

[GitHub] metron issue #857: METRON-1340: Improve e2e tests for metron alerts

2017-12-12 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/857 Should we also run the tests using the new Maven profile? `mvn test -Pe2e` The README should probably be updated to reflect this as well. ---

[GitHub] metron issue #857: METRON-1340: Improve e2e tests for metron alerts

2017-12-12 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/857 A couple notes for the community - if your node/npm versions are out of date and you've already built the project, you'll run into trouble with versions not matching against the expected node

[GitHub] metron pull request #834: METRON-1306: When index template install fails, we...

2017-12-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/834 ---

[GitHub] metron issue #857: METRON-1340: Improve e2e tests for metron alerts

2017-12-12 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/857 Seems that my NodeJS and npm versions got mangled since last time I ran this. Perhaps migrating laptops, upgrading to High Sierra, and switching from MacPorts to HomeBrew might have something to do

[GitHub] metron issue #834: METRON-1306: When index template install fails, we should...

2017-12-12 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/834 I'm good +1 ---

[GitHub] metron issue #857: METRON-1340: Improve e2e tests for metron alerts

2017-12-12 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/857 Something I'm missing? ``` ./scripts/start-server-for-e2e.sh /Users/mmiklavcic/devprojects/metron/metron-interface/metron-alerts/node_modules/@angular/cli/bin/ng:7 const

[GitHub] metron issue #834: METRON-1306: When index template install fails, we should...

2017-12-12 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/834 As far as THIS PR, I think it has the 2 +1s that I was waiting for. As for a long-range fix, I think it's going to happen outside of this PR. Did I miss anything? ---

Re: [DISCUSS] Upcoming Release

2017-12-12 Thread Matt Foley
Thanks to Jon, Otto, and Nick for looking over RC1. Tonight I’ll fix the RAT glitch, build RC2, and put it to formal vote. Regards, --Matt On 12/12/17, 5:14 AM, "Nick Allen" wrote: RC1 is looking good to me. I validated the MD5s, built Metron, built the Bro plugin

“777” Feature Branch Redux

2017-12-12 Thread Otto Fowler
I have created a new feature branch feature/METRON-1211-extensions-parsers-gradual to track the parser extension work and have rebased https://github.com/apache/metron/pull/774 on to that. I have also updated confluence and jira :

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-12-12 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/774 I have created a new feature branch feature/METRON-1211-extensions-parsers-gradual to track this. and have rebased this PR on to that. I have also updated confluence and jira :

[GitHub] metron issue #834: METRON-1306: When index template install fails, we should...

2017-12-12 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/834 I expect to address this in the "777" feature branch/ parser effort. ---

[GitHub] metron issue #834: METRON-1306: When index template install fails, we should...

2017-12-12 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/834 After reading this whole thread I agree with @ottobackwards. If we installed and started all services and THEN installed our parsers separately this whole issue goes away. If a parser's template

Re: [DISCUSS] Community Meetings

2017-12-12 Thread Simon Elliston Ball
Yes, I do. I suspect the best bet will be to post recordings somewhere on the apache.org metron site. Simon > On 12 Dec 2017, at 18:36, Otto Fowler wrote: > > Excellent, do you have the > 40 min + record option? > > > On December 12, 2017 at

Re: [DISCUSS] Community Meetings

2017-12-12 Thread Otto Fowler
Excellent, do you have the > 40 min + record option? On December 12, 2017 at 13:19:55, Simon Elliston Ball ( si...@simonellistonball.com) wrote: Happy to volunteer a zoom room. That seems to have worked for most in the past. Simon > On 12 Dec 2017, at 18:09, Otto Fowler

Re: [DISCUSS] Community Meetings

2017-12-12 Thread Simon Elliston Ball
Happy to volunteer a zoom room. That seems to have worked for most in the past. Simon > On 12 Dec 2017, at 18:09, Otto Fowler wrote: > > Thanks! I think I’d like something hosted though. > > > On December 12, 2017 at 11:18:52, Ahmed Shah

Re: [DISCUSS] Community Meetings

2017-12-12 Thread Otto Fowler
Thanks! I think I’d like something hosted though. On December 12, 2017 at 11:18:52, Ahmed Shah (ahmeds...@cmail.carleton.ca) wrote: Hello, wrt "- How are we going to host it"... I've used BigBlueButton as an end user at our University. It is LGPL open source. https://bigbluebutton.org/

Re: [DISCUSS] Community Meetings

2017-12-12 Thread Ahmed Shah
Hello, wrt "- How are we going to host it"... I've used BigBlueButton as an end user at our University. It is LGPL open source. https://bigbluebutton.org/ https://bigbluebutton.org/developers/ -Ahmed ___ Ahmed Shah (PMP, M. Eng.)

[GitHub] metron issue #853: METRON-1337: List of facets should not be hardcoded

2017-12-12 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/853 Ambari does not manage this config. It is only included in the base application.yml as a default setting. I don't feel like this setting should be in Ambari for a couple reasons: changing it

[GitHub] metron issue #853: METRON-1337: List of facets should not be hardcoded

2017-12-12 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/853 What I get to was, the setting should be exposed in ambari if ambari manages the config. ---

[GitHub] metron pull request #858: METRON-1344: Externalize the infrastructural compo...

2017-12-12 Thread merrimanr
GitHub user merrimanr reopened a pull request: https://github.com/apache/metron/pull/858 METRON-1344: Externalize the infrastructural components using integration tests ## Contributor Comments This PR will add infrastructure to our Travis build that will allow the Alerts UI

[GitHub] metron pull request #858: METRON-1344: Externalize the infrastructural compo...

2017-12-12 Thread merrimanr
Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/858 ---

[GitHub] metron issue #858: METRON-1344: Externalize the infrastructural components u...

2017-12-12 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/858 @merrimanr, I have created labels in jira that are applicable to feature branch Jiras, This will allow for tracking these jiras in confluence as I have done here :

[GitHub] metron issue #853: METRON-1337: List of facets should not be hardcoded

2017-12-12 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/853 Each environment will have it's own application.yaml. Full dev has one, our testing environment has one, Ambari ships one etc. There is also a base application.yaml that has the defaults

[GitHub] metron issue #579: METRON-941 fix PaloAltoParser

2017-12-12 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/579 @ctramnitz is there any update on this PR? Is there something we can do to help? ---

[GitHub] metron issue #834: METRON-1306: When index template install fails, we should...

2017-12-12 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/834 Where are we at with this? ---

[GitHub] metron issue #853: METRON-1337: List of facets should not be hardcoded

2017-12-12 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/853 Does ambari own the application.yaml currently? ---

[GitHub] metron issue #862: METRON-1343: Swagger UI for User Controller needs request...

2017-12-12 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/862 Like, - Spin up Full Dev - Go to Swagger at http://node1:4200(?) - You should see X now ---

[GitHub] metron issue #862: METRON-1343: Swagger UI for User Controller needs request...

2017-12-12 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/862 Great, can you list that as the manual verification please? ---

[GitHub] metron issue #862: METRON-1343: Swagger UI for User Controller needs request...

2017-12-12 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/862 Hi @ottobackwards , we don't need new test. Currently on the Swagger UI we see that API '/api/v1/user' is listed with all the Request methods. After this fix we will see it will be listed for only

[GitHub] metron issue #854: Experimental Improvements - Feedback Only - Do Not Merge

2017-12-12 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/854 based on @justinleet 's comment, where do we stand with this ---

[GitHub] metron issue #856: METRON-1339 Stellar Shell functionality to verify stored ...

2017-12-12 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/856 @nickwallen any feedback, does the annotated approach match what you imagined? ---

[GitHub] metron pull request #859: METRON-1345: Update EC2 README for custom Ansible ...

2017-12-12 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/859#discussion_r156374333 --- Diff: metron-deployment/roles/ambari_config/vars/small_cluster.yml --- @@ -87,6 +87,8 @@ configurations: topology.classpath: '{{

[GitHub] metron issue #862: METRON-1343: Swagger UI for User Controller needs request...

2017-12-12 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/862 Hi! Thanks for the contribution. How can we test these changes? Do we need new tests in the code for this change ? Please consider the items in the PR checklist ( listed

[GitHub] metron pull request #863: METRON-1347: Indexing Topology should fail tuples ...

2017-12-12 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/863#discussion_r156372312 --- Diff: metron-platform/metron-indexing/README.md --- @@ -15,6 +15,12 @@ Indices are written in batch and the batch size and batch timeout are

[GitHub] metron pull request #863: METRON-1347: Indexing Topology should fail tuples ...

2017-12-12 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/863#discussion_r156372868 --- Diff: metron-platform/metron-writer/src/main/java/org/apache/metron/writer/bolt/BulkMessageWriterBolt.java --- @@ -229,17 +239,30 @@ public void

[GitHub] metron issue #859: METRON-1345: Update EC2 README for custom Ansible tags

2017-12-12 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/859 Nice. I'm glad you uncovered the issue with the REST API. Reaffirming +1 ---

Re: [DISCUSS] Upcoming Release

2017-12-12 Thread Nick Allen
RC1 is looking good to me. I validated the MD5s, built Metron, built the Bro plugin and reviewed the other artifacts like release notes. Running the RAT check on a 'clean' Metron does not produce any errors for me. It is only after building Metron, which pulls in additional Node dependencies,