[GitHub] metron-bro-plugin-kafka issue #5: METRON-1407: Metron-Bro-Kafka plugin unabl...

2018-01-17 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/5 There we go, yeah that was significantly more delayed than normal. @z0r0 Would you mind sending an email to the dev list to get you added as a contributor on Jira so we

Upgrade from 0.4.1 to 0.4.2 fails on Alerts UI

2018-01-17 Thread Laurens Vets
Hello List, Targeting a wider audience here, see bug report https://issues.apache.org/jira/browse/METRON-1408. Basically, when I upgrade from 0.4.1 to 0.4.2 I run into issues with the Alerts UI. I built the Metron 0.4.2 RPMs and did an upgrade of my current 0.4.1 install with: "rpm -Uvh

[GitHub] metron-bro-plugin-kafka issue #5: METRON-1407: Metron-Bro-Kafka plugin unabl...

2018-01-17 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/5 I believe the linking *is* working. Maybe it is just lagged. As far as Jira rights, I'm looking into it, but I cannot as of this moment execute that ---

[GitHub] metron-bro-plugin-kafka issue #5: METRON-1407: Metron-Bro-Kafka plugin unabl...

2018-01-17 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/5 Great catch, thanks @z0r0 I will check this out soon. Not sure why this isn't auto linking to https://issues.apache.org/jira/browse/METRON-1407 though... I can't assign

[GitHub] metron-bro-plugin-kafka pull request #5: Fixing a spelling error causing fin...

2018-01-17 Thread z0r0
GitHub user z0r0 opened a pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/5 Fixing a spelling error causing find_libary to fail find_library was failing. I found this typo, and it solved my issue. You can merge this pull request into a Git repository by

[GitHub] metron issue #899: METRON-1405: Add Boyer-Moore majority vote algorithm to S...

2018-01-17 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/899 @Test public void boyerMoore_calculates_plurality_from_list_of_values_o() throws Exception { List items = Arrays.asList(1, 1, 1,1, 2,2,3,3,4,4,4); BoyerMooreState state

[GitHub] metron pull request #899: METRON-1405: Add Boyer-Moore majority vote algorit...

2018-01-17 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/899#discussion_r162134157 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/MathFunctions.java --- @@ -220,4 +219,156 @@ public

[GitHub] metron issue #899: METRON-1405: Add Boyer-Moore majority vote algorithm to S...

2018-01-17 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/899 Yes - good catch - this not actually going to work without some modification. The count zeroes out when a majority is held by non-m values and gets reset to a new non-plurality, non-majority

[GitHub] metron pull request #899: METRON-1405: Add Boyer-Moore majority vote algorit...

2018-01-17 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/899#discussion_r162127870 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/MathFunctions.java --- @@ -220,4 +219,156 @@ public Object

Re: Checkstyle - have we run it?

2018-01-17 Thread Justin Leet
I would expect so. Honestly, it's probably more just getting PRs out on it, and adjusting if it ends up causing problems. Given that we just did a release, this is probably the best time to at least do a couple modules, see if any problems are caused, and clean it up afterwards. On Wed, Jan 17,

Re: Checkstyle - have we run it?

2018-01-17 Thread Otto Fowler
Thanks, I have check style up and integrated, and I have been running it on *new* files etc. But now when I work in existing, I obviously see the issues. I *think* in the end module by module is the only feasible way is it not? On January 17, 2018 at 12:15:33, Justin Leet

Re: Checkstyle - have we run it?

2018-01-17 Thread Justin Leet
It exists, we have a style that can be imported and setup in IntelliJ with the Checkstyle plugin Reformatting can also be done in IntelliJ (which will help a lot, but not all issues). This can be done on a file mask basis (e.g. just do "*.java" files to avoid reformatting other things), and could

Checkstyle - have we run it?

2018-01-17 Thread Otto Fowler
Where are we with the check style integration? How are we handling check style in existing modules? I seem to remember talk of a script or something to reformat? It would be nice to get some of the warnings out of the builds, how should we go about it? ottO

[GitHub] metron pull request #888: METRON-1389: Zeppelin notebook import does not wor...

2018-01-17 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/888#discussion_r162029895 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_master.py --- @@