Re: [DISCUSS] Time to remove github updates from dev?

2018-01-19 Thread zeo...@gmail.com
I would give that +1 as well. Jon On Fri, Jan 19, 2018 at 3:32 PM Casey Stella wrote: > I could get behind that. > > On Fri, Jan 19, 2018 at 3:31 PM, Andre wrote: > > > Folks, > > > > May I suggest Metron follows the NiFi mailing list strategy (we

Re: [DISCUSS] Time to remove github updates from dev?

2018-01-19 Thread Casey Stella
I could get behind that. On Fri, Jan 19, 2018 at 3:31 PM, Andre wrote: > Folks, > > May I suggest Metron follows the NiFi mailing list strategy (we got > inspired by another project but I don't recall the name) and remove the > github comments from the dev list? > > Within

[DISCUSS] Time to remove github updates from dev?

2018-01-19 Thread Andre
Folks, May I suggest Metron follows the NiFi mailing list strategy (we got inspired by another project but I don't recall the name) and remove the github comments from the dev list? Within NiFi we have both the dev and the issues lists. dev is for humans, issues is for JIRA and github

[GitHub] metron issue #902: METRON-1413 Add Metron Commit Tool

2018-01-19 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/902 Maybe we can have reviewer tools and put checkout-pr in it? For those without an apache id? ---

[GitHub] metron issue #902: METRON-1413 Add Metron Commit Tool

2018-01-19 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/902 I don't see the value in `checkout-pr` any longer. You can just use `prepare-commit` which gives you the exact view of what the code would look-like when its merged. ---

[GitHub] metron issue #902: METRON-1413 Add Metron Commit Tool

2018-01-19 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/902 I think checkout-pr is equally as valuable and should be included ---

[GitHub] metron issue #902: METRON-1413 Add Metron Commit Tool

2018-01-19 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/metron/pull/902 I have a mild preference for dev-utilities, since "support" has many meanings. ---

[GitHub] metron issue #902: METRON-1413 Add Metron Commit Tool

2018-01-19 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/902 Thanks @mattf-horton. Either of those suggestions works for me; 'dev-support' or 'dev-utilities'. I'll let others chime in with their preference and then update it accordingly. ---

[GitHub] metron issue #902: METRON-1413 Add Metron Commit Tool

2018-01-19 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/metron/pull/902 @nickwallen , excellent to get this into the main repo, and totally agree with the reorganization. My only suggestion is that the main directory, currently named "metron-dev-support",

[GitHub] metron pull request #902: METRON-1413 Add Metron Commit Tool

2018-01-19 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/902#discussion_r162688528 --- Diff: metron-dev-support/committer-utils/README.md --- @@ -0,0 +1,96 @@ +# Committer Tools + +This project contains tools to assist Apache

[GitHub] metron pull request #902: METRON-1413 Add Metron Commit Tool

2018-01-19 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/902 METRON-1413 Add Metron Commit Tool This PR contributes the `prepare-merge` tool that many (some?) contributors use back to the project itself. Up until now, it has been managed in a separate

[GitHub] metron pull request #901: METRON-1410 Check for existing HBASE tables before...

2018-01-19 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/901#discussion_r162677587 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/enrichment_commands.py ---

[GitHub] metron pull request #901: METRON-1410 Check for existing HBASE tables before...

2018-01-19 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/901#discussion_r162677398 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/enrichment_commands.py ---

[GitHub] metron pull request #897: METRON-1395:Documentation missing for Produce a me...

2018-01-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/897 ---

[GitHub] metron pull request #888: METRON-1389: Zeppelin notebook import does not wor...

2018-01-19 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/888#discussion_r162669706 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_master.py --- @@

[GitHub] metron issue #890: METRON-1391 Fix for README.md in Metron Management

2018-01-19 Thread lvets
Github user lvets commented on the issue: https://github.com/apache/metron/pull/890 +1 from me, both changes look good. ---

[GitHub] metron pull request #900: METRON-1411: Fix sed command in Upgrading.md

2018-01-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/900 ---

[GitHub] metron issue #897: METRON-1395:Documentation missing for Produce a message t...

2018-01-19 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/897 +1 Good catch @MohanDV . Thanks ---

[GitHub] metron issue #900: METRON-1411: Fix sed command in Upgrading.md

2018-01-19 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/900 +1 by inspection. good catch. ---

[GitHub] metron pull request #901: METRON-1410 Check for existing HBASE tables before...

2018-01-19 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/901#discussion_r162666350 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/enrichment_commands.py ---

[GitHub] metron pull request #901: METRON-1410 Check for existing HBASE tables before...

2018-01-19 Thread ottobackwards
GitHub user ottobackwards opened a pull request: https://github.com/apache/metron/pull/901 METRON-1410 Check for existing HBASE tables before creating After upgrade, indexing will not restart because it fails to create HBase tables. This is because they already exist from the

[GitHub] metron issue #891: METRON-1282 creating a new topic using the rest end point...

2018-01-19 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/891 Created another pull request which will address this issue ---

[GitHub] metron pull request #891: METRON-1282 creating a new topic using the rest en...

2018-01-19 Thread MohanDV
Github user MohanDV closed the pull request at: https://github.com/apache/metron/pull/891 ---