Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/853#discussion_r169515112
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/AlertServiceImpl.java
---
@@ -37,15 +47,21 @@
@Service
Wrong version of vagrant?
Installing the 'vagrant-aws' plugin. This can take a few minutes...
/usr/lib/ruby/2.3.0/rubygems/specification.rb:2289:in `raise_if_conflicts':
Unable to activate fog-1.42.0, because json-1.8.3 conflicts with json (~>
2.0) (Gem::ConflictError)
from
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/853#discussion_r169455383
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/AlertServiceImpl.java
---
@@ -37,15 +47,21 @@
@Service
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/853
This looks great, one small comment from review
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/853#discussion_r169441455
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/AlertServiceImpl.java
---
@@ -37,15 +47,21 @@
@Service
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/853
I took @ottobackwards's suggestion and added a "type" parameter that can be
used to independently manage user settings for different types of clients. I
moved the users settings for the Alerts UI
