Re: [DISCUSS] Merging Solr feature branch (METRON-1416) into master

2018-06-21 Thread Michael Miklavcic
+1 let's do it. On Thu, Jun 21, 2018, 2:01 PM Nick Allen wrote: > +1 I think we should merge ASAP and kill the feature branch. I think the > work has well surpassed the level required to get it into master. > > On Thu, Jun 21, 2018 at 1:20 PM, Justin Leet > wrote: > > > Hi All, > > > > The Sol

Re: [DISCUSS] Merging Solr feature branch (METRON-1416) into master

2018-06-21 Thread Nick Allen
+1 I think we should merge ASAP and kill the feature branch. I think the work has well surpassed the level required to get it into master. On Thu, Jun 21, 2018 at 1:20 PM, Justin Leet wrote: > Hi All, > > The Solr branch (/feature/METRON-1416-upgrade-solr >

Re: [DISCUSS] Merging Solr feature branch (METRON-1416) into master

2018-06-21 Thread Casey Stella
I think that we should merge now, but I’m perhaps biased since I did one of the hard merges. I think that since the major outstanding bug is being worked and we are otherwise feature complete, the feature branch did its job and we are ready to merge. On Thu, Jun 21, 2018 at 10:21 Justin Leet wrote

[DISCUSS] Merging Solr feature branch (METRON-1416) into master

2018-06-21 Thread Justin Leet
Hi All, The Solr branch (/feature/METRON-1416-upgrade-solr ), has been progressing for a while now. I'd like to open up discussion around what it takes to get it into master. The JIRA for tracking this feature branch is METR