Re: [DISCUSS] Metron Release 0.6.0?

2018-09-05 Thread Justin Leet
Makes sense. Do we have any objection to just going to the artifact being 0.2? Or do we want to keep the mixed versioning and just live with it, at least for now? On Wed, Sep 5, 2018 at 8:58 PM zeo...@gmail.com wrote: > I think mattf-horton just did that as a part of convention. He handled > t

Re: [DISCUSS] Metron Release 0.6.0?

2018-09-05 Thread zeo...@gmail.com
I think mattf-horton just did that as a part of convention. He handled that part, and I did the 0.1 tagging (as a prereq to this ) last time the package was released. Jon On

Re: [DISCUSS] Metron Release 0.6.0?

2018-09-05 Thread Justin Leet
Any idea why we released it as 0.1.0 in the artifacts version? I'm fine with doing x.y if we need to, but I would like the artifact versioning to be consistent if possible. On Wed, Sep 5, 2018 at 8:26 PM zeo...@gmail.com wrote: > I lied, we didn't need to update our btests because it's limited

Re: [DISCUSS] Metron Release 0.6.0?

2018-09-05 Thread zeo...@gmail.com
I lied, we didn't need to update our btests because it's limited to a major and minor version. https://github.com/apache/metron-bro-plugin-kafka/blob/master/src/Plugin.cc#L33-L34 Jon On Wed, Sep 5, 2018 at 8:10 PM zeo...@gmail.com wrote: > I looked into x.y.z back when we released 0.1 and it w

Re: [DISCUSS] Metron Release 0.6.0?

2018-09-05 Thread zeo...@gmail.com
I looked into x.y.z back when we released 0.1 and it was not possible in bro-pkg at the time but now it is . In order to do this, we'll also need to configure bro-pkg.meta to require the proper version of bro-pkg, as well as update the btests for t

Re: [DISCUSS] Metron Release 0.6.0?

2018-09-05 Thread Justin Leet
Long story short, while preparing the release candidate, I discovered our metron-bro-plugin-kafka is inconsistently versioned. In the repo, it's x.y (e.g. 0.2) See: https://github.com/apache/metron-bro-plugin-kafka/blob/master/VERSION#L18 In our released artifact, it's x.y.z (e.g. 0.1.0) See http