Re: Bro plugin release process docs?

2018-10-10 Thread zeo...@gmail.com
Yeah you're right when I looked closer to make the change it was step 10. I pushed a manual 0.2 tag to metron-bro-plugin-kafka and did a quick update to the cwiki, but it could use some additional love, especially if we want to split out the release processes generally. Jon On Wed, Oct 10, 2018

Re: Bro plugin release process docs?

2018-10-10 Thread Justin Leet
Yeah, we need to update the release process instructions. It should actually be step 10 shouldn't it? We want to keep the rc tag as-is because it may get rejected/cancelled, and update the final tag as the release. I already need to overhaul that page to reflect the addition of the RC creation

Re: Bro plugin release process docs?

2018-10-10 Thread Michael Miklavcic
+1 to all of that from me, Jon. Thanks for taking care of this. On Wed, Oct 10, 2018 at 2:34 PM zeo...@gmail.com wrote: > I wonder if we should also update the > https://cwiki.apache.org/confluence/display/METRON/Release+Process > instructions > to include tagging for the bro plugin, or if we

Re: Bro plugin release process docs?

2018-10-10 Thread zeo...@gmail.com
I wonder if we should also update the https://cwiki.apache.org/confluence/display/METRON/Release+Process instructions to include tagging for the bro plugin, or if we were going to split out the release processes? I'd be happy to update the instructions (Step 8) if that's the right place for now

Re: Bro plugin release process docs?

2018-10-10 Thread zeo...@gmail.com
So I was poking around on the plugin today and noticed that we have a apache-metron-bro-plugin-kafka_0.2.0-release and apache-metron-bro-plugin-kafka_0.2.0-rc1 tag, but no 0.2 (which is what bro-pkg would point to). Anybody have any concerns if I push the 0.2 tag as discussed above? Then we

Re: [DISCUSS] Switching to a better alternative of Pikaday.js

2018-10-10 Thread Nick Allen
> Before making a decision on what's next, I'd to ask you a question. Is it > really a priority and is it really worth the effort to touch our currently used date picker component to get ~15% reduction in the bundle size by removing moment? As an aside, I think there is a greater benefit here

[DISCUSS] Switching to a better alternative of Pikaday.js

2018-10-10 Thread Tamás Fodor
I'd like to open a discussion about switching to a new date picker library in the Metron Alerts UI regarding to the following: https://lists.apache.org/thread.html/2e4fafa4256ce14ebcd4433420974e24962884204418ade51f0e3bfb@%3Cdev.metron.apache.org%3E

Re: [DISCUSS] Add e2e step to PR checklist

2018-10-10 Thread Nick Allen
The latter. On Wed, Oct 10, 2018 at 5:48 AM Shane Ardell wrote: > Nick - To be clear, when you say you can never get them all to pass, do you > mean you can never get all the tests to pass without protractor flake > re-running the failing tests (ie. eventually all the tests pass in the > end),

Re: [DISCUSS] Add e2e step to PR checklist

2018-10-10 Thread Shane Ardell
Nick - To be clear, when you say you can never get them all to pass, do you mean you can never get all the tests to pass without protractor flake re-running the failing tests (ie. eventually all the tests pass in the end), or do you mean you still have failing tests even after protractor-flake