Re: Metron Release 0.6.1 and/or Plugin release 0.3.0?

2018-11-21 Thread zeo...@gmail.com
A metron-bro-plugin-kafka 0.3 release is good to go from my side. Thanks for all of the reviews Nick On Wed, Nov 21, 2018 at 11:16 AM Nick Allen wrote: > Ha. Yes, that definitely counts and makes a ton of sense. Thanks! > > On Wed, Nov 21, 2018 at 11:00 AM Justin Leet > wrote: > > > Does "I

Re: Metron Release 0.6.1 and/or Plugin release 0.3.0?

2018-11-21 Thread Nick Allen
Ha. Yes, that definitely counts and makes a ton of sense. Thanks! On Wed, Nov 21, 2018 at 11:00 AM Justin Leet wrote: > Does "I forgot to pull master fresh before running the command" count as a > reason? > > The missing Jiras are: > > METRON-1890 Metron Vagrant should disable audio

Re: Metron Release 0.6.1 and/or Plugin release 0.3.0?

2018-11-21 Thread zeo...@gmail.com
For metron-bro-plugin-kafka I'd like to get https://github.com/apache/metron-bro-plugin-kafka/pull/19 into this release as well, as it will be important to already exist in a release prior to future releases of bro. It's a fairly trivial test-only change. Jon On Wed, Nov 21, 2018 at 11:00 AM

Re: Metron Release 0.6.1 and/or Plugin release 0.3.0?

2018-11-21 Thread Justin Leet
Does "I forgot to pull master fresh before running the command" count as a reason? The missing Jiras are: METRON-1890 Metron Vagrant should disable audio (ottobackwards) closes apache/metron#1277 METRON-1874 Create a Parser Debugger (nickwallen) closes apache/metron#1265 METRON-1880

Re: Metron Release 0.6.1 and/or Plugin release 0.3.0?

2018-11-21 Thread Nick Allen
Also, I'd like to get this one included in the release. This is really annoying for people just wanting to try out the Profiler. And this was 'broken' after the last release, so there currently is no release with this problem and I'd like to keep it that way. :)

Re: Metron Release 0.6.1 and/or Plugin release 0.3.0?

2018-11-21 Thread Nick Allen
Any reason to not include everything in master at this point? There are 5 additional, *newer* commits beyond what you have here. On Wed, Nov 21, 2018 at 10:11 AM Justin Leet wrote: > Realized I'd never sent the updated list of Jiras. I changed the command > slightly (to remove a clause I

Re: Metron Release 0.6.1 and/or Plugin release 0.3.0?

2018-11-21 Thread Justin Leet
Realized I'd never sent the updated list of Jiras. I changed the command slightly (to remove a clause I thought we'd already removed re: http, and added the awk to remove dupes resulting from multiple commits for a single Jira. I'll do a PR for these changes). *apache/metron* git log "master"