[GitHub] metron pull request #653: METRON-1040 Create Installation Instructions for t...

2017-07-14 Thread MohanDV
Github user MohanDV commented on a diff in the pull request: https://github.com/apache/metron/pull/653#discussion_r127390120 --- Diff: metron-analytics/metron-profiler/README.md --- @@ -6,36 +6,94 @@ This is achieved by summarizing the streaming telemetry data consumed by Metron

[GitHub] metron pull request #653: METRON-1040 Create Installation Instructions for t...

2017-07-14 Thread MohanDV
Github user MohanDV commented on a diff in the pull request: https://github.com/apache/metron/pull/653#discussion_r127391226 --- Diff: metron-analytics/metron-profiler/README.md --- @@ -69,7 +142,7 @@ More information on configuring and using the client can be found [here](../metr

[GitHub] metron pull request #656: METRON-1050 Improve Docs of 'profile.period.durati...

2017-07-19 Thread MohanDV
Github user MohanDV commented on a diff in the pull request: https://github.com/apache/metron/pull/656#discussion_r128193518 --- Diff: metron-analytics/metron-profiler/README.md --- @@ -137,15 +137,20 @@ This section will describe the steps required to get your first "Hello,

[GitHub] metron issue #862: METRON-1343: Swagger UI for User Controller needs request...

2017-12-12 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/862 Thanks @ottobackwards . Updated the manual verification steps. ---

[GitHub] metron pull request #862: METRON-1343: Swagger UI for User Controller needs ...

2017-12-11 Thread MohanDV
GitHub user MohanDV opened a pull request: https://github.com/apache/metron/pull/862 METRON-1343: Swagger UI for User Controller needs request method ## Contributor Comments Swagger UI for metron rest endpoints for User Controller has multiple requestMethods listed

[GitHub] metron pull request #891: METRON-1282 creating a new topic using the rest en...

2018-01-08 Thread MohanDV
GitHub user MohanDV opened a pull request: https://github.com/apache/metron/pull/891 METRON-1282 creating a new topic using the rest end point breaks the list topic API ## Contributor Comments Creating a kafka topic using the rest endpoint doesn't add the required ACL

[GitHub] metron issue #889: METRON-1390: Swagger UI for "Web Security Config" Control...

2018-01-10 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/889 Thanks @mmiklavc , can you please merge this ---

[GitHub] metron pull request #889: METRON-1390: wagger UI for "Web Security Config" C...

2018-01-05 Thread MohanDV
GitHub user MohanDV opened a pull request: https://github.com/apache/metron/pull/889 METRON-1390: wagger UI for "Web Security Config" Controller needs request method ## Contributor Comments Swagger UI for "Web Security Config" Controller needs request

[GitHub] metron pull request #889: METRON-1390: Swagger UI for "Web Security Config" ...

2018-01-05 Thread MohanDV
Github user MohanDV closed the pull request at: https://github.com/apache/metron/pull/889 ---

[GitHub] metron pull request #889: METRON-1390: Swagger UI for "Web Security Config" ...

2018-01-05 Thread MohanDV
GitHub user MohanDV reopened a pull request: https://github.com/apache/metron/pull/889 METRON-1390: Swagger UI for "Web Security Config" Controller needs request method ## Contributor Comments Swagger UI for "Web Security Config" Controller

[GitHub] metron issue #891: METRON-1282 creating a new topic using the rest end point...

2018-01-10 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/891 Thanks @merrimanr for taking a look. Yes , I should have added the check for kerberos. Regarding moving this functionality to separate endpoint , I wanted to address the breaking of other kafka

[GitHub] metron pull request #892: METRON-1392 Fix a test case to expect an Exception...

2018-01-09 Thread MohanDV
GitHub user MohanDV opened a pull request: https://github.com/apache/metron/pull/892 METRON-1392 Fix a test case to expect an Exception when replication factor more than number of brokers while creating topic ## Contributor Comments Fix a test case to expect an Exception when

[GitHub] metron pull request #891: METRON-1282 creating a new topic using the rest en...

2018-01-19 Thread MohanDV
Github user MohanDV closed the pull request at: https://github.com/apache/metron/pull/891 ---

[GitHub] metron issue #891: METRON-1282 creating a new topic using the rest end point...

2018-01-19 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/891 Created another pull request which will address this issue ---

[GitHub] metron pull request #897: METRON-1395:Documentation missing for Produce a me...

2018-01-12 Thread MohanDV
GitHub user MohanDV opened a pull request: https://github.com/apache/metron/pull/897 METRON-1395:Documentation missing for Produce a message to a Kafka topic Rest API endpoint ## Contributor Comments Added documentation for produce a message to a Kafka topic Rest API endpoint

[GitHub] metron pull request #898: METRON-1398:Exclude the basic-error-controller fro...

2018-01-12 Thread MohanDV
GitHub user MohanDV opened a pull request: https://github.com/apache/metron/pull/898 METRON-1398:Exclude the basic-error-controller from being added to the swagger description ## Contributor Comments We need to exclude the basic-error-controller and web-security

[GitHub] metron pull request #898: METRON-1398:Exclude the basic-error-controller fro...

2018-01-12 Thread MohanDV
GitHub user MohanDV reopened a pull request: https://github.com/apache/metron/pull/898 METRON-1398:Exclude the basic-error-controller from being added to the swagger description ## Contributor Comments We need to exclude the basic-error-controller and web-security

[GitHub] metron pull request #898: METRON-1398:Exclude the basic-error-controller fro...

2018-01-12 Thread MohanDV
Github user MohanDV closed the pull request at: https://github.com/apache/metron/pull/898 ---

[GitHub] metron issue #923: METRON-1442: Split rest end points for indexing topology ...

2018-02-02 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/923 @cestella I merged your PR ---

[GitHub] metron pull request #923: METRON-1442: Split rest end points for indexing to...

2018-02-02 Thread MohanDV
GitHub user MohanDV opened a pull request: https://github.com/apache/metron/pull/923 METRON-1442: Split rest end points for indexing topology into random access indexing and batch indexing ## Contributor Comments Split rest end points for indexing topology into random

[GitHub] metron pull request #895: METRON-1394:Create Rest endpoint to add the ACL fo...

2018-01-27 Thread MohanDV
GitHub user MohanDV reopened a pull request: https://github.com/apache/metron/pull/895 METRON-1394:Create Rest endpoint to add the ACL for current user to kafka topics ## Contributor Comments Creating a kafka topic using the rest endpoint doesn't add the required ACL to topic

[GitHub] metron pull request #895: METRON-1394:Create Rest endpoint to add the ACL fo...

2018-01-27 Thread MohanDV
Github user MohanDV closed the pull request at: https://github.com/apache/metron/pull/895 ---

[GitHub] metron issue #936: METRON-1450:Added documentation for random access and bat...

2018-02-13 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/936 @JonZeolla are you referring to metron-platform/metron-indexing/README.md ? ---

[GitHub] metron pull request #936: METRON-1450:Added documentation for random access ...

2018-02-13 Thread MohanDV
GitHub user MohanDV opened a pull request: https://github.com/apache/metron/pull/936 METRON-1450:Added documentation for random access and batch indexing topology rest endpoints ## Contributor Comments Added documentation for random access and batch indexing topology

[GitHub] metron issue #895: METRON-1394:Create Rest endpoint to add the ACL for curre...

2018-02-13 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/895 I have reopened my earlier pull request (https://github.com/apache/metron/pull/891) where I am adding the required acl's while creating the topic, without a separate endpoint. ---

[GitHub] metron pull request #891: METRON-1282 creating a new topic using the rest en...

2018-02-12 Thread MohanDV
GitHub user MohanDV reopened a pull request: https://github.com/apache/metron/pull/891 METRON-1282 creating a new topic using the rest end point breaks the list topic API ## Contributor Comments Creating a kafka topic using the rest endpoint doesn't add the required ACL

[GitHub] metron issue #891: METRON-1282 add the required ACL to current user while cr...

2018-02-13 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/891 redundant ---

[GitHub] metron issue #895: METRON-1394:Create Rest endpoint to add the ACL for curre...

2018-02-13 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/895 addressed review comments to add the required ACL to current user while creating a new topic using the rest end point. ---

[GitHub] metron pull request #891: METRON-1282 add the required ACL to current user w...

2018-02-13 Thread MohanDV
Github user MohanDV closed the pull request at: https://github.com/apache/metron/pull/891 ---

[GitHub] metron issue #936: METRON-1450:Added documentation for random access and bat...

2018-02-14 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/936 updated the main README for indexing ---

[GitHub] metron issue #895: METRON-1394:Create Rest endpoint to add the ACL for curre...

2018-02-08 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/895 Bump. Can anyone offer a binding +1 ? I Would like to get this in. ---

[GitHub] metron issue #936: METRON-1450:Added documentation for random access and bat...

2018-02-16 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/936 @JonZeolla Sorry I dint notice the METRON-1454 , I have updated the description for METRON-1450. I will mark my METRON-1458 as the duplicate of METRON-1454. ---

[GitHub] metron issue #936: METRON-1450:Added documentation for random access and bat...

2018-02-16 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/936 @JonZeolla it's out of the scope of this PR, This PR is intended to update the doc for rest endpoints. I have created another PR (METRON-1458) to update the main README for indexing. ---

[GitHub] metron pull request #942: METRON-1461: Modify the MIN, MAX Stellar methods t...

2018-02-23 Thread MohanDV
GitHub user MohanDV opened a pull request: https://github.com/apache/metron/pull/942 METRON-1461: Modify the MIN, MAX Stellar methods to take a stats or list object and return min and max ## Contributor Comments Presently the MIN and MAX stellar function accepts only

[GitHub] metron issue #942: METRON-1461: Modify the MIN, MAX Stellar methods to take ...

2018-02-26 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/942 @nickwallen Thanks for the review, I have incorporated your comments. ---

[GitHub] metron issue #936: METRON-1450:Add rest endpoint documentation for splitting...

2018-02-28 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/936 @nickwallen / @JonZeolla can you please merge this request. ---

[GitHub] metron issue #942: METRON-1461: Modify the MIN, MAX Stellar methods to take ...

2018-03-06 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/942 @nickwallen I dint consider implementation where STATS object can be passed in list of mixed object . That requires to change the STATS object to be 'Comparable' type . Do you think it should

[GitHub] metron issue #936: METRON-1450:Added documentation for random access and bat...

2018-02-27 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/936 Bump. Can anyone offer a binding +1 ? I Would like to get this in. ---

[GitHub] metron issue #936: METRON-1450:Add rest endpoint documentation for splitting...

2018-03-06 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/936 @nickwallen / @JonZeolla can you please merge this request. ---