PR Review Request

2019-09-23 Thread Tibor Meller
Hi all, Could some of our committers take a look at this? Tamas (ruffle1996) already left a non-binding +1. https://github.com/apache/metron/pull/1514 I found a few issue in the master what I would like to fix in the top of this. (Tickets created and mentioned in the PR desc). Thanks in

Re: [DISCUSS] Alerts UI: Loading state while fetching data

2019-07-25 Thread Tibor Meller
his also include indicating when an error has occurred in the > > backend call? That might also be helpful and somewhat related to > > METRON-2190. > > > > On Wed, Jul 24, 2019 at 9:27 AM Tibor Meller > > wrote: > > > > > Hi all, > > > > > >

[DISCUSS] Alerts UI: Loading state while fetching data

2019-07-24 Thread Tibor Meller
Hi all, I think it would great to have a loading state on the Alerts UI which shows loading is in progress (spinner) and prevent the user to trigger new fetch requests before the response arrives (or timeout). I added more detail here: https://issues.apache.org/jira/browse/METRON-2190 Please

Re: [DISCUSS] Parser Aggregation in Management UI

2019-07-01 Thread Tibor Meller
> won't > > get committed or changed? I don't see any way to avoid having to > propagate > > changes through all subsequent PRs. > > > > On Wed, May 29, 2019 at 7:03 AM Tibor Meller > > wrote: > > > > > Hi all, > > > > > > *We

Re: [DISCUSS] Bug maybe: Alert UI can't use two status filter

2019-06-17 Thread Tibor Meller
Hi all, I just opened a PR for fixing filtering in Alerts UI. I found a few other use cases which haven't worked as expected. https://github.com/apache/metron/pull/1443 Regards, Tibor On Mon, Jun 3, 2019 at 5:13 PM Tibor Meller wrote: > Thanks for the answers! > Ticket created:

Re: [DISCUSS] Bug maybe: Alert UI can't use two status filter

2019-06-03 Thread Tibor Meller
at 1:22 PM Otto Fowler > wrote: > > > Bug > > > > > > On May 31, 2019 at 08:53:21, Tibor Meller (tibor.mel...@gmail.com) > wrote: > > > > Hi all, > > > > tl;dr: Is it a bug if "* -alert_status:RESOLVE OR -alert_status:DISMISS" >

Re: [DISCUSS] Click through navigation feature

2019-05-31 Thread Tibor Meller
. On Fri, May 31, 2019 at 7:28 PM Michael Miklavcic < michael.miklav...@gmail.com> wrote: > Thank you Tibor - I've made some comments on your PR here - > https://github.com/apache/metron/pull/1431#issuecomment-497794088 > > On Fri, May 31, 2019 at 8:56 AM Tibor Meller >

[DISCUSS] Click through navigation feature

2019-05-31 Thread Tibor Meller
Hi all, I build a feature for Alert UI, what we found very useful and I think it would be a great candidate for a PR. Short Description: Click Through Navigation is a feature makes Metron Users able to reach other web services via dynamically created URLs by clicking link item in a context menu.

[DISCUSS] Bug maybe: Alert UI can't use two status filter

2019-05-31 Thread Tibor Meller
Hi all, tl;dr: Is it a bug if "* -alert_status:RESOLVE OR -alert_status:DISMISS" not works on Alert UI? I'm experimenting with filtering from the alert UI. What I found is I can run the following query directly against the REST API without any problem: "* -alert_status:RESOLVE OR

Re: [DISCUSS] Parser Aggregation in Management UI

2019-05-29 Thread Tibor Meller
this changeset, full dev is broken. https://lists.apache.org/thread.html/beeb4cfddfca7958a22ab926f72f52f46a33c42edce714112df9a2da@%3Cdev.metron.apache.org%3E On Fri, May 24, 2019 at 3:20 PM Tibor Meller wrote: > Please find below the list of the PRs we opened for Parser Aggregation. > With

Re: [DISCUSS] Parser Aggregation in Management UI

2019-05-24 Thread Tibor Meller
https://github.com/apache/metron/pull/1430> Thanks, Tibor On Thu, May 23, 2019 at 11:45 AM Tibor Meller wrote: > Yes, am expecting that some change request will rase due to the review. > We planning to add the changes to the latest PR as additional commits to > avoid impacting the

Re: [DISCUSS] Parser Aggregation in Management UI

2019-05-23 Thread Tibor Meller
e up through the remaining k PRs > in order, or just the final PR? I'm wondering how this works in reference > to your last point in #5 about rebasing. > > On Wed, May 22, 2019 at 8:47 AM Tibor Meller > wrote: > > > I would like to describe quickly *our approach to breaking down P

Re: [DISCUSS] Parser Aggregation in Management UI

2019-05-22 Thread Tibor Meller
> > > We need to maintain a record of attribution. Your real workflow may > not > > > be > > > > that cleanly delineated, but you can choose how you want to squash in > > > those > > > > cases. Even in public collaboration, there are plenty of cases whe

Re: [DISCUSS] Parser Aggregation in Management UI

2019-05-07 Thread Tibor Meller
> > > On Mon, May 6, 2019 at 5:24 AM Tibor Meller > wrote: > > > I wondered on the weekend how we could split that PR to smaller chunks. > > That PR is a result of almost 2 months of development and I don't see how > > to split that to multiple WORKING parts. It

Re: [DISCUSS] Parser Aggregation in Management UI

2019-05-06 Thread Tibor Meller
@Otto: I responded to your questions in a few Jira comment. On Mon, May 6, 2019 at 11:21 AM Tibor Meller wrote: > I wondered on the weekend how we could split that PR to smaller chunks. > That PR is a result of almost 2 months of development and I don't see how > to split that to

Re: [DISCUSS] Parser Aggregation in Management UI

2019-05-06 Thread Tibor Meller
I wondered on the weekend how we could split that PR to smaller chunks. That PR is a result of almost 2 months of development and I don't see how to split that to multiple WORKING parts. It is as it is a whole working feature. If we split it by packages or files we could provide smaller

Re: [DISCUSS] Metron Release - 0.7.1 next steps

2019-05-02 Thread Tibor Meller
A separate [DISCUSSION] thread on Parser Aggregation support for the Management UI is coming later today. We collecting all the previous threads there which belongs to this feature and it's implementation. On Thu, May 2, 2019 at 6:32 PM Tibor Meller wrote: > I also favor option 2. I also f

Re: [DISCUSS] Metron Release - 0.7.1 next steps

2019-05-02 Thread Tibor Meller
I also favor option 2. I also feel it is good to highlight we are not facing with an issue on the UI with a fix in PR#1360. Parser aggregation had turned on for the three default parser without having parser aggregation support added to the UI. PR#1360 contains a whole new feature with about 6000

Re: [DISCUSS] Add ngrx to handle state management in Angular

2018-11-28 Thread Tibor Meller
NgRx also makes testing easier and the architecture more straightforward. Components in a Redux/NgRx architecture only responsible for rendering and dispatching events. All the data alternation implemented in pure functions so-called effects and reducers. No intertwined components, side effects

Re: [DISCUSS] Add ngrx to handle state management in Angular

2018-11-26 Thread Tibor Meller
Shane, Thanks for gathering the information and raising this. I also feel that our UIs reached a level of complexity what makes this to a reasonable next step. This complexity on the client side will grow in the future and I believe it is better to prepare instead of trying to make huge

Re: [DISCUSS] Migrate from Protractor to Cypress

2018-10-30 Thread Tibor Meller
this discussion. Please let me know what do you think about a migration to Cypress as a next step! Thanks, Tibor On Thu, Sep 27, 2018 at 9:23 AM Tibor Meller wrote: > Great Guys! Thanks for the feedback. I'll move forward as discussed. > > Thx > > On Wed, Sep 26, 2018 at 11:44 PM Mi

Re: Invite to Slack Channel

2018-10-17 Thread Tibor Meller
Hi Guys, Can you add me to the apache metron slack chanel? Thanks, On Thu, Oct 4, 2018 at 1:14 PM Otto Fowler wrote: > Done > > > On October 4, 2018 at 05:35:06, Tamás Fodor (ftamas.m...@gmail.com) wrote: > > Hello, > > Michael, can you add me as well? > > Thank you in advance! > > Tamas > >

Re: [DISCUSS] Switching to a better alternative of Pikaday.js

2018-10-16 Thread Tibor Meller
t; > Bootstrap? Per your arguments for it, this sounds like the right path > > forward to me. I'm +1 on this approach provided someone doesn't come back > > with a "well, there's only this problem..." > > > > Best, > > Mike > > > >

Re: [DISCUSS] Switching to a better alternative of Pikaday.js

2018-10-15 Thread Tibor Meller
@Shane It seems like we're agreed on this. :D On Mon, Oct 15, 2018 at 1:18 PM Tibor Meller wrote: > Hi Guys, > > I think we could consider moving to ng bootstrap. It solves most of our > problems and makes our code base cleaner easier to maintain. > > Here are some benefits I

Re: [DISCUSS] Switching to a better alternative of Pikaday.js

2018-10-15 Thread Tibor Meller
better to get rid of it at this early stage. > > Go here <https://github.com/apache/metron/pull/1219> to read more about > > the > > background and the results. I tried to provide as many details as I > could. > > > > So far, so good. But then I stumbled upon an obs

Re: [DISCUSS] Migrate from Protractor to Cypress

2018-09-27 Thread Tibor Meller
s > > implementing or running the tests, we will have invested a fraction of > time > > vs. migrating all the tests right away. > > > > On Wed, Sep 26, 2018 at 2:12 PM Tibor Meller > > wrote: > > > > > Hi Team, > > > > > > Many of us agreed

Re: [DISCUSS] Migrate from Protractor to Cypress

2018-09-26 Thread Tibor Meller
Hi Team, Many of us agreed on that Cypress could be a more capable tool for us to write high-level UI tests, whether those be e2e, integration or automated regression tests. If there is no open question left about cypress we could to bring it a test drive. My suggestion is to implement the PCAP

[DISCUSS] PCAP data for testing and development

2018-09-19 Thread Tibor Meller
Hi all, I would like to start a discussion on the possible ways to provide PCAP data for the full dev. The full dev VM after a rebuild contains no PCAP data. Currently, I'm uploading binaries manually. This makes development slower and testing problematic as well. I think a more desired outcome

Metron-alerts UI Unit Tests

2018-07-03 Thread Tibor Meller
Hi, I'm writing to inform the team about the current state of unit tests in the angular client and start a discussion about it in general. Probably some of you know the in the previous weeks we fixed the existing errors in all the *spec.ts files in /metron-interface/metron-alerts which makes as

Metron-alerts E2E testing

2018-07-03 Thread Tibor Meller
Hi All, Probably some of you already know that Shane and I working on stabilizing and extending e2e tests in metron-interface/metron-alerts. Currently, the tests using Protractor which is the default e2e testing framework of Angular. The tests injecting data right into ElasticSearch and making