Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/946
@ottobackwards - I have some open changes in a PR against this PR. Just to
confirm, the expected result of this PR should be that users can choose
1. Which client they want to instantiate
2
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/963
+1 via inspection
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/946
@wardbekker Did you test this with Kibana by chance? I'm seeing
authentication exceptions in the Kibana UI. Looks like we need additional steps
for it to work -
https://www.elastic.co/guide/en
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/943
Also, I will look at moving the Kibana templates to Metron as this is
something that will need to be done for Solr as well.
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/943
@ottobackwards I believe the repercussions are the same as they are for the
existing MPack since the services are distinct from the MPack itself. We should
probably consider a separate test for this.
---
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/946#discussion_r172544606
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/metron_service.py
---
@@ -70,6
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/933
Oh, I guess we need to reaffirm. Yes, +1 still stands.
---
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/946#discussion_r172351786
--- Diff: pom.xml ---
@@ -97,7 +97,7 @@
${base_hadoop_version}
${base_hbase_version}
${base_flume_version
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/946
I knew what you meant :)
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/946
We could probably leverage this guy here
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/946
@simonellistonball It looks like they are not explicitly bundling the
X-Pack client. Rather, they're expecting the user to provide the jar file
manually on the classpath and then dynamically
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/946#discussion_r171620565
--- Diff: metron-platform/elasticsearch-shaded/pom.xml ---
@@ -31,7 +43,7 @@
org.elasticsearch.client
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/946#discussion_r171596212
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/utils/ElasticsearchUtils.java
---
@@ -111,19 +111,24
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/853
@merrimanr this looks much better. I'm +1 via inspection pending any
further feedback from @ottobackwards.
---
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/853#discussion_r171015228
--- Diff:
metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/search/SearchRequest.java
---
@@ -101,16 +99,16 @@ public void
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/938
+1 from me as well, thanks @anandsubbu!
---
GitHub user mmiklavc opened a pull request:
https://github.com/apache/metron/pull/943
METRON-1462: Separate ES and Kibana from Metron Mpack
## Contributor Comments
This splits ES and Kibana into their own MPacks. Two comments for reviewers:
- The original discuss thread
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/933
Thanks for the info guys. @nickwallen With the reduced swap space, did you
notice any issues with performance or services dying? I'm +1 by inspection if
you believe we're good.
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/933
This looks good, but before I +1 this, what are we doing in the current
special metron cut of centos 6? I'm not familiar enough with why we forked to
understand what we're possibly giving up
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/853#discussion_r168809125
--- Diff:
metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/search/SearchRequest.java
---
@@ -101,16 +99,16 @@ public void
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/853#discussion_r168810966
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/config/HBaseConfig.java
---
@@ -0,0 +1,61 @@
+/**
+ * Licensed
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/853#discussion_r168802913
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/rest_commands.py
---
@@ -179,6
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/439
Bump? Sorry @ottobackwards, your streak ends at 4.
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/916
Thanks for the contribution! I'm just starting to look at this so expect
some comments rolling in as I have time.
---
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/916#discussion_r166804712
--- Diff: metron-deployment/README.md ---
@@ -112,6 +115,130 @@ To build the DEB packages, follow the instructions at
[packaging/docker/deb-dock
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/914
This seems cool. Can you provide some guidance via some examples or just a
link to what's possible syntax/query-wise with JSON path queries in the docs
for this?
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/812
Yeesh, getting Jekyll to work was a pain. I re-installed Ruby from Homebrew
and then had to install a number of packages to get it to compile. I've updated
the wiki with notes on this as well
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/812
Sigh, will push to the asf-site branch asap. My Jekyll config is broken.
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/812
I'm going to attempt to do this now -
https://cwiki.apache.org/confluence/display/METRON/Website+PR+Merge. Link
copied here so I can hopefully Google search for "how to update the apache
m
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/853
Bump @merrimanr
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/830
Bump. @iraghumitra
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/863
My +1 still stands on this and this PR has been up for quite some time. I
will merge by EOD unless there are any additional concerns.
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/927
+1. This looks great @nickwallen. Thanks for fixing this! Everything spun
up with the appropriate mem settings. Modifying the template and heap reflect
in the jvm.options and process display.
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/927
Spinning this up now, merged with https://github.com/apache/metron/pull/928
to make sure all is well with Ambari 2.6.1. I expect the changes in this PR
will not be affected.
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/928
@ottobackwards, @nickwallen is correct. This was originally intended to
deal with the Ubuntu repo problem, which ended up being fixed via the Ambari
upgrade (due to fixes they made to how
GitHub user mmiklavc opened a pull request:
https://github.com/apache/metron/pull/928
METRON-1444: Add Ubuntu Repositories for Elasticsearch to the Mpack
## Contributor Comments
https://issues.apache.org/jira/browse/METRON-1444
As of Ambari 2.6.0, the Ubuntu
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/926
2.0.2
---
GitHub user mmiklavc opened a pull request:
https://github.com/apache/metron/pull/926
METRON-1446: Fix openjdk issue with Ubuntu
## Contributor Comments
https://issues.apache.org/jira/browse/METRON-1446
Spin up full dev for Ubuntu. It should run successfully all the way
Github user mmiklavc closed the pull request at:
https://github.com/apache/metron/pull/918
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/915
Perhaps we can leverage parts of the performance logging code for this
purpose? The frequency/sampling bit was something I had wanted to add for
some time now.
https://github.com
GitHub user mmiklavc opened a pull request:
https://github.com/apache/metron/pull/918
METRON-1436: Manually Install Solr Cloud in Full Dev
https://issues.apache.org/jira/browse/METRON-1436
Provide script for starting Solr Cloud in quickstart mode for testing
purposes
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/907
+1
I ran it up on 2 separate Macs, one running Ansible 2.2.2.0 and the other
2.0.0.2. Both spun up without issue today.
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/915
+1, lgtm via inspection.
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/915
https://github.com/apache/metron/blob/master/metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/bolt/EnrichmentJoinBolt.java#L89
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/913
+1 by inspection
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/907
I'm testing now as well for good measure since this is our main dev testing
environment. We should probably take a little extra care with the breadth of
changes in this and https://github.com
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/901
Thanks for fixing this @ottobackwards. +1 via inspection from me as well.
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/890
+1, lgtm via inspection. Thanks for the contribution!
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/910
Ah, ok I didn't pick that up from the context, but that makes sense. +1
stands.
---
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/910#discussion_r163962696
--- Diff:
metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/IndexDao.java
---
@@ -140,9 +147,9 @@ default Document
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/910
@ottobackwards I was envisioning a metron-deps project of some sort.
Jackson and Guava are perennial offenders in the Hadoop stack, and a facade of
some sort would be useful to insulate us from
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/909
@cestella You're right about that - the general goodness. We (I) had made
the mistake of doing some test refactoring in the ES upgrade branch that would
have been better done in a separate PR
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/909
+1 pending travis
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/909
@cestella This is going into master per the merge notes, right?
---
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/909#discussion_r163737895
--- Diff:
metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/dao/SearchIntegrationTest.java
---
@@ -724,6 +503,52 @@ public void
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/909#discussion_r163737939
--- Diff:
metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/dao/SearchIntegrationTest.java
---
@@ -724,6 +503,52 @@ public void
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/907
@Ali - I think the reason for Storm 1.1 is that it's the version that comes
with HDP 2.6.
https://docs.hortonworks.com/HDPDocuments/HDP2/HDP-2.6.4/bk_release-notes/content/comp_versions.html
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/905
Thanks @nickwallen, I plan to spend some time reviewing 903 as well.
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/908
Realized the change I made is specifically for a test dependency and does
not appear to affect final package dependencies from what I can see in the tgz
- `tar tvf metron-config-0.4.3
GitHub user mmiklavc opened a pull request:
https://github.com/apache/metron/pull/908
1428: Travis build failing from metron-config
## Contributor Comments
https://issues.apache.org/jira/browse/METRON-1428
Travis is failing because of npm downstream package
GitHub user mmiklavc opened a pull request:
https://github.com/apache/metron/pull/906
1426: SensorIndexingConfigControllerIntegrationTest fails intermittently
## Contributor Comments
https://issues.apache.org/jira/browse/METRON-1426
Sensor indexing config has
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/905
Just a heads up my first manual test failed with full dev because of this
guy:
https://github.com/apache/metron/blob/master/metron-deployment/roles/monit-start/tasks/main.yml#L36
GitHub user mmiklavc opened a pull request:
https://github.com/apache/metron/pull/905
METRON-1417: Disable pcap-service by default in Monit
## Contributor Comments
https://issues.apache.org/jira/browse/METRON-1417
Free up some full dev mem. We don't run the pcap
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/904
Travis failure appears unrelated
---
GitHub user mmiklavc opened a pull request:
https://github.com/apache/metron/pull/904
METRON-1400: Elasticsearch service check fails in Ambari
## Contributor Comments
Addresses https://issues.apache.org/jira/browse/METRON-1400
This file hasn't been touched since
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/853
I don't see anything that should be problematic in ES 5.6.2, but can you
confirm @merrimanr?
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/899
Pulling this PR until I can resolve and underlying issue with the counting
semantics, however I believe this may by theoretically impossible without a
2-pass model.
---
Github user mmiklavc closed the pull request at:
https://github.com/apache/metron/pull/899
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/899
Yes - good catch - this not actually going to work without some
modification. The count zeroes out when a majority is held by non-m values and
gets reset to a new non-plurality, non-majority object.
---
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/899#discussion_r162127870
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/MathFunctions.java
---
@@ -220,4 +219,156 @@ public Object
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/899
I'll look into the test as it's passing locally for me in my IDE.
---
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/899#discussion_r161913450
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/MathFunctions.java
---
@@ -220,4 +219,156 @@ public Object
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/899#discussion_r161912600
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/MathFunctions.java
---
@@ -220,4 +219,156 @@ public Object
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/899#discussion_r161911833
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/MathFunctions.java
---
@@ -220,4 +219,156 @@ public Object
GitHub user mmiklavc opened a pull request:
https://github.com/apache/metron/pull/899
METRON-1405: Add Boyer-Moore majority vote algorithm to Stellar
## Contributor Comments
Addresses https://issues.apache.org/jira/browse/METRON-1405
A proper majority requires 2
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/894
fwiw, this service check also fails in full dev. Git history shows me as
creating the file because I moved the entire directory (5.6.2 name change) as
part of the ES upgrade, but this code hasn't
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/894
Oh, I see what that is. This appears to be a neglected piece of code. ES
has this but Kibana does not, for instance. The metainfo.xml allows you to add
"commandScript" items that
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/894
@anandsubbu did this ever work with CentOS 7 from Apache master? I didn't
touch that service_check.py file, and furthermore I see there are hardcoded
ports for ES.
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/863
Are all questions on required fields resolved per @cestella's
comments/clarification?
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/896
+1 by inspection
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/872
Nice addition! +1 from me as well, via inspection.
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/894
### Testing
1. Spin up full dev
2. Check that ES and Kibana are up as normal
3. Try the following operations - all should succeed without error in Ambari
- Restart Kibana
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/894
Eureka, I think we got it. Thanks @cestella for the tag team session on
digging through the Ambari source.
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/894
Upon investigation, this looks ok. But there is a permissions issue with
the service script. We have some environments that don't have this issue so I'm
looking for an appropriate place to correct
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/894
full dev still runs Ambari 2.4.2.0, so this approach may not work across
2.4 -> 2.5. ES and Kibana services are running, but they show as stopped in the
Ambari UI.
))`? Is the timing for STARTS_WITH exclusive
of TO_UPPER and DECODE or inclusive?
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/831
One additional note, I think we may be reaching the limits of what can
reasonably fit on 1 box memory-wise. After about 40 minutes, the REST api and
Elasticsearch went down. I recall this sort
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/831
Unless there are other things I should test, I think it looks pretty good.
Data is coming through to ES + Kibana (with the new ES 5.6.2 code, no less!),
the topologies appear as expected
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/863#discussion_r160250862
--- Diff: metron-platform/metron-indexing/README.md ---
@@ -15,6 +15,12 @@ Indices are written in batch and the batch size and
batch timeout are specified
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/789
Bump
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/831
The code itself looks good to me. I'm running this up in full dev now and
will report back. Fingers crossed that the extra slot is not a problem with the
extra mem required for ES 5.
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/690
This looks reasonable to me @ottobackwards. I'm +1 pending any further work
per @JonZeolla's comments. Thanks for the contribution!
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/840
Worked with @merrimanr to fix the e2e test issue and just submitted a fix.
This does not fix the full e2e test runs as this is being handled by 857,
however it brings this PR back to parity
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/878
Nice work, +1
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/831
I'm looking at this deeper and thinking through how status_params.py works
with the config files. I'm looking for a dynamic way to manage the endpoints,
in the future (not for this PR
1 - 100 of 311 matches
Mail list logo
