Re: [DISCUSS] Pcap query branch completion

2018-08-20 Thread Ryan Merriman
The feature branch has been merged into master. On Thu, Aug 16, 2018 at 5:53 PM, Michael Miklavcic < michael.miklav...@gmail.com> wrote: > I'm +1, thanks for adding that fix, Ryan. (Note, for purposes of vote, I > was a contributor in the feature branch). > > Mike > > On Thu, Aug 16, 2018, 4:17 P

Re: [DISCUSS] Pcap query branch completion

2018-08-16 Thread Michael Miklavcic
I'm +1, thanks for adding that fix, Ryan. (Note, for purposes of vote, I was a contributor in the feature branch). Mike On Thu, Aug 16, 2018, 4:17 PM Ryan Merriman wrote: > We discovered a bug in our testing and felt it should be fixed before we > merge. There is a PR up for review that alread

Re: [DISCUSS] Pcap query branch completion

2018-08-16 Thread Ryan Merriman
We discovered a bug in our testing and felt it should be fixed before we merge. There is a PR up for review that already has a +1: https://github.com/apache/metron/pull/1168. I don't anticipate this changing anyone's vote but wanted to be clear about the state of the branch. If anyone is concern

Re: [DISCUSS] Pcap query branch completion

2018-08-16 Thread James Sirota
+1 on the merge as well 16.08.2018, 05:46, "Casey Stella" : > I'm +1 on the merge. This is great work and congrats to those who > contributed to it! > > On Thu, Aug 16, 2018 at 8:27 AM Otto Fowler wrote: > >>  Looks good, thanks! >> >>  On August 15, 2018 at 19:38:12, Ryan Merriman (merrim...@gma

Re: [DISCUSS] Pcap query branch completion

2018-08-16 Thread Casey Stella
I'm +1 on the merge. This is great work and congrats to those who contributed to it! On Thu, Aug 16, 2018 at 8:27 AM Otto Fowler wrote: > Looks good, thanks! > > > On August 15, 2018 at 19:38:12, Ryan Merriman (merrim...@gmail.com) wrote: > > Otto, I believe the items you requested are in the fe

Re: [DISCUSS] Pcap query branch completion

2018-08-16 Thread Otto Fowler
Looks good, thanks! On August 15, 2018 at 19:38:12, Ryan Merriman (merrim...@gmail.com) wrote: Otto, I believe the items you requested are in the feature branch now. Is there anything outstanding that we missed? The Jiras for the Pcap feature branch should be up to date: https://issues.apache.or

Re: [DISCUSS] Pcap query branch completion

2018-08-15 Thread Ryan Merriman
Otto, I believe the items you requested are in the feature branch now. Is there anything outstanding that we missed? The Jiras for the Pcap feature branch should be up to date: https://issues.apache.org/jira/browse/METRON-1554 On Mon, Aug 13, 2018 at 5:13 PM, Ryan Merriman wrote: > - Date rang

Re: [DISCUSS] Pcap query branch completion

2018-08-13 Thread Ryan Merriman
- Date range limits on queries I will add a warning in the Job cleanup PR. That seems like an appropriate place for it (ie. make sure you don't cause health issues in your cluster). - UI should manage a queue/history of jobs I can add some documentation around killing jobs manually with the YAR

Re: [DISCUSS] Pcap query branch completion

2018-08-13 Thread Otto Fowler
- Date range limits on queries I took the point the wrong way apparently, sorry, I withdraw. I thought you meant allow specifying a limit on the query, not the system imposing a limit. This should be documented with a warning or something - UI should manage a queue/history of jobs I was thinkin

Re: [DISCUSS] Pcap query branch completion

2018-08-13 Thread Ryan Merriman
Thanks for the feedback Otto. I have created a sub task for documenting the Job cleanup documentation: https://issues.apache.org/jira/browse/METRON-1737. I completely agree with you there, this needs to be documented. For the others you marked "Follow on" I will create follow on tasks in Jira.

Re: [DISCUSS] Pcap query branch completion

2018-08-13 Thread Otto Fowler
- Job cleanup/TTL Documented at least, or a helper script to help yourself if you are in a situation - Expose the Query filter (vs Fixed) in the UI Follow on - Date range limits on queries I don’t see how this won’t be immediately required. I would do this for minimum viable. - Pcap query

[DISCUSS] Pcap query branch completion

2018-08-12 Thread Ryan Merriman
We are nearing a fully functional Pcap query feature branch. I want to take a moment before we merge to review the original discussion threads and make sure the community is happy with the state of this feature branch before we accept it into master. The original discuss threads are located at: -