Bravo.
On 1/2/18, 8:43 AM, "Justin Leet" wrote:
The PR is merged into master, and all relevant PRs have a comment noting
that adding the header is required.
As a reminder, this means Apache headers are required on all markdown files
and this will be enforced by rat.
The PR is merged into master, and all relevant PRs have a comment noting
that adding the header is required.
As a reminder, this means Apache headers are required on all markdown files
and this will be enforced by rat.
On Sat, Dec 30, 2017 at 8:33 AM, Justin Leet wrote:
> I've updated the PR to
I've updated the PR to add the header to a new MD file that went in.
I've also commented on all PRs that I saw that would potentially be
problematic were they to go into master if they weren't merged first.
Once the updated PR gets the +1's reaffirmed, it will be merged into master
and Markdown h
I'm gonna let this percolate until Wednesday or so, assuming conversation
doesn't reach a natural tipping point. I'm inclined to agree with Nick,
but I also don't want to resolve anything in a way that even potentially
causes master problems until at least after Christmas has a chance to
settle do
> This would result in master breaking (although it's a pretty easy fix).
I am not concerned and don't think we need to wait on merging PR #883.
Can you add a comment to each of the PRs that you identified? We can make
sure that each gets merged with master before they go in.
On Sat, Dec 23,
I have a PR currently out (https://github.com/apache/metron/pull/883) that
removes the rat exclusion on Markdown files. There was a discuss thread
awhile back about adding the header and removing the exclusion where it was
agreed that we should do this to meet Apache requirements. Unfortunately,
i
