Re: [GitHub] incubator-metron issue #562: METRON-915 add node and npm to platform_info.sh

2017-05-03 Thread Otto Fowler
I’m sorry Ryan, I was looking at : https://issues.apache.org/jira/browse/METRON-914 ( which you may need to take a peek at ), and thought that it was missing from the script. I was not aware of the plugin. On May 3, 2017 at 08:32:31, Ryan Merriman (merrim...@gmail.com) wrote: We are using a mv

Re: [GitHub] incubator-metron issue #562: METRON-915 add node and npm to platform_info.sh

2017-05-03 Thread Nick Allen
I think it still makes sense to add these to the platform script. What if the mvn plugin breaks or starts working in an unexpected way? This would help us uncover issues there. But good point to bring up, Ryan. On Wed, May 3, 2017 at 8:32 AM, Ryan Merriman wrote: > We are using a mvn plugin t

Re: [GitHub] incubator-metron issue #562: METRON-915 add node and npm to platform_info.sh

2017-05-03 Thread Ryan Merriman
We are using a mvn plugin that automatically installs the correct version of node and npm locally, at least for the management UI. Are there other parts of the project that depend on these tools? Is it desirable to include this even if they aren't a prerequisite for building? I don't think

[GitHub] incubator-metron issue #562: METRON-915 add node and npm to platform_info.sh

2017-05-03 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/562 +1 Thanks, Otto! Tested on OSX and CentOS. Worked as expected. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p