Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/586
I spotted a duplicate in taking a scan of the template, so I ran `grep '":
{'
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/586
+1. I'm good with the most recent changes, pending Travis.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/586
Should be good to go now, pending Travis.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/586
Last try before I merge in #624 and make it a dependancy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/586
@nickwallen @justinleet Can I get a quick review of my recent changes
before I merge? Mostly focused on how I approached documenting the template,
but feel free to comment on anything.
I
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/586
@nickwallen So, I'm not entirely done with the documentation but I pushed
it out for a quick, general review. In doing this, I noticed that some new
default-on fields were added with the release
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/586
@JonZeolla Can you deconflict this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/586
Per @simonellistonball 's comments in #531 I added initial support for the
native way that Bro handles tracking DHCP's Client ID field and updated the
above instructions appropriately.
---
If
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/586
I updated the instructions to reflect the repo name change; hopefully it
should work but I won't have a chance to test it out for a couple of days.
---
If your project is set up for it, you can
Github user simonellistonball commented on the issue:
https://github.com/apache/metron/pull/586
Fantastic! Good to see more integration tests in there and great to see
additional data ingested. I'm +1 (non-binding) on this.
---
If your project is set up for it, you can reply to
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/586
@simonellistonball Right, I'm not attempting to cover any type of log that
can come in, based on the bro documentation, because bro logs are heavily
extensible and therefore it is hard to detect
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/586
Actually, I meant the integration tests. The stuff under
`metron-platform/metron-integration-test/src/main/sample/data/bro`.
---
If your project is set up for it, you can reply to this email
Github user simonellistonball commented on the issue:
https://github.com/apache/metron/pull/586
Looks like there are some good unit tests, though maybe not for every new
type you mention, or that could come in. Seems like decent coverage though. I
wonder, is it worth adding something
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/586
Didn't I do that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
14 matches
Mail list logo
