[GitHub] metron issue #586: METRON-508 Expand Elasticsearch templates to support the ...
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/586
I spotted a duplicate in taking a scan of the template, so I ran `grep '":
{'
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/files/bro_index.template
| sort | uniq -c | grep -v 1` to make sure that was the only one. I fixed it
and pushed things up, along with other minor tweaks - Travis was successful so
I plan to merge soon. I also put some thoughts for a follow-on PR in
[METRON-1010](https://issues.apache.org/jira/browse/METRON-1010).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metron issue #586: METRON-508 Expand Elasticsearch templates to support the ...
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/586 +1. I'm good with the most recent changes, pending Travis. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #586: METRON-508 Expand Elasticsearch templates to support the ...
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/586 Should be good to go now, pending Travis. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #586: METRON-508 Expand Elasticsearch templates to support the ...
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/586 Last try before I merge in #624 and make it a dependancy. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #586: METRON-508 Expand Elasticsearch templates to support the ...
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/586 @nickwallen @justinleet Can I get a quick review of my recent changes before I merge? Mostly focused on how I approached documenting the template, but feel free to comment on anything. I just spun this up in full-dev and verified that my above steps are still valid and this works as intended. At this point I'm iteratively crossing my fingers and retrying Travis until it gets the whole way through and gives me a result. Can't wait for #624 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #586: METRON-508 Expand Elasticsearch templates to support the ...
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/586 @nickwallen So, I'm not entirely done with the documentation but I pushed it out for a quick, general review. In doing this, I noticed that some new default-on fields were added with the release of 2.5/2.5.1 (for example, `server_appdata` in [SSL](https://www.bro.org/sphinx/scripts/base/protocols/ssl/main.bro.html#type-SSL::Info) was added with 2.5). For now, I'm going to ignore those. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #586: METRON-508 Expand Elasticsearch templates to support the ...
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/586 @JonZeolla Can you deconflict this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #586: METRON-508 Expand Elasticsearch templates to support the ...
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/586 Per @simonellistonball 's comments in #531 I added initial support for the native way that Bro handles tracking DHCP's Client ID field and updated the above instructions appropriately. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #586: METRON-508 Expand Elasticsearch templates to support the ...
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/586 I updated the instructions to reflect the repo name change; hopefully it should work but I won't have a chance to test it out for a couple of days. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #586: METRON-508 Expand Elasticsearch templates to support the ...
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/586 Fantastic! Good to see more integration tests in there and great to see additional data ingested. I'm +1 (non-binding) on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #586: METRON-508 Expand Elasticsearch templates to support the ...
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/586 @simonellistonball Right, I'm not attempting to cover any type of log that can come in, based on the bro documentation, because bro logs are heavily extensible and therefore it is hard to detect what all *could* come in from a given bro install. There are also a lot of fields that exist in the bro documentation for a specific log type that are not on by default, but can be turned on. I plan to step towards support of those fields with various PRs, but not do it all with this first stab unless it's strongly encouraged. That said, I will do some more work on the unit and integration tests to get better coverage, as there most definitely may be some missing, optional fields which I didn't catch in the tests. @nickwallen Right, that makes sense. In a minute I'll push out my first pass at the integration tests, and I'll take another look at the tests this coming week and fill in any of the gaps. As an aside, I explicitly did not add these new logs to the bro sensor-stub, but I would consider doing so at some point in the future. Since there isn't a default dashboard that uses these logs, I didn't think it would be very useful. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #586: METRON-508 Expand Elasticsearch templates to support the ...
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/586 Actually, I meant the integration tests. The stuff under `metron-platform/metron-integration-test/src/main/sample/data/bro`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #586: METRON-508 Expand Elasticsearch templates to support the ...
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/586 Looks like there are some good unit tests, though maybe not for every new type you mention, or that could come in. Seems like decent coverage though. I wonder, is it worth adding something in the integration tests as well, especially prior to 777 to avoid accidentally regressing this work when that lands? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #586: METRON-508 Expand Elasticsearch templates to support the ...
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/586 Didn't I do that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
