[GitHub] metron issue #680: METRON-1078: Metron Indexing fails to stop during "Stop A...

2017-08-14 Thread justinleet
Github user justinleet commented on the issue:

https://github.com/apache/metron/pull/680
  
I'm still +1.  Thanks for the contribution!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] metron issue #680: METRON-1078: Metron Indexing fails to stop during "Stop A...

2017-08-14 Thread dlyle65535
Github user dlyle65535 commented on the issue:

https://github.com/apache/metron/pull/680
  
@justinleet (or anyone really), I'd like to push this today, still good?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] metron issue #680: METRON-1078: Metron Indexing fails to stop during "Stop A...

2017-08-07 Thread dlyle65535
Github user dlyle65535 commented on the issue:

https://github.com/apache/metron/pull/680
  
@justinleet - this seems better. The change is to not error when the rest 
service is unavailable but use that as an indication that the topologies are 
stopped. The rest is code formatting because I've loaded the checkstyle 
template. :)

I'm not 100% happy with how this works, but wanted to get a quick-ish fix 
out while I got 100% happy. That work is described here: 
[METRON-1093](https://issues.apache.org/jira/browse/METRON-1093)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] metron issue #680: METRON-1078: Metron Indexing fails to stop during "Stop A...

2017-08-04 Thread dlyle65535
Github user dlyle65535 commented on the issue:

https://github.com/apache/metron/pull/680
  
Thanks @justinleet  - I'm going to hold off on this, @anandsubbu did some 
additional testing and it didn't actually solve the problem. :( 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] metron issue #680: METRON-1078: Metron Indexing fails to stop during "Stop A...

2017-08-04 Thread justinleet
Github user justinleet commented on the issue:

https://github.com/apache/metron/pull/680
  
+1 by inspection


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---