[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-12-12 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/774 The new Trusty image breaks my build. I need to figure out why exactly, so I'll be trying a few things. ---

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-12-12 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/774 I have created a new feature branch feature/METRON-1211-extensions-parsers-gradual to track this. and have rebased this PR on to that. I have also updated confluence and jira :

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-11-22 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/774 I have refactored to have a top level metron-bundles directory, with the bundles lib and bundles testing under there. ---

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-11-15 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/774 @nickwallen I have added a usage document in the last commit. Is this what you are looking for? ---

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-11-09 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/774 Bringing over this from #530, https://github.com/apache/nifi/commit/d90cf846b9dcd49acdeac7bb5fcd13ee80dcdba6#diff-83e1afb34470ca47809f82aa1caf2138 is the commit in nifi for

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-11-08 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/774 I'm sorry nick, the instruction for 'how to build metron' from the top level readme didn't get pulled over when I did the reconstruction. The plugin is not in any repo for maven to

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-11-08 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/774 I checkout your PR and then attempt to do an install and the build fails. ``` $ mvn clean install [INFO] Scanning for projects... Downloading:

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-11-07 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/774 @mattf-horton I have added some more documentation, and I think the bundles-testing project provides a simple, integrated example. @nickwallen and I talked it over, and he is going to try

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-10-27 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/774 > @ottobackwards hopefully the Readme changes help. The Getting Started information that you added to the README is outstanding! ---

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-10-27 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/metron/pull/774 @ottobackwards says: > would it be possible for you to help us with a comment as to your approach when you reviewed this functionality? It might help if you could summarize your feelings

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-10-27 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/774 @nickwallen hopefully the Readme changes help. ---

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-10-27 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/774 I will extend the readme ---

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-10-27 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/774 @nickwallen If is OK with you, i'll make it a separate file to the README.md ---

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-10-27 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/774 Thanks for looking at this again Nick, let me try to answer your questions. TL;DR I'm sorry for my confusion with your original statement. I had in mind this part of

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-10-27 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/774 > Test Project can be examined as a simple example of how to create bundles. @ottobackwards Maybe I'm being really stupid, but I don't understand how the test-bundles-plugin shows me

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-10-23 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/774 Sounds good @JonZeolla thanks ---

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-10-23 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/774 @nickwallen I am doing some functional testing, but I'm not comfortable enough with it to give a full +1 on my own. When I'm done I will report back. ---

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-10-23 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/774 > @nickwallen: I have just started into this, but seems like I can create a bundle using the Maven plugin with this PR, right? > @ottobackwards: yes you can This was more of a leading

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-10-23 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/774 No, I need to get back to this. Are you? Don't let me stop your own review. ---

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-10-23 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/774 @nickwallen are you still looking at this? ---

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-10-08 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/774 # Testing the bundle plugin I have created a sample project that can be examined for testing the plugin:

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-10-08 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/774 yes you can ---

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-10-08 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/774 > This review is code review and test code review and running only I have just started into this, but seems like I can create a bundle using the Maven plugin with this PR, right? ---

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-10-08 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/774 From a quick check of other PR travis failures, it looks like my build was the only one to have that problem ( which as an expected 1000 got 908 issue ) ---

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-10-08 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/774 On that day the Flat File test failed. Since it worked after open/close I wrote it off to a load / timing issue. https://travis-ci.org/apache/metron/builds/280393026 ---

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-10-08 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/774 @ottobackwards Are we have intermittent test failures again? ---

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-09-27 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/774 FlatFile tests are failing with timeouts, kicking ---

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

2017-09-27 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/774 @bbende this is going in as a separate PR now. I am not sure if you are interest or not, but I figure I'll give you a heads up. ---