Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/780
+1 LGTM. Thanks!
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/780
Kicking Travis.
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/780
@nickwallen I figured out what the problem was. I'd replaced dashes with
spaces and lowercased it, but left the period in `2.x`. After removing the
period, links worked.
@cestella Added
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/780
Three things IMO:
1. Could we add a link to the documentation you have from the front page
README.md under the heading "Notes on Adding a New Sensor"
2. Could we also add a link to the docume
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/780
> @justinleet: Sidenote, does anybody know how to actually link to a head
in a different doc? Anything inside the same doc works fine, but across docs
would be better.
The following exam
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/780
@cestella @nickwallen Hopefully took care of comments that don't involve
migrating wiki docs. Let me know if I looked over anything. Sidenote, does
anybody know how to actually link to a head in
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/780
> Honestly, I think it should at the very least be linked from the
documentation which tells people how to create their own parsers...which we do
not seem to have. ;)
Yes @cestella, I was
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/780
Also, should be linked from metron-parsers makes sense IMO as any time you
are adding a new sensor, you're going to need to add this field. This is the
use-case that keeps biting us in the butt over
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/780
Honestly, I think it should at the very least be linked from the
documentation which tells people how to create their own parsers...which we do
not seem to have. ;)
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/780
> Where should this live? I have this put up, so people can see what it
says, but I'm pretty sure it should live somewhere else, under a different
heading. I'm just not sure what the best fit
10 matches
Mail list logo
