[GitHub] metron issue #791: METRON-1235: Document the properties pulled from the glob...

2017-10-06 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/791 This is excellent. I really like the table layout. +1 pending the merge conflicts and Travis. ---

[GitHub] metron issue #791: METRON-1235: Document the properties pulled from the glob...

2017-10-05 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/791 I'm good with where it's at now. The color is good to have. It's really nice to have this well documented. I'm +1, pending Travis. Although I'll be mildly impressed if you break Travis

[GitHub] metron issue #791: METRON-1235: Document the properties pulled from the glob...

2017-10-05 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/791 Thanks @justinleet I added and provided some color; let me know what you think! ---

[GitHub] metron issue #791: METRON-1235: Document the properties pulled from the glob...

2017-10-05 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/791 One more config I can think of that should be added. `geo.hdfs.file` is also in the global config. It's in Ambari as `geoip_url`. It looks like a small blurb should probably be