[GitHub] metron issue #839: METRON-1311 Service Check Should Check Elasticsearch Inde...

2017-11-15 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/839 +1 by inspection. Thanks @nickwallen! ---

[GitHub] metron issue #839: METRON-1311 Service Check Should Check Elasticsearch Inde...

2017-11-11 Thread anandsubbu
Github user anandsubbu commented on the issue: https://github.com/apache/metron/pull/839 +1 (non-binding). Validated again on full-dev. Works fine, @nickwallen ! ---

[GitHub] metron issue #839: METRON-1311 Service Check Should Check Elasticsearch Inde...

2017-11-10 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/839 I ran this through another full test after merge with master. Everything looks good to me. ---

[GitHub] metron issue #839: METRON-1311 Service Check Should Check Elasticsearch Inde...

2017-11-10 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/839 Thanks @anandsubbu . I resolved the merge conflicts from master. ---

[GitHub] metron issue #839: METRON-1311 Service Check Should Check Elasticsearch Inde...

2017-11-10 Thread anandsubbu
Github user anandsubbu commented on the issue: https://github.com/apache/metron/pull/839 +1 (non-binding) works fine, and a much needed fix as well ! If for some reason, we were not able to install the templates during the startup, it would be caught by the service check.