[GitHub] metron issue #851: METRON-1336 Patching Can Result in Bad Configuration

2017-12-06 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/851 Thanks guys. Nice work on the meta-PRs. I like how that turned out. ---

[GitHub] metron issue #851: METRON-1336 Patching Can Result in Bad Configuration

2017-12-06 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/851 +1 by inspection. Nice work Nick. ---

[GitHub] metron issue #851: METRON-1336 Patching Can Result in Bad Configuration

2017-12-06 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/851 I'm comfortable with this. +1 by inspection ---

[GitHub] metron issue #851: METRON-1336 Patching Can Result in Bad Configuration

2017-12-06 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/851 Bump. Anything else we need on this one? ---

[GitHub] metron issue #851: METRON-1336 Patching Can Result in Bad Configuration

2017-12-04 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/851 @mmiklavc @cestella The kick is complete. All PRs merged. Ready for review. ---