[GitHub] metron pull request #859: METRON-1345: Update EC2 README for custom Ansible ...
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/859 ---
[GitHub] metron pull request #859: METRON-1345: Update EC2 README for custom Ansible ...
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/859#discussion_r157052104 --- Diff: metron-deployment/amazon-ec2/README.md --- @@ -126,6 +126,10 @@ To provision only subsets of the entire Metron deployment, Ansible tags can be s ./run.sh --tags="ec2,sensors" ``` +### Setting REST API Profile + --- End diff -- Just caught your comment above @ottobackwards. No apology necessary, it was/is a perfectly reasonable request. At first I couldn't provide the doc for it because, as I thought it through, I couldn't give a concise answer. I honestly didn't have a clear picture in my mind of what all happens when setting those values. It was definitely worthwhile to cross-check the docs against the source and understand a bit more fully what those profiles are doing. ---
[GitHub] metron pull request #859: METRON-1345: Update EC2 README for custom Ansible ...
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/859#discussion_r157048398
--- Diff: metron-deployment/roles/ambari_config/vars/small_cluster.yml ---
@@ -87,6 +87,8 @@ configurations:
topology.classpath: '{{ topology_classpath }}'
- kafka-broker:
log.dirs: '{{ kafka_log_dirs | default("/kafka-log") }}'
--- End diff --
perfect, thank you @mmiklavc
---
[GitHub] metron pull request #859: METRON-1345: Update EC2 README for custom Ansible ...
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/859#discussion_r157041534 --- Diff: metron-deployment/amazon-ec2/README.md --- @@ -126,6 +126,10 @@ To provision only subsets of the entire Metron deployment, Ansible tags can be s ./run.sh --tags="ec2,sensors" ``` +### Setting REST API Profile + --- End diff -- @ottobackwards I've made another round of improvements after discussing what the profiles do with @merrimanr. Hopefully this addresses your concerns reasonably in the short term. I added this item to the PR in the desire to gain some functional parity with full dev in the short term. But I think we might want to revisit how we setup the REST API, profiles, and user creation in another follow-on PR. ---
[GitHub] metron pull request #859: METRON-1345: Update EC2 README for custom Ansible ...
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/859#discussion_r156755792 --- Diff: metron-deployment/amazon-ec2/README.md --- @@ -126,6 +126,10 @@ To provision only subsets of the entire Metron deployment, Ansible tags can be s ./run.sh --tags="ec2,sensors" ``` +### Setting REST API Profile + --- End diff -- Reading that back, it seems a little stronger than I intended. Sorry. I don't think everyone following these deployment steps is necessarily going to know why they need to start tripping through readme land without some context. We have a lot of people trying deployment and having problems who are not as expert ---
[GitHub] metron pull request #859: METRON-1345: Update EC2 README for custom Ansible ...
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/859#discussion_r156751241 --- Diff: metron-deployment/amazon-ec2/README.md --- @@ -126,6 +126,10 @@ To provision only subsets of the entire Metron deployment, Ansible tags can be s ./run.sh --tags="ec2,sensors" ``` +### Setting REST API Profile + --- End diff -- Just linking to the other doc, without the user knowing even a little of why they need to look at it is not much better. I think my blurb is appropriate. ---
[GitHub] metron pull request #859: METRON-1345: Update EC2 README for custom Ansible ...
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/859#discussion_r156748130 --- Diff: metron-deployment/amazon-ec2/README.md --- @@ -126,6 +126,10 @@ To provision only subsets of the entire Metron deployment, Ansible tags can be s ./run.sh --tags="ec2,sensors" ``` +### Setting REST API Profile + --- End diff -- That's what I linked to in that README change @merrimanr and @ottobackwards. I didn't want to duplicate the REST docs, but agree with Otto about having a reference there. ---
[GitHub] metron pull request #859: METRON-1345: Update EC2 README for custom Ansible ...
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/859#discussion_r156744095 --- Diff: metron-deployment/amazon-ec2/README.md --- @@ -126,6 +126,10 @@ To provision only subsets of the entire Metron deployment, Ansible tags can be s ./run.sh --tags="ec2,sensors" ``` +### Setting REST API Profile + --- End diff -- Spring profiles are documented in the REST README: https://github.com/apache/metron/tree/master/metron-interface/metron-rest#spring-profiles. Is there something we can do to make the REST README more accessible? I feel like a lot of questions people ask are already answered there but no one ever reads it. What can we do to make it more useful? Table of contents maybe? I would be happy to take that on in a follow-up PR. ---
[GitHub] metron pull request #859: METRON-1345: Update EC2 README for custom Ansible ...
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/859#discussion_r156737230 --- Diff: metron-deployment/amazon-ec2/README.md --- @@ -126,6 +126,10 @@ To provision only subsets of the entire Metron deployment, Ansible tags can be s ./run.sh --tags="ec2,sensors" ``` +### Setting REST API Profile + --- End diff -- Can we say something for people like me.. along the lines of "Spring profiles are used for x,y,z. By default the dev profile is selected. Change the values of For more information on setting the profiles and their use please see ---
[GitHub] metron pull request #859: METRON-1345: Update EC2 README for custom Ansible ...
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/859#discussion_r156723676
--- Diff: metron-deployment/roles/ambari_config/vars/small_cluster.yml ---
@@ -87,6 +87,8 @@ configurations:
topology.classpath: '{{ topology_classpath }}'
- kafka-broker:
log.dirs: '{{ kafka_log_dirs | default("/kafka-log") }}'
--- End diff --
Just pushed a change. How's that @ottobackwards?
---
[GitHub] metron pull request #859: METRON-1345: Update EC2 README for custom Ansible ...
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/859#discussion_r156374333
--- Diff: metron-deployment/roles/ambari_config/vars/small_cluster.yml ---
@@ -87,6 +87,8 @@ configurations:
topology.classpath: '{{ topology_classpath }}'
- kafka-broker:
log.dirs: '{{ kafka_log_dirs | default("/kafka-log") }}'
--- End diff --
Should the EC2 Readme include documentation about the dev env and what it
means? Should it link to or document how to change from dev to 'other',
or do other from the start?
---
[GitHub] metron pull request #859: METRON-1345: Update EC2 README for custom Ansible ...
GitHub user mmiklavc opened a pull request: https://github.com/apache/metron/pull/859 METRON-1345: Update EC2 README for custom Ansible tags https://issues.apache.org/jira/browse/METRON-1345 Simple improvement/correction to the EC2 README. This runs the command with the appropriate environment info and skip-tags enabled via the run.sh script instead of through ansible-playbook directly, which misses some things. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mmiklavc/metron ec2-doc-change Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/859.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #859 commit f95a4173bd71c5e8380c3e0708cb4ab7d8ddee97 Author: Michael Miklavcic Date: 2017-12-06T19:52:39Z METRON-1345: Update EC2 README for custom Ansible tags ---
