[GitHub] metron pull request #864: METRON-1348 Metron Service Checks Use Wrong Hostna...
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/864 ---
[GitHub] metron pull request #864: METRON-1348 Metron Service Checks Use Wrong Hostna...
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/864#discussion_r156526514 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/status_params.py --- @@ -80,10 +81,14 @@ # REST metron_rest_port = config['configurations']['metron-rest-env']['metron_rest_port'] -# UI -metron_management_ui_port = config['configurations']['metron-management-ui-env']['metron_management_ui_port'] +# Alerts UI +metron_alerts_ui_host = default("/clusterHostInfo/metron_alerts_ui_hosts", [hostname])[0] --- End diff -- I needed to somehow find the hosts running each service and I knew it was contained in this `clusterHostInfo` configuration. But it was really difficult to uncover what values Ambari keeps in this `clusterHostInfo` configuration. I have not been able to find any documentation on this. I actually had to add some debug statement to a live instance of Ambari to find out what values are stored here and how they are named. Fun, fun. For the record, here is what is stored in `clusterHostInfo` when spinning up the current state of Full Dev. ``` { 'snamenode_host':[ 'node1' ], 'metron_alerts_ui_hosts':[ 'node1' ], 'nm_hosts':[ 'node1' ], 'drpc_server_hosts':[ 'node1' ], 'ambari_server_use_ssl':[ 'false' ], 'all_ping_ports':[ '8670' ], 'all_hosts':[ 'node1' ], 'rm_host':[ 'node1' ], 'kafka_broker_hosts':[ 'node1' ], 'slave_hosts':[ 'node1' ], 'metron_profiler_hosts':[ 'node1' ], 'storm_ui_server_hosts':[ 'node1' ], 'all_racks':[ '/default-rack' ], 'all_ipv4_ips':[ '127.0.0.1' ], 'app_timeline_server_hosts':[ 'node1' ], 'hs_host':[ 'node1' ], 'ambari_server_port':[ '8080' ], 'metron_rest_hosts':[ 'node1' ], 'metron_management_ui_hosts':[ 'node1' ], 'es_master_hosts':[ 'node1' ], 'metron_parsers_hosts':[ 'node1' ], 'kibana_master_hosts':[ 'node1' ], 'metron_enrichment_master_hosts':[ 'node1' ], 'hbase_rs_hosts':[ 'node1' ], 'namenode_host':[ 'node1' ], 'nimbus_hosts':[ 'node1' ], 'hbase_master_hosts':[ 'node1' ], 'metron_indexing_hosts':[ 'node1' ], 'ambari_server_host':[ 'node1' ], 'zookeeper_hosts':[ 'node1' ], 'supervisor_hosts':[ 'node1' ] } ``` ---
[GitHub] metron pull request #864: METRON-1348 Metron Service Checks Use Wrong Hostna...
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/864 METRON-1348 Metron Service Checks Use Wrong Hostname The Metron service check can often use the incorrect hostname when checking the Alerts UI, Management UI, and REST services. This results in a failed service check, even when the services are running successfully. Ambari can run the service check on any node in the cluster, not just the node the service is actually running on. The service check code currently uses the hostname on which the service check is running. If the service is not actually installed on that host, the service check will incorrectly fail. The service check code was updated to find the hostname where the service is installed and use that hostname. ## Testing This change was tested by deploying Metron on Full Dev and running Metron > Service Check in Ambari. The service check should complete successfully when the cluster is healthy. The fix has also been tested on a multi-node cluster in the same manner. ## Pull Request Checklist - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [ ] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? You can merge this pull request into a Git repository by running: $ git pull https://github.com/nickwallen/metron METRON-1348 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/864.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #864 commit 26f34d33cb4d441d25539597a93de39495507d38 Author: Nick Allen Date: 2017-12-11T14:25:17Z METRON-1348 Metron Service Checks Use Wrong Hostname ---