[GitHub] incubator-metron issue #415: METRON-652: Extract indexing config from enrich...

2017-01-16 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/incubator-metron/pull/415 Looks good @cestella . +1 pending Travis --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-metron issue #415: METRON-652: Extract indexing config from enrich...

2017-01-13 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/415 @JonZeolla Yes it is! Whoops, my bad. I guess my JIRA search-fu isn't as good as I thought. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-metron issue #415: METRON-652: Extract indexing config from enrich...

2017-01-12 Thread dlyle65535
Github user dlyle65535 commented on the issue: https://github.com/apache/incubator-metron/pull/415 @mmiklavc - doesn't Enrichment Master's config do the same thing for enrichment.properties? File(format("{metron_config_path}/enrichment.properties"),

[GitHub] incubator-metron issue #415: METRON-652: Extract indexing config from enrich...

2017-01-12 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/incubator-metron/pull/415 @cestella Yeah, if we do a CONFIG_PUT via the Stellar REPL without updating the local file system config copy, that's going to cause syncing problems. --- If your project is set up for

[GitHub] incubator-metron issue #415: METRON-652: Extract indexing config from enrich...

2017-01-12 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/incubator-metron/pull/415 OK, found this for the global config in metron-env.xml ``` global-json global.json template This is the jinja template for global.json

[GitHub] incubator-metron issue #415: METRON-652: Extract indexing config from enrich...

2017-01-12 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/415 Ok, thanks @dlyle65535 I don't think it's a regression (since it doesn't appear to be any different behavior-wise between when it existed in enrichment vs in the new configs), but I do

[GitHub] incubator-metron issue #415: METRON-652: Extract indexing config from enrich...

2017-01-12 Thread dlyle65535
Github user dlyle65535 commented on the issue: https://github.com/apache/incubator-metron/pull/415 Some yes and some no. I'm a bit bleary-eyed today, so I'm not sure if this is the complete list- here's my current understanding. Ambari actively (will overwrite) manages global.json,

[GitHub] incubator-metron issue #415: METRON-652: Extract indexing config from enrich...

2017-01-12 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/415 @dlyle65535 I think that's a great point and thanks for clarifying. Looking at that file, it appears that ambari is explicitly providing the ability to modify the global config and

[GitHub] incubator-metron issue #415: METRON-652: Extract indexing config from enrich...

2017-01-12 Thread dlyle65535
Github user dlyle65535 commented on the issue: https://github.com/apache/incubator-metron/pull/415 @merrimanr , @cestella - wrt management of configs from Ambari, the answer is kinda. Sensible default configurations are pushed with certain user-specified changes that allow the system

[GitHub] incubator-metron issue #415: METRON-652: Extract indexing config from enrich...

2017-01-12 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/415 Testing Instructions beyond the normal smoke test (i.e. letting data flow through to the indices and checking them). ## Preliminaries Since I will use the squid

[GitHub] incubator-metron issue #415: METRON-652: Extract indexing config from enrich...

2017-01-12 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/415 @merrimanr I was under the impression that there was a panel to manage the enrichment configurations per sensor in ambari, but if that's not the case and it's just initial load, then I

[GitHub] incubator-metron issue #415: METRON-652: Extract indexing config from enrich...

2017-01-12 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/incubator-metron/pull/415 What is the regression we're talking about? Are we talking about loading the indexing configs initially with the Mpack or managing the configs in Ambari? I don't believe we

[GitHub] incubator-metron issue #415: METRON-652: Extract indexing config from enrich...

2017-01-12 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/415 @ottobackwards yeah, agreed. It's a fairly complex situation at the moment and not documented very well. That might be worth a discussion on the dev list. --- If your project is set up

[GitHub] incubator-metron issue #415: METRON-652: Extract indexing config from enrich...

2017-01-12 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/415 @dlyle65535 It definitely is a regression. I didn't make it clear enough (I will do so now), but I very much do not want this PR to be committed before the management pack PR is

[GitHub] incubator-metron issue #415: METRON-652: Extract indexing config from enrich...

2017-01-12 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/415 Just a side note: with the rpms and docker everything, it is more difficult than ever to have a handle on all the places you need to consider for changes, I don't know if you want

[GitHub] incubator-metron issue #415: METRON-652: Extract indexing config from enrich...

2017-01-12 Thread dlyle65535
Github user dlyle65535 commented on the issue: https://github.com/apache/incubator-metron/pull/415 Thanks @cestella, makes total sense. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-metron issue #415: METRON-652: Extract indexing config from enrich...

2017-01-12 Thread dlyle65535
Github user dlyle65535 commented on the issue: https://github.com/apache/incubator-metron/pull/415 Hi @cestella, Can you give me a little detail about the consequences of not exposing the indexing config to Ambari? It seems like a regression to me, I recall we could deploy