[GitHub] incubator-metron issue #232: METRON-395 Fix Metron Bro parser not parsing so...

2016-08-26 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/232 So, @mmiklavc this is failing under travis, but the failure that I saw generally is due to travis being overwhelmed and one of the integration test components (kafka in this case, I

[GitHub] incubator-metron issue #233: METRON-396: Make Stellar function resolution ha...

2016-08-26 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/233 Ok, this should be a transparent change to the topology. Things should continue to function as expected. I also verified that this did not break pcap's `query` filter. As such,

[GitHub] incubator-metron issue #232: METRON-395 Fix Metron Bro parser not parsing so...

2016-08-26 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/232 +1, this looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-metron issue #222: METRON-385 Create Ambari Service Definition for...

2016-08-26 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/incubator-metron/pull/222 One issue discovered, which is that, to make things compatible with earlier Kafka versions that don't handle topics already existing that functionality was dropped. This PR needs to be

[GitHub] incubator-metron pull request #233: METRON-396: Make Stellar function resolu...

2016-08-26 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/233 METRON-396: Make Stellar function resolution happen via an annotation and classpath search At the moment, the only way to add a stellar function is to implement StellarFunction and add

[GitHub] incubator-metron pull request #232: METRON-395 Fix Metron Bro parser not par...

2016-08-26 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/232#discussion_r76427074 --- Diff: metron-platform/metron-integration-test/src/main/sample/data/bro/raw/BroExampleOutput --- @@ -1,10 +1,10 @@

[GitHub] incubator-metron pull request #232: METRON-395 Fix Metron Bro parser not par...

2016-08-26 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/232#discussion_r76427204 --- Diff: metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/bro/BasicBroParserTest.java --- @@ -46,14 +46,37 @@ public

[GitHub] incubator-metron issue #218: Metron-383 Create Ambari Service Definition for...

2016-08-26 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/218 This looks good; I'll go +1 providing @dlyle65535 will +1 with me as I'm no expert in Ambari. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-metron issue #231: METRON-394 Create Stellar Date Functions to Use...

2016-08-26 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/231 Looks good, +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-metron pull request #232: METRON-395 Fix Metron Bro parser not par...

2016-08-26 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/232#discussion_r76413858 --- Diff: metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/bro/BasicBroParserTest.java --- @@ -46,14 +46,37 @@ public

[GitHub] incubator-metron pull request #230: METRON-392 Allow User to Define Custom '...

2016-08-26 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/230#discussion_r76412714 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/profiler/ProfileConfig.java --- @@ -27,36 +29,57 @@

[GitHub] incubator-metron pull request #228: METRON-390: Stellar functions should ini...

2016-08-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-metron/pull/228 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-metron issue #219: METRON-196 Fix support of ansible 2.1 in metron...

2016-08-26 Thread 2xyo
Github user 2xyo commented on the issue: https://github.com/apache/incubator-metron/pull/219 Disclamer: I'm not a user of Mac/Homebrew... According to https://github.com/Homebrew/brew > http://braumeister.org/formula/ansible the current version of ansible in homebrew is now