[GitHub] incubator-metron issue #455: METRON-720 modify generate-md.sh to re-throw er...

2017-02-16 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/455 @JonZeolla , thanks for the suggestions. Incorporated the SIG traps and better exit codes, as well as improvements to the 'find -exec' error catching logic. Also added 'set -e' and

[GitHub] incubator-metron issue #455: METRON-720 modify generate-md.sh to re-throw er...

2017-02-16 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/455 @JonZeolla , sorry traveling yesterday. Will look at it this evening. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] incubator-metron issue #455: METRON-720 modify generate-md.sh to re-throw er...

2017-02-16 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/incubator-metron/pull/455 Hm, that's only when building with the bin scripts. re sensor links --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-metron issue #455: METRON-720 modify generate-md.sh to re-throw er...

2017-02-16 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/incubator-metron/pull/455 Tested branch locally, with and without 4 backticks. Looks good to me. +1 Side note, I noticed that the sensors link doesn't go anywhere. --- If your project is set up for it,