[GitHub] incubator-metron pull request #476: METRON-764 DST bug in metron-profiler-cl...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-metron/pull/476 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron issue #477: METRON-766: Release 0.3.1
Github user mmiklavc commented on the issue: https://github.com/apache/incubator-metron/pull/477 +1, now pending Travis cooperating. Links show correctly in latest commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron issue #477: METRON-766: Release 0.3.1
Github user mmiklavc commented on the issue: https://github.com/apache/incubator-metron/pull/477 +1 when the extra [MD5] link gets removed. Both point to the same file. ![image](https://cloud.githubusercontent.com/assets/658443/24020695/e740cdc8-0a62-11e7-89fc-595f15deab44.png) I ran this locally and clicked through all of the new doc book links in "current-book". I checked for any remaining references to 0.3.0 and found none not referring to upgrade paths. Verified the download goes to the correct downloads link. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [DISCUSS] Apache Rat Exclusions
Thanks, Dave! Much appreciated insight. On Thu, Mar 16, 2017 at 4:21 PM, David Lylewrote: > Hi Casey, > > I know a couple. > > > - **/dependency-reduced-pom.xml >- *Does anyone know if we can adjust the dependency-reduced-pom to have > a license?* > > I don't think that should be committed, it may have gotten in there by > mistake. Those are generated on each build. I'd remove the exclusion. > > **/ansible.cfg >- *This is YAML, right? YAML has comments, IIRC. If so we should > license it.* > > Not YAML, more like ini. Supports comments and the copies I looked at had > licenses. I'd remove the exclusion. > > - *These are bundled source scripts, which falls under the rules > around bundling. What are their licenses and did we include > these scripts > in the LICENSE?* > > These come from Bento and are Apache licensed. LICENSED and NOTICED. > > Agree with your conclusions above. > > -D... > > > > > On Thu, Mar 16, 2017 at 3:25 PM, Casey Stella wrote: > > > As part of the mentor feedback on our 0.3.1 release, it was noted that we > > have broad apache rat exclusions in our top level pom. It was suggested > > that we distribute those to the individual relevant modules rather than > > having them in the top level pom. The concern is for broad exclusions > from > > rat that we might be out of compliance with respect to licensing > everything > > which can take a comment. If we intend on moving on to a top level > > project, I think this should at the very least be addressed. > > > > As a prerequisite to that work (and a stop-gap), I'd like to understand > the > > nature of those exclusions so we can at least justify them. Where we > > cannot justify the exclusion, we need to correct it. This ideally should > > happen before we attempt to go to a top level project, in my opinion. > > > > I have listed them here with my comments. The bolded comments are the > ones > > most concerning to me or that I had a pointed question about. > > > > > >- **/*.md > >- *This seems wrong, markdown can take comments, so we should have an > > apache license header, right?* > >- **/VERSION > >- *This is coming from the python sensor plugins. Any suggested > > verbiage around this for the comment?* > >- **/*.json > >- I think this is ok as JSON can't have comments, rights? > >- **/*.tokens > >- These are generated data files from antlr and don't appear to take > > comments, so I think they're ok > >- **/*.log > >- Log files aren't source, so I think this is ok > >- **/*.template > >- ES Templates are JSON and can't have comments > >- **/.* > >- *Which dotfiles are we explicitly excluding? Some dotfiles take > > comments and could be licensed.* > >- **/.*/** > >- ditto > >- **/*.seed > >- *I don't see this anywhere, where did this one come from?* > >- **/*.iml > >- IDE files > >- **/ansible.cfg > >- *This is YAML, right? YAML has comments, IIRC. If so we should > > license it.* > >- **/*.rpm > >- This is generated, binary files, so it should be ok. > >- site/** > >- *This seems wrong. It's jekyll format, so we can't put the license > at > > the top, but we can attach a license in the generated HTML, right?* > >- **/src/main/resources/patterns/** > >- *Does Grok allow for comments? If so, we should license these.* > >- **/src/main/sample/patterns/** > >- *Ditto* > >- **/src/test/resources/** > >- *This seems overly broad, to me. We should at least do it via > > extension. This way if someone adds something that should be > > licensed, we > > know about it, right?* > >- **/src/main/sample/data/** > >- *This is raw data and ok, but maybe it'd be good to make this > project > > specific.* > >- **/dependency-reduced-pom.xml > >- *Does anyone know if we can adjust the dependency-reduced-pom to > have > > a license?* > >- **/target/** > >- **/bro-plugin-kafka/build/** > >- The output of the build, so I think that's ok > >- **/packer-build/scripts/** > > - *These are bundled source scripts, which falls under the rules > > around bundling. What are their licenses and did we include > > these scripts > > in the LICENSE?* > >- **/packer-build/bin/** > >- This seems to be binary data, so ok > >- **/packer_cache/** > >- This seems to be binary data, so ok > >- **/hbase/data/** > >- This seems to be binary data, so ok > >- **/kafkazk/data/** > >- This seems to be binary data, so ok > >- **/wait-for-it.sh > >- This one is cool and explicitly listed in the LICENSE as MIT > licensed > >- **/*.out > >- This seems to be generated output, so ok. > > >
[GitHub] incubator-metron issue #480: METRON-770 Unable to Launch Fastcapa Test Envir...
Github user dlyle65535 commented on the issue: https://github.com/apache/incubator-metron/pull/480 +1, sorry about missing that inventory file earlier, NIck. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [GitHub] incubator-metron issue #477: METRON-766: Release 0.3.1
The delete topic function is Kafka has had some issues in the past. I don't think it's critical we expose that through the REST API so I propose we just take it out. Any objections? On Thu, Mar 16, 2017 at 3:52 PM, cestellawrote: > Github user cestella commented on the issue: > > https://github.com/apache/incubator-metron/pull/477 > > I'm kicking travis, but it appears that there are some intermittent > test failures in the REST API tests. In particular around deleting topics > for the KafkaControllerIntegrationTest: > ``` > Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 9.185 > sec <<< FAILURE! - in org.apache.metron.rest.controller. > KafkaControllerIntegrationTest > test(org.apache.metron.rest.controller.KafkaControllerIntegrationTest) > Time elapsed: 9.13 sec <<< ERROR! > org.springframework.web.util.NestedServletException: Request > processing failed; nested exception is kafka.common. > TopicAlreadyMarkedForDeletionException: topic bro is already marked for > deletion > at org.springframework.web.servlet.FrameworkServlet. > processRequest(FrameworkServlet.java:982) > at org.springframework.web.servlet.FrameworkServlet. > doDelete(FrameworkServlet.java:894) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:654) > at org.springframework.web.servlet.FrameworkServlet. > service(FrameworkServlet.java:846) > at org.springframework.test.web.servlet.TestDispatcherServlet. > service(TestDispatcherServlet.java:65) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:729) > at org.springframework.mock.web.MockFilterChain$ > ServletFilterProxy.doFilter(MockFilterChain.java:167) > at org.springframework.mock.web.MockFilterChain.doFilter( > MockFilterChain.java:134) > at org.springframework.security.web.FilterChainProxy$ > VirtualFilterChain.doFilter(FilterChainProxy.java:317) > at org.springframework.security.web.access.intercept. > FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:127) > at org.springframework.security.web.access.intercept. > FilterSecurityInterceptor.doFilter(FilterSecurityInterceptor.java:91) > at org.springframework.security.web.FilterChainProxy$ > VirtualFilterChain.doFilter(FilterChainProxy.java:331) > at org.springframework.security.web.access. > ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:115) > at org.springframework.security.web.FilterChainProxy$ > VirtualFilterChain.doFilter(FilterChainProxy.java:331) > at org.springframework.security.web.session. > SessionManagementFilter.doFilter(SessionManagementFilter.java:137) > at org.springframework.security.web.FilterChainProxy$ > VirtualFilterChain.doFilter(FilterChainProxy.java:331) > at org.springframework.security.web.authentication. > AnonymousAuthenticationFilter.doFilter(AnonymousAuthenticationFilter. > java:111) > at org.springframework.security.web.FilterChainProxy$ > VirtualFilterChain.doFilter(FilterChainProxy.java:331) > at org.springframework.security.web.servletapi. > SecurityContextHolderAwareRequestFilter.doFilter( > SecurityContextHolderAwareRequestFilter.java:169) > at org.springframework.security.web.FilterChainProxy$ > VirtualFilterChain.doFilter(FilterChainProxy.java:331) > at org.springframework.security.web.savedrequest. > RequestCacheAwareFilter.doFilter(RequestCacheAwareFilter.java:63) > at org.springframework.security.web.FilterChainProxy$ > VirtualFilterChain.doFilter(FilterChainProxy.java:331) > at org.springframework.security.web.authentication.www. > BasicAuthenticationFilter.doFilterInternal(BasicAuthenticationFilter. > java:215) > at org.springframework.web.filter.OncePerRequestFilter. > doFilter(OncePerRequestFilter.java:107) > at org.springframework.security.web.FilterChainProxy$ > VirtualFilterChain.doFilter(FilterChainProxy.java:331) > at org.springframework.security.web.authentication.logout. > LogoutFilter.doFilter(LogoutFilter.java:121) > at org.springframework.security.web.FilterChainProxy$ > VirtualFilterChain.doFilter(FilterChainProxy.java:331) > at org.springframework.security.web.header.HeaderWriterFilter. > doFilterInternal(HeaderWriterFilter.java:66) > at org.springframework.web.filter.OncePerRequestFilter. > doFilter(OncePerRequestFilter.java:107) > at org.springframework.security.web.FilterChainProxy$ > VirtualFilterChain.doFilter(FilterChainProxy.java:331) > at org.springframework.security.web.context. > SecurityContextPersistenceFilter.doFilter(SecurityContextPersistenceFilt > er.java:105) > at org.springframework.security.web.FilterChainProxy$ > VirtualFilterChain.doFilter(FilterChainProxy.java:331) > at org.springframework.security.web.context.request.async. > WebAsyncManagerIntegrationFilter.doFilterInternal(
[GitHub] incubator-metron issue #477: METRON-766: Release 0.3.1
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/477 I'm kicking travis, but it appears that there are some intermittent test failures in the REST API tests. In particular around deleting topics for the KafkaControllerIntegrationTest: ``` Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 9.185 sec <<< FAILURE! - in org.apache.metron.rest.controller.KafkaControllerIntegrationTest test(org.apache.metron.rest.controller.KafkaControllerIntegrationTest) Time elapsed: 9.13 sec <<< ERROR! org.springframework.web.util.NestedServletException: Request processing failed; nested exception is kafka.common.TopicAlreadyMarkedForDeletionException: topic bro is already marked for deletion at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:982) at org.springframework.web.servlet.FrameworkServlet.doDelete(FrameworkServlet.java:894) at javax.servlet.http.HttpServlet.service(HttpServlet.java:654) at org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:846) at org.springframework.test.web.servlet.TestDispatcherServlet.service(TestDispatcherServlet.java:65) at javax.servlet.http.HttpServlet.service(HttpServlet.java:729) at org.springframework.mock.web.MockFilterChain$ServletFilterProxy.doFilter(MockFilterChain.java:167) at org.springframework.mock.web.MockFilterChain.doFilter(MockFilterChain.java:134) at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:317) at org.springframework.security.web.access.intercept.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:127) at org.springframework.security.web.access.intercept.FilterSecurityInterceptor.doFilter(FilterSecurityInterceptor.java:91) at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331) at org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:115) at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331) at org.springframework.security.web.session.SessionManagementFilter.doFilter(SessionManagementFilter.java:137) at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331) at org.springframework.security.web.authentication.AnonymousAuthenticationFilter.doFilter(AnonymousAuthenticationFilter.java:111) at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331) at org.springframework.security.web.servletapi.SecurityContextHolderAwareRequestFilter.doFilter(SecurityContextHolderAwareRequestFilter.java:169) at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331) at org.springframework.security.web.savedrequest.RequestCacheAwareFilter.doFilter(RequestCacheAwareFilter.java:63) at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331) at org.springframework.security.web.authentication.www.BasicAuthenticationFilter.doFilterInternal(BasicAuthenticationFilter.java:215) at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331) at org.springframework.security.web.authentication.logout.LogoutFilter.doFilter(LogoutFilter.java:121) at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331) at org.springframework.security.web.header.HeaderWriterFilter.doFilterInternal(HeaderWriterFilter.java:66) at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331) at org.springframework.security.web.context.SecurityContextPersistenceFilter.doFilter(SecurityContextPersistenceFilter.java:105) at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331) at org.springframework.security.web.context.request.async.WebAsyncManagerIntegrationFilter.doFilterInternal(WebAsyncManagerIntegrationFilter.java:56) at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331) at org.springframework.security.web.FilterChainProxy.doFilterInternal(FilterChainProxy.java:214) at
[GitHub] incubator-metron pull request #477: METRON-766: Release 0.3.1
Github user cestella closed the pull request at: https://github.com/apache/incubator-metron/pull/477 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron pull request #477: METRON-766: Release 0.3.1
GitHub user cestella reopened a pull request: https://github.com/apache/incubator-metron/pull/477 METRON-766: Release 0.3.1 * Remove the 0.3.0 bits in svn from release * Add the 0.3.1 bits from RC5 to release * Update the webpage with the 0.3.1 release You can merge this pull request into a Git repository by running: $ git pull https://github.com/cestella/incubator-metron metron_0.3.1_release_announce Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-metron/pull/477.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #477 commit 19b9850c4b2e8f00dfccc026a7d6f46f808eba47 Author: cstellaDate: 2017-03-16T15:22:28Z Release 0.3.1 website update. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron pull request #481: METRON-322 Global Batching and Flushing
GitHub user mattf-horton opened a pull request: https://github.com/apache/incubator-metron/pull/481 METRON-322 Global Batching and Flushing This patch starts by adding "batchTimeout" essentially every place "batchSize" is used. Since the configuration-related classes are many-layered, this addition is trivial in many cases. The flush-on-timeout logic is fairly straightforward. It was implemented by a refactoring of `BulkWriterComponent` to extract an explicit "flush" from the "write" logic, and then call flush from Tick Tuple processing in `BulkMessageWriterBolt`. The tricky part was figuring out the appropriate setting for `topology.tick.tuple.freq.secs` if the administrator configures non-default batchTimeouts. It is necessary to enumerate the batchTimeout settings for all configured sensorNames, which is implemented in `IndexingConfigurations::getAllConfiguredTimeouts()`. Then multiple other factors must be taken into account to determine the allowed and recommended settings, which is implemented in `BatchTimeoutHelper`. If there are better ways to accomplish these things, please share your ideas. For test and review, it may be useful to know that the default value of `batchTimeout`, and hence for `topology.tick.tuple.freq.secs`, is 14 seconds (which is the default value of `topology.message.timeout.secs` (30 sec) / 2 - 1). To unit test this feature, we added `Clock` logic and implemented a writable `FakeClock`. This may be generally useful for testing other time-based behavior as we add such functionality. All configuration issues were done in such a way as to default to "good" behavior, with no changes needed in current configs of previously installed systems. In fact, recommended configuration is to leave batchTimeout unconfigured, or set it to zero, thereby accepting the system calculated default. After this patch is reviewed and accepted, similar work needs to be done for the `ParserWriter`, and possibly other sub-components. That will be in a separate PR. It is possible to split this patch into sections related to each of sub-tasks METRON-516, METRON-577, METRON-329 and METRON-330. Let me know if you would like me to do so. In the past, people seem to prefer to see a whole feature development in one PR, even though it gets a little long, so that's the way I'm submitting this one, for now. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron (Incubating). Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [NA] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? Yes, see the two modified .md files, and the above information. - [x] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via: ``` mvn -q clean integration-test install && build_utils/verify_licenses.sh ``` - [x] Have you written or updated unit tests and or integration tests to verify your changes? - [NA] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [IN PROCESS] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? You can merge this pull request into a Git repository by running: $ git pull https://github.com/mattf-horton/incubator-metron METRON-322 Alternatively you can review and apply these changes as
Re: [DISCUSS] Apache Rat Exclusions
Hi Casey, I know a couple. - **/dependency-reduced-pom.xml - *Does anyone know if we can adjust the dependency-reduced-pom to have a license?* I don't think that should be committed, it may have gotten in there by mistake. Those are generated on each build. I'd remove the exclusion. **/ansible.cfg - *This is YAML, right? YAML has comments, IIRC. If so we should license it.* Not YAML, more like ini. Supports comments and the copies I looked at had licenses. I'd remove the exclusion. - *These are bundled source scripts, which falls under the rules around bundling. What are their licenses and did we include these scripts in the LICENSE?* These come from Bento and are Apache licensed. LICENSED and NOTICED. Agree with your conclusions above. -D... On Thu, Mar 16, 2017 at 3:25 PM, Casey Stellawrote: > As part of the mentor feedback on our 0.3.1 release, it was noted that we > have broad apache rat exclusions in our top level pom. It was suggested > that we distribute those to the individual relevant modules rather than > having them in the top level pom. The concern is for broad exclusions from > rat that we might be out of compliance with respect to licensing everything > which can take a comment. If we intend on moving on to a top level > project, I think this should at the very least be addressed. > > As a prerequisite to that work (and a stop-gap), I'd like to understand the > nature of those exclusions so we can at least justify them. Where we > cannot justify the exclusion, we need to correct it. This ideally should > happen before we attempt to go to a top level project, in my opinion. > > I have listed them here with my comments. The bolded comments are the ones > most concerning to me or that I had a pointed question about. > > >- **/*.md >- *This seems wrong, markdown can take comments, so we should have an > apache license header, right?* >- **/VERSION >- *This is coming from the python sensor plugins. Any suggested > verbiage around this for the comment?* >- **/*.json >- I think this is ok as JSON can't have comments, rights? >- **/*.tokens >- These are generated data files from antlr and don't appear to take > comments, so I think they're ok >- **/*.log >- Log files aren't source, so I think this is ok >- **/*.template >- ES Templates are JSON and can't have comments >- **/.* >- *Which dotfiles are we explicitly excluding? Some dotfiles take > comments and could be licensed.* >- **/.*/** >- ditto >- **/*.seed >- *I don't see this anywhere, where did this one come from?* >- **/*.iml >- IDE files >- **/ansible.cfg >- *This is YAML, right? YAML has comments, IIRC. If so we should > license it.* >- **/*.rpm >- This is generated, binary files, so it should be ok. >- site/** >- *This seems wrong. It's jekyll format, so we can't put the license at > the top, but we can attach a license in the generated HTML, right?* >- **/src/main/resources/patterns/** >- *Does Grok allow for comments? If so, we should license these.* >- **/src/main/sample/patterns/** >- *Ditto* >- **/src/test/resources/** >- *This seems overly broad, to me. We should at least do it via > extension. This way if someone adds something that should be > licensed, we > know about it, right?* >- **/src/main/sample/data/** >- *This is raw data and ok, but maybe it'd be good to make this project > specific.* >- **/dependency-reduced-pom.xml >- *Does anyone know if we can adjust the dependency-reduced-pom to have > a license?* >- **/target/** >- **/bro-plugin-kafka/build/** >- The output of the build, so I think that's ok >- **/packer-build/scripts/** > - *These are bundled source scripts, which falls under the rules > around bundling. What are their licenses and did we include > these scripts > in the LICENSE?* >- **/packer-build/bin/** >- This seems to be binary data, so ok >- **/packer_cache/** >- This seems to be binary data, so ok >- **/hbase/data/** >- This seems to be binary data, so ok >- **/kafkazk/data/** >- This seems to be binary data, so ok >- **/wait-for-it.sh >- This one is cool and explicitly listed in the LICENSE as MIT licensed >- **/*.out >- This seems to be generated output, so ok. >
[GitHub] incubator-metron pull request #480: METRON-770 Unable to Launch Fastcapa Tes...
GitHub user nickwallen opened a pull request: https://github.com/apache/incubator-metron/pull/480 METRON-770 Unable to Launch Fastcapa Test Environment Unable to launch the Fastcapa test environment. Errors out during launch with the following error. ``` TASK [ambari_gather_facts : Ask Ambari: metron_hosts] ** fatal: [source]: FAILED! => {"failed": true, "msg": "ERROR! 'dict object' has no attribute 'ambari_master'"} PLAY RECAP * source : ok=20 changed=15 unreachable=0failed=1 Ansible failed to complete successfully. Any error output should be visible above. Please fix these errors and try again. ``` Since Ambari is not available in the `fastcapa-test-environment`, it needs to define all of the variables that are retrieved by the `ambari_gather_facts` role. This prevents it from attempting to reach out to Ambari and thus fail and break. This was broken by a change in METRON-671. Simple fix. ## Pull Request Checklist= - [ ] Is there a JIRA ticket associated with this PR? - [ ] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [ ] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via: - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? You can merge this pull request into a Git repository by running: $ git pull https://github.com/nickwallen/incubator-metron METRON-770 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-metron/pull/480.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #480 commit c159a65e56c099a8437a0deeb3873db67f711e1e Author: Nick AllenDate: 2017-03-16T20:09:28Z METRON-770 Unable to Launch Fastcapa Test Environment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron issue #479: METRON-769 Added syslog prog to ASA patterns an...
Github user mmiklavc commented on the issue: https://github.com/apache/incubator-metron/pull/479 +1 on inspection. Unit tests cover records with and without the host/prog values. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[DISCUSS] Apache Rat Exclusions
As part of the mentor feedback on our 0.3.1 release, it was noted that we have broad apache rat exclusions in our top level pom. It was suggested that we distribute those to the individual relevant modules rather than having them in the top level pom. The concern is for broad exclusions from rat that we might be out of compliance with respect to licensing everything which can take a comment. If we intend on moving on to a top level project, I think this should at the very least be addressed. As a prerequisite to that work (and a stop-gap), I'd like to understand the nature of those exclusions so we can at least justify them. Where we cannot justify the exclusion, we need to correct it. This ideally should happen before we attempt to go to a top level project, in my opinion. I have listed them here with my comments. The bolded comments are the ones most concerning to me or that I had a pointed question about. - **/*.md - *This seems wrong, markdown can take comments, so we should have an apache license header, right?* - **/VERSION - *This is coming from the python sensor plugins. Any suggested verbiage around this for the comment?* - **/*.json - I think this is ok as JSON can't have comments, rights? - **/*.tokens - These are generated data files from antlr and don't appear to take comments, so I think they're ok - **/*.log - Log files aren't source, so I think this is ok - **/*.template - ES Templates are JSON and can't have comments - **/.* - *Which dotfiles are we explicitly excluding? Some dotfiles take comments and could be licensed.* - **/.*/** - ditto - **/*.seed - *I don't see this anywhere, where did this one come from?* - **/*.iml - IDE files - **/ansible.cfg - *This is YAML, right? YAML has comments, IIRC. If so we should license it.* - **/*.rpm - This is generated, binary files, so it should be ok. - site/** - *This seems wrong. It's jekyll format, so we can't put the license at the top, but we can attach a license in the generated HTML, right?* - **/src/main/resources/patterns/** - *Does Grok allow for comments? If so, we should license these.* - **/src/main/sample/patterns/** - *Ditto* - **/src/test/resources/** - *This seems overly broad, to me. We should at least do it via extension. This way if someone adds something that should be licensed, we know about it, right?* - **/src/main/sample/data/** - *This is raw data and ok, but maybe it'd be good to make this project specific.* - **/dependency-reduced-pom.xml - *Does anyone know if we can adjust the dependency-reduced-pom to have a license?* - **/target/** - **/bro-plugin-kafka/build/** - The output of the build, so I think that's ok - **/packer-build/scripts/** - *These are bundled source scripts, which falls under the rules around bundling. What are their licenses and did we include these scripts in the LICENSE?* - **/packer-build/bin/** - This seems to be binary data, so ok - **/packer_cache/** - This seems to be binary data, so ok - **/hbase/data/** - This seems to be binary data, so ok - **/kafkazk/data/** - This seems to be binary data, so ok - **/wait-for-it.sh - This one is cool and explicitly listed in the LICENSE as MIT licensed - **/*.out - This seems to be generated output, so ok.
Re: [VOTE] Final Board Resolution Draft
Taylor, are company affiliations a must have on the resolution? I'd like to leave them out altogether 15.03.2017, 13:07, "P. Taylor Goetz": > A few things that should be corrected: > > - The PMC list should include the Apache email address of those individuals > - Remove the list of committers (only PMC members are listed in a graduation > resolution) > - You can drop the paragraph about bylaws since it’s not required and you > already have bylaws > > -Taylor > >> On Mar 15, 2017, at 3:24 PM, James Sirota wrote: >> >> Please vote 1 for OK, -1 for not OK, and 0 for neutral. The vote will be >> open for 72 hours. >> >> The incubating Apache Metron community believes it is time to graduate to >> TLP. >> >> Apache Metron entered incubation in December of 2015. Since then, we've >> overcome technical challenges to remove Category X dependencies, and made 3 >> releases. Our most recent release contains binary convenience artifacts. We >> are a very helpful and engaged community, ready to answer all questions and >> feedback directed to us via the user list. Through our time in incubation >> we've added a number of committers and promoted some of them to PPMC >> membership. We are actively pursuing others. While we do still have issues >> to address raised by means of the maturity model, all projects are ongoing >> processes, and we believe we no longer need the incubator to continue >> addressing these issues. >> >> To inform the discussion, here is some basic project information: >> >> Project status: >> http://incubator.apache.org/projects/metron.html >> >> Project website: >> https://metron.incubator.apache.org/ >> >> Project documentation: >> https://cwiki.apache.org/confluence/display/METRON/Documentation >> >> Maturity assessment: >> >> https://cwiki.apache.org/confluence/display/METRON/Apache+Project+Maturity+Model >> >> DRAFT of the board resolution is at the bottom of this email >> >> Proposed PMC size: 25 members >> >> Total number of committers: 6 members >> >> PMC affiliation (* indicated chair) >> * Hortonworks >> Cisco >> Rackspace >> B23 >> Mantech >> Kinetica >> >> Committer affiliation: >> Leidos >> Paychex >> Carnegie Mellon University >> Hortonworks >> >> 516 commits on develop >> 34 contributors across all branches >> >> dev list averaged ~650 msgs/month for the last 3 months >> >> Resolution: >> >> Establish the Apache Metron Project >> >> WHEREAS, the Board of Directors deems it to be in the best >> interests of the Foundation and consistent with the >> Foundation's purpose to establish a Project Management >> Committee charged with the creation and maintenance of >> open-source software, for distribution at no charge to the >> public, related to a security analytics platform for big data use cases. >> >> NOW, THEREFORE, BE IT RESOLVED, that a Project Management >> Committee (PMC), to be known as the "Apache Metron Project", >> be and hereby is established pursuant to Bylaws of the >> Foundation; and be it further >> >> RESOLVED, that the Apache Metron Project be and hereby is >> responsible for the creation and maintenance of software >> related to: >> (a) A mechanism to capture, store, and normalize any type of security >> telemetry at extremely high rates. >> (b) Real time processing and application of enrichments >> (c) Efficient information storage >> (d) An interface that gives a security investigator a centralized view of >> data and alerts passed through the system. >> >> RESOLVED, that the office of "Vice President, Apache Metron" be >> and hereby is created, the person holding such office to >> serve at the direction of the Board of Directors as the chair >> of the Apache Metron Project, and to have primary responsibility >> for management of the projects within the scope of >> responsibility of the Apache Metron Project; and be it further >> >> RESOLVED, that the persons listed immediately below be and >> hereby are appointed to serve as the initial members of the >> Apache Metron Project: >> >> PPMC: >> Mark Bittmann >> Sheetal Dolas >> Debo Dutta >> Discovery Gerdes >> P. Taylor Goetz >> Andrew Hartnett >> Dave Hirko >> Paul Kehrer >> Brad Kolarov >> Kiran Komaravolu >> Larry McCay >> Ryan Merriman >> Michael Perez >> Charles Porter >> Phillip Rhodes >> Sean Schulte >> James Sirota >> Casey Stella >> Bryan Taylor >> Ray Urciuoli >> Vinod Kumar Vavilapalli >> George Vetticaden >> Oskar Zabik >> David Lyle >> Nick Allen >> >> Committers: >> Otto Fowler >> Kyle Richardson >> Justin Leet >> Michael Miklavcic >> Jon Zeolla >> Matt Foley >> >> NOW, THEREFORE, BE IT FURTHER RESOLVED, that Casey Stella >> be appointed to the office of Vice President, Apache Metron, to >> serve in accordance with and subject to the direction of the >> Board of Directors and the Bylaws of the Foundation until >> death, resignation,
[GitHub] incubator-metron issue #479: METRON-769 Added syslog prog to ASA patterns an...
Github user mmiklavc commented on the issue: https://github.com/apache/incubator-metron/pull/479 @simonellistonball Looks like the AsaIntegrationTest needs a touch-up. It's complaining about syslog_host and syslog_prog. This is the result when I run locally: ``` expected: {"original_string":"<167>Jan 5 08:52:35 10.22.8.216 %ASA-7-609001: Built local-host inside:10.22.8.205","ciscotag":"ASA-7-609001","syslog_facility":"local4","syslog_severity":"debug","timestamp":1451983955000,"source.type":"asa"} actual: {"syslog_host":"10.22.8.216","original_string":"<167>Jan 5 08:52:35 10.22.8.216 %ASA-7-609001: Built local-host inside:10.22.8.205","ciscotag":"ASA-7-609001","syslog_facility":"local4","syslog_prog":null,"syslog_severity":"debug","timestamp":1483606355000,"source.type":"asa"} ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron pull request #479: METRON-769 Added syslog prog to ASA patt...
GitHub user simonellistonball opened a pull request: https://github.com/apache/incubator-metron/pull/479 METRON-769 Added syslog prog to ASA patterns and exposed syslog_host and syslog_prog to output Passed through syslog_host and syslog_prog to ASA output ## Contributor Comments [Please place any comments here. A description of the problem/enhancement, how to reproduce the issue, your testing methodology, etc.] ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron (Incubating). Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via: ``` mvn -q clean integration-test install && build_utils/verify_licenses.sh ``` - [x] Have you written or updated unit tests and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book bin/generate-md.sh mvn site:site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommened that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/simonellistonball/incubator-metron METRON-769 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-metron/pull/479.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #479 commit ca43a2862a4ca22204ff80f6d18415369af65931 Author: Simon Elliston BallDate: 2017-03-16T17:14:48Z Added syslog prog to ASA patterns Passed through syslog_host and syslog_prog to ASA output --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron issue #478: METRON-767: Clean up license
Github user justinleet commented on the issue: https://github.com/apache/incubator-metron/pull/478 I'm +1 on this by inspection (pending Travis). Thanks for taking care of the mentor feedback on this so quickly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron issue #478: METRON-767: Clean up license from METRON-622
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/478 Nah, I slightly broadened the scope of this one, renamed the JIRA and will adjust the title accordingly --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron issue #478: METRON-767: Clean up license from METRON-622
Github user justinleet commented on the issue: https://github.com/apache/incubator-metron/pull/478 Actually, looking into this, it's my fault. I split the MIT license stuff with the geo share alike. It should be moved up. @cestella You want to quick fix that and put up a new PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron pull request #478: METRON-767: Clean up license from METRON...
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/478 METRON-767: Clean up license from METRON-622 Metron-622 put some verbiage at the end of the license that isn't necessary and should be removed. This was pointed out during the 0.3.1 release review and is corrected here. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cestella/incubator-metron METRON-767 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-metron/pull/478.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #478 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron issue #477: METRON-766: Release 0.3.1
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/477 You can try this out by running `bundle exec jekyll serve` from the site directory, navigating to [http://localhost:4000](http://localhost:4000) and clicking on the "Downloads" at the top right. Please allow for a couple of hours from now for the 0.3.1 bits to percolate to the mirrors before the 0.3.1 tar.gz link will work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron pull request #477: METRON-766: Release 0.3.1
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/477 METRON-766: Release 0.3.1 * Remove the 0.3.0 bits in svn from release * Add the 0.3.1 bits from RC5 to release * Update the webpage with the 0.3.1 release You can merge this pull request into a Git repository by running: $ git pull https://github.com/cestella/incubator-metron metron_0.3.1_release_announce Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-metron/pull/477.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #477 commit 19b9850c4b2e8f00dfccc026a7d6f46f808eba47 Author: cstellaDate: 2017-03-16T15:22:28Z Release 0.3.1 website update. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [VOTE] Final Board Resolution Draft
Similarly, since I contribute on my own time only (eg ICLA), it would be best to leave Paychex off the official resolution. -Kyle > On Mar 15, 2017, at 5:17 PM, zeo...@gmail.comwrote: > > Just for clarity, I assume that with removing the committers we'll also > remove the committer affiliation? Since I don't have a CCLA in, I'm not a > big fan of having CMU's name on the list. > > Jon > >> On Wed, Mar 15, 2017 at 4:07 PM P. Taylor Goetz wrote: >> >> A few things that should be corrected: >> >> - The PMC list should include the Apache email address of those individuals >> - Remove the list of committers (only PMC members are listed in a >> graduation resolution) >> - You can drop the paragraph about bylaws since it’s not required and you >> already have bylaws >> >> -Taylor >> >> >>> On Mar 15, 2017, at 3:24 PM, James Sirota wrote: >>> >>> Please vote 1 for OK, -1 for not OK, and 0 for neutral. The vote will >> be open for 72 hours. >>> >>> >>> The incubating Apache Metron community believes it is time to graduate >> to TLP. >>> >>> Apache Metron entered incubation in December of 2015. Since then, we've >> overcome technical challenges to remove Category X dependencies, and made 3 >> releases. Our most recent release contains binary convenience artifacts. >> We are a very helpful and engaged community, ready to answer all questions >> and feedback directed to us via the user list. Through our time in >> incubation we've added a number of committers and promoted some of them to >> PPMC membership. We are actively pursuing others. While we do still have >> issues to address raised by means of the maturity model, all projects are >> ongoing processes, and we believe we no longer need the incubator to >> continue addressing these issues. >>> >>> To inform the discussion, here is some basic project information: >>> >>> Project status: >>> http://incubator.apache.org/projects/metron.html >>> >>> Project website: >>> https://metron.incubator.apache.org/ >>> >>> Project documentation: >>> https://cwiki.apache.org/confluence/display/METRON/Documentation >>> >>> Maturity assessment: >>> >> https://cwiki.apache.org/confluence/display/METRON/Apache+Project+Maturity+Model >>> >>> DRAFT of the board resolution is at the bottom of this email >>> >>> Proposed PMC size: 25 members >>> >>> Total number of committers: 6 members >>> >>> PMC affiliation (* indicated chair) >>> * Hortonworks >>> Cisco >>> Rackspace >>> B23 >>> Mantech >>> Kinetica >>> >>> Committer affiliation: >>> Leidos >>> Paychex >>> Carnegie Mellon University >>> Hortonworks >>> >>> 516 commits on develop >>> 34 contributors across all branches >>> >>> dev list averaged ~650 msgs/month for the last 3 months >>> >>> >>> Resolution: >>> >>> Establish the Apache Metron Project >>> >>> WHEREAS, the Board of Directors deems it to be in the best >>> interests of the Foundation and consistent with the >>> Foundation's purpose to establish a Project Management >>> Committee charged with the creation and maintenance of >>> open-source software, for distribution at no charge to the >>> public, related to a security analytics platform for big data use cases. >>> >>> NOW, THEREFORE, BE IT RESOLVED, that a Project Management >>> Committee (PMC), to be known as the "Apache Metron Project", >>> be and hereby is established pursuant to Bylaws of the >>> Foundation; and be it further >>> >>> RESOLVED, that the Apache Metron Project be and hereby is >>> responsible for the creation and maintenance of software >>> related to: >>> (a) A mechanism to capture, store, and normalize any type of security >> telemetry at extremely high rates. >>> (b) Real time processing and application of enrichments >>> (c) Efficient information storage >>> (d) An interface that gives a security investigator a centralized view >> of data and alerts passed through the system. >>> >>> RESOLVED, that the office of "Vice President, Apache Metron" be >>> and hereby is created, the person holding such office to >>> serve at the direction of the Board of Directors as the chair >>> of the Apache Metron Project, and to have primary responsibility >>> for management of the projects within the scope of >>> responsibility of the Apache Metron Project; and be it further >>> >>> RESOLVED, that the persons listed immediately below be and >>> hereby are appointed to serve as the initial members of the >>> Apache Metron Project: >>> >>> >>> PPMC: >>> Mark Bittmann >>> Sheetal Dolas >>> Debo Dutta >>> Discovery Gerdes >>> P. Taylor Goetz >>> Andrew Hartnett >>> Dave Hirko >>> Paul Kehrer >>> Brad Kolarov >>> Kiran Komaravolu >>> Larry McCay >>> Ryan Merriman >>> Michael Perez >>> Charles Porter >>> Phillip Rhodes >>> Sean Schulte >>> James Sirota >>> Casey Stella >>> Bryan Taylor >>> Ray Urciuoli >>> Vinod Kumar Vavilapalli >>> George Vetticaden >>> Oskar Zabik >>> David Lyle >>> Nick Allen >>> >>>