[GitHub] incubator-metron pull request: METRON-119 Move PCAP infrastructure...

2016-04-29 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/93#discussion_r61567528 --- Diff: metron-deployment/roles/metron_streaming/tasks/metron_topology.yml --- @@ -16,18 +16,14 @@ # --- - name: Submit Metron

[GitHub] incubator-metron pull request: METRON-115 Fetch Threat Intel Data ...

2016-04-27 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/85#issuecomment-215133778 +1 this looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-metron pull request: METRON-116 Automated Testing and Re...

2016-04-27 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/90#issuecomment-215129100 +1, this looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-metron pull request: METRON-110 Add Metron Pycapa to Sta...

2016-04-27 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/86#issuecomment-215129474 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-metron pull request: METRON-119 Move PCAP infrastructure...

2016-04-26 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/89 METRON-119 Move PCAP infrastructure from HBase As it stands, the existing approach to handling PCAP data has some issues handling high volume packet capture data. With the advent

[GitHub] incubator-metron pull request: METRON-119 Move PCAP infrastructure...

2016-04-26 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/89#issuecomment-214755233 Oh, please see the new updated docs for * [Metron PCAP Service](https://github.com/cestella/incubator-metron/tree/pcap_extraction_topology/metron-streaming

[GitHub] incubator-metron pull request: METRON-110 Add Metron Pycapa to Sta...

2016-04-26 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/86#discussion_r61096549 --- Diff: deployment/roles/pycapa/tasks/dependencies.yml --- @@ -15,20 +15,22 @@ # limitations under the License. # --- -- name

[GitHub] incubator-metron pull request: METRON-116 Fastcapa Rename and Impr...

2016-04-26 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/87#discussion_r61094126 --- Diff: metron-sensors/fastcapa/README.md --- @@ -0,0 +1,76 @@ +Fastcapa + + +Fastcapa is an Apache Metron sensor

[GitHub] incubator-metron pull request: METRON-110 Add Metron Pycapa to Sta...

2016-04-26 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/86#discussion_r61097845 --- Diff: deployment/roles/pycapa/tasks/dependencies.yml --- @@ -15,20 +15,22 @@ # limitations under the License. # --- -- name

[GitHub] incubator-metron pull request: METRON-119 Move PCAP infrastructure...

2016-04-27 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/89#issuecomment-215057231 I'm not done merging 113 into this PR branch yet. Took me all day yesterday and I'm still testing. I'll let you know when I'm done. That should make

[GitHub] incubator-metron pull request: Metron 122

2016-04-30 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/96#issuecomment-215979113 @merrimanr Hmm, I liked that feature (being able to run individual roles against either a vagrant image or a prebuilt image). That will be useful, I think

[GitHub] incubator-metron pull request: Metron 122

2016-04-30 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/96#issuecomment-215985677 I'm not sure that `ansible-playbook -i metron-deployment/inventory/singlenode-vagrant/hosts metron-deployment/playbooks/metron_install.yml --tags enrichment

[GitHub] incubator-metron pull request: METRON-124: Mitigate issues found i...

2016-04-28 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/92#issuecomment-215559766 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-metron pull request: METRON-123 Pycapa requires 'kafka_b...

2016-04-28 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/94#issuecomment-215568818 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-metron pull request: METRON-119 Move PCAP infrastructure...

2016-04-28 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/93 METRON-119 Move PCAP infrastructure from HBase As it stands, the existing approach to handling PCAP data has some issues handling high volume packet capture data. With the advent

[GitHub] incubator-metron pull request: METRON-113: Project Reorganization

2016-04-25 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/88#issuecomment-214301254 It appears Metron-Topologies still exists. Is that intended? If so, can we rename to match the naming style of the other projects, please. --- If your

[GitHub] incubator-metron pull request: Metron-126 added dfs.replication=1 ...

2016-05-20 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/125#issuecomment-220620508 +1 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-metron pull request: Specify shorter control_path to avo...

2016-05-20 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/122#issuecomment-220619587 +1 this looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-metron pull request: METRON-178 Expose the filter capabi...

2016-05-24 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/129#discussion_r64495854 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/bolt/ParserBolt.java --- @@ -59,10 +61,22 @@ public ParserBolt

[GitHub] incubator-metron pull request: METRON-178 Expose the filter capabi...

2016-05-24 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/129#issuecomment-221437141 Yeah, upon further consideration, I think that probably an init method is probably the best thing for MessageFilter. I'll refactor. --- If your project

[GitHub] incubator-metron pull request: METRON-179 Fixed Docs for Vagrant D...

2016-05-23 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/124#issuecomment-220977119 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-metron pull request: Metron 173

2016-05-23 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/128#issuecomment-220976859 Since you made a METRON-177 PR, could you please close this one? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-metron pull request: Metron 173

2016-05-20 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/128#issuecomment-220718342 Metron 173 is already merged. It looks like you have another JIRA (Metron 177) for the typos, please open up another PR with just the Metron-177 changes

[GitHub] incubator-metron pull request: METRON-156 Fixed Docs for Vagrant D...

2016-05-20 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/124#discussion_r64060254 --- Diff: metron-deployment/vagrant/full-dev-platform/README.md --- @@ -62,41 +60,46 @@ Now that the hard part is done, start the Metron

[GitHub] incubator-metron pull request: METRON-173 Updating the the Apache ...

2016-05-20 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/126#issuecomment-220634820 +1, this looks great --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-metron pull request: METRON-141: The ability to do threa...

2016-05-09 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/108#discussion_r62583706 --- Diff: metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/bolt/EnrichmentJoinBolt.java --- @@ -84,7 +88,7 @@ public

[GitHub] incubator-metron pull request: [METRON-150] Adding WebSphere parse...

2016-05-11 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/115#discussion_r62843136 --- Diff: metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/websphere/GrokWebSphereParserTest.java --- @@ -0,0 +1,115

[GitHub] incubator-metron pull request: METRON-151: Remove yum update from ...

2016-05-12 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/117#issuecomment-218843462 Definitely +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-metron pull request: METRON-155 Added query filtering ca...

2016-05-12 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/119#discussion_r63087348 --- Diff: metron-platform/metron-api/src/main/java/org/apache/metron/pcapservice/PcapReceiverImplRestEasy.java --- @@ -97,6 +97,66 @@ private

[GitHub] incubator-metron pull request: METRON-155 Added query filtering ca...

2016-05-16 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/119#issuecomment-219425116 +1, got my vote. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-metron pull request: Metron 142 Simplify Parser configur...

2016-05-16 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/120#issuecomment-219424532 This looks good to me. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-metron pull request: [METRON-150] Adding WebSphere parse...

2016-05-13 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/115#issuecomment-219048736 Ok, tested this. Sorry it took so long (vagrant drama). Ok, so this is what I did to test this. Spin up the full-dev-vagrant: 1. Do a build

[GitHub] incubator-metron pull request: METRON-155 Added query filtering ca...

2016-05-13 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/119#issuecomment-219049457 @nickwallen Agreed we should support BPF. This PR makes the filter pluggable and we already have the query language. We can have a follow-on PR for BPF

[GitHub] incubator-metron pull request: Added vagrant install hostmanager s...

2016-05-13 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/121#issuecomment-219068764 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-metron pull request: METRON-132 Monit Integration

2016-05-13 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/118#issuecomment-219158724 +1, looks great! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-metron pull request: METRON-155 Added query filtering ca...

2016-05-12 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/119#discussion_r63101688 --- Diff: metron-platform/metron-pcap/src/main/java/org/apache/metron/pcap/filter/query/QueryPcapFilter.java --- @@ -0,0 +1,74

[GitHub] incubator-metron pull request: METRON-155 Added query filtering ca...

2016-05-12 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/119#discussion_r63102275 --- Diff: metron-platform/metron-pcap/src/main/java/org/apache/metron/pcap/mr/PcapJob.java --- @@ -33,36 +33,39 @@ import

[GitHub] incubator-metron pull request: METRON-155 Added query filtering ca...

2016-05-12 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/119#discussion_r63102232 --- Diff: metron-platform/metron-pcap/src/main/java/org/apache/metron/pcap/mr/PcapJob.java --- @@ -33,36 +33,39 @@ import

[GitHub] incubator-metron pull request: METRON-155 Added query filtering ca...

2016-05-12 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/119#discussion_r63099841 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/query/PredicateProcessor.java --- @@ -18,12 +18,20

[GitHub] incubator-metron pull request: METRON-155 Added query filtering ca...

2016-05-12 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/119#discussion_r63100294 --- Diff: metron-platform/metron-pcap/src/main/java/org/apache/metron/pcap/filter/PcapFilters.java --- @@ -0,0 +1,41 @@ +/** + * Licensed

[GitHub] incubator-metron pull request: METRON-155 Added query filtering ca...

2016-05-12 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/119#issuecomment-218894825 On the whole, this is great. Definitely a great feature and an impressive 2nd PR. Thanks for the contribution! Please make sure you didn't

[GitHub] incubator-metron pull request: METRON-155 Added query filtering ca...

2016-05-12 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/119#discussion_r63105345 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/query/PredicateProcessor.java --- @@ -18,12 +18,20

[GitHub] incubator-metron pull request: METRON-155 Added query filtering ca...

2016-05-12 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/119#discussion_r63115005 --- Diff: metron-platform/metron-pcap/src/main/java/org/apache/metron/pcap/filter/query/QueryPcapFilter.java --- @@ -0,0 +1,74

[GitHub] incubator-metron pull request: METRON-155 Added query filtering ca...

2016-05-12 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/119#discussion_r63112571 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/query/PredicateProcessor.java --- @@ -18,12 +18,20

[GitHub] incubator-metron pull request: METRON-135: Ambari Start needs to s...

2016-05-06 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/106#issuecomment-217462306 Big +1, applied this change last night and it worked like a charm on SNV --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-metron pull request: Update README.md formatting

2016-05-06 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/95#issuecomment-217462512 +1, this is great. Thanks for contributing! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-metron pull request: Metron 122

2016-05-02 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/96#issuecomment-216301128 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-metron pull request: METRON-140 handle empty line in CSV...

2016-05-10 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/109#issuecomment-218142099 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-metron pull request: Metron 136 logrotate pcapservice

2016-05-10 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/113#issuecomment-218212537 This looks good to me, but I'd very much like @dlyle65535 to chime in. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-metron pull request: METRON-127: HDFSDataPrunerTest fail...

2016-05-02 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/97#issuecomment-216260955 +1 this looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-metron pull request: METRON-110 Create lightweight packe...

2016-04-15 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/76#issuecomment-210557717 Yeah the license is fine. We are going to have it installed in the vagrant box as part of ansible, right? On Fri, Apr 15, 2016 at 18:16 Nick Allen

[GitHub] incubator-metron pull request: METRON-110 Create lightweight packe...

2016-04-15 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/76#issuecomment-210562709 Yes On Fri, Apr 15, 2016 at 18:46 Nick Allen <notificati...@github.com> wrote: > Ok good - Leaving argparse in the require

[GitHub] incubator-metron pull request: METRON-103: Unit Tests for storm bo...

2016-04-19 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/81#issuecomment-211975900 +1, looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-metron pull request: METRON-96: Create data purging scri...

2016-04-19 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/79#issuecomment-211974974 +1, looks great. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-metron pull request: METRON-103: Unit Tests for storm bo...

2016-04-19 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/81#discussion_r60249308 --- Diff: metron-streaming/Metron-Common/src/test/java/org/apache/metron/bolt/BulkMessageWriterTest.java --- @@ -0,0 +1,147

[GitHub] incubator-metron pull request: METRON-97: Create data purging scri...

2016-04-19 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/82#issuecomment-211970028 +1, looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-metron pull request: METRON-103: Unit Tests for storm bo...

2016-04-19 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/81#discussion_r60251394 --- Diff: metron-streaming/Metron-EnrichmentAdapters/src/test/java/org/apache/metron/enrichment/bolt/EnrichmentJoinBoltTest.java --- @@ -0,0 +1,86

[GitHub] incubator-metron pull request: METRON-96: Create data purging scri...

2016-04-19 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/79#discussion_r60250470 --- Diff: metron-streaming/Metron-DataLoads/pom.xml --- @@ -167,56 +225,14

[GitHub] incubator-metron pull request: METRON-103: Unit Tests for storm bo...

2016-04-19 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/81#discussion_r60251529 --- Diff: metron-streaming/Metron-EnrichmentAdapters/src/test/java/org/apache/metron/enrichment/bolt/EnrichmentJoinBoltTest.java --- @@ -0,0 +1,86

[GitHub] incubator-metron pull request: METRON-138 Update EC2 README

2016-05-07 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/107#issuecomment-217665540 "Having successfully created your Amazon Web Services account, hopefully you will find that the most difficult tasks are behind us." I LOL'd

[GitHub] incubator-metron pull request: METRON-140 handle empty line in CSV...

2016-05-07 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/109#discussion_r62421915 --- Diff: metron-platform/metron-data-management/src/test/java/org/apache/metron/dataloads/extractor/csv/CSVExtractorTest.java --- @@ -91,5 +85,9

[GitHub] incubator-metron pull request: METRON-140 handle empty line in CSV...

2016-05-07 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/109#discussion_r62421908 --- Diff: metron-platform/metron-data-management/src/main/java/org/apache/metron/dataloads/extractor/csv/CSVExtractor.java --- @@ -82,6 +83,14

[GitHub] incubator-metron pull request: METRON-140 handle empty line in CSV...

2016-05-07 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/109#issuecomment-217665302 This looks great outside of the couple of things I mentioned. Definitely like the null check. +1 imminent if you get those changes. --- If your project

[GitHub] incubator-metron pull request: METRON-180 Enable each component to...

2016-05-25 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/133#issuecomment-221577078 Yeah, this makes sense. Do we need to adjust the `run_ansible_role.sh` to pass in the `--skip-tags` arg as well? --- If your project is set up for it, you

[GitHub] incubator-metron pull request: METRON-100 GeoIP errors out silentl...

2016-05-25 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/134 METRON-100 GeoIP errors out silently in vagrant When we transitioned from passing the value to the adapters to passing a CacheKey object, we never adjusted the SQL statements. Also

[GitHub] incubator-metron pull request: METRON-178 Expose the filter capabi...

2016-05-25 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/129#discussion_r64564714 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/bolt/ParserBolt.java --- @@ -59,10 +61,22 @@ public ParserBolt

[GitHub] incubator-metron pull request: METRON-184 Fixed 'creates' path to ...

2016-05-25 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/132#issuecomment-221577928 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-metron pull request #201: METRON-338 Add indexing rpm. Remove dead...

2016-07-22 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/201#discussion_r71881414 --- Diff: metron-deployment/packaging/docker/rpm-docker/SPECS/metron.spec --- @@ -47,7 +47,8 @@ Source2: metron-elasticsearch

[GitHub] incubator-metron issue #201: METRON-338 Add indexing rpm. Remove dead flux c...

2016-07-22 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/201 +1, ship it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-metron issue #179: METRON-117 Deployment Report Created for All De...

2016-07-14 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/179 +1, by inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-metron issue #181: METRON-279 Removed duplicative roles; metron-ka...

2016-07-14 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/181 +1, by inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-metron issue #180: METRON-281 Simplify deployment to alternative A...

2016-07-14 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/180 +1 by inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-metron issue #185: METRON-294 Refactor parser topology builder

2016-07-14 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/185 +1, by inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-metron issue #182: METRON-225 Amazon-ec2 run script continues runn...

2016-07-14 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/182 +1, by inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-metron issue #177: METRON-262: Update codelab image scripts

2016-07-14 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/177 +1 by inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-metron issue #191: Metron-214 Build RPM Packages for Deployment

2016-07-14 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/191 Why do we not have a separate PR per JIRA? It appears that the various tasks have various authors, wouldn't it be better to have each author submit their own JIRA so that they can

[GitHub] incubator-metron issue #202: METRON-242: Remove Squid Pattern

2016-08-01 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/202 +1 by inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-metron issue #207: METRON-362: Unify the Stellar Languages

2016-08-11 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/207 @nickwallen There is still a PredicateProcessor because having a stellar function which acts as a predicate is a sensible differentiation from a stellar function which returns

[GitHub] incubator-metron issue #203: METRON-357: Create Ambari Service Definition fo...

2016-08-11 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/203 Sorry Dave! I was sleeping on the job. +1 by inspection, this looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-metron issue #207: METRON-362: Unify the Stellar Languages

2016-08-11 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/207 I will defend the org.apache.metron.common.dsl package. That is intended to be utilities for domain specific languages (like variable resolvers, etc). My intention was to open up

[GitHub] incubator-metron pull request #205: METRON-339: Create YARN app to deploy en...

2016-08-03 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/205 METRON-339: Create YARN app to deploy endpoints This is a Yarn application and associated utilities which is intended to allow users the ability to deploy REST endpoints (presumably

[GitHub] incubator-metron issue #188: METRON-227 (Time based flushing)

2016-07-13 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/188 Whoops, forgot, we should probably have a unit test addition given this functionality. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-metron pull request #188: METRON-227 (Time based flushing)

2016-07-13 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/188#discussion_r70704170 --- Diff: metron-platform/metron-integration-test/src/main/config/zookeeper/global.json --- @@ -7,10 +7,12 @@ "solr.collection"

[GitHub] incubator-metron issue #187: Metron 321

2016-07-13 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/187 +1. In the future can you please name the PR starting with the full JIRA name followed by the description, like so: "METRON-321: Add items to .gitignore". The full

[GitHub] incubator-metron pull request #188: METRON-227 (Time based flushing)

2016-07-13 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/188#discussion_r70703025 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/writer/BulkWriterComponent.java --- @@ -34,21 +34,37

[GitHub] incubator-metron pull request #188: METRON-227 (Time based flushing)

2016-07-13 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/188#discussion_r70704522 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/writer/BulkWriterComponent.java --- @@ -103,10 +115,21 @@ public

[GitHub] incubator-metron issue #188: METRON-227 (Time based flushing)

2016-07-13 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/188 Great contribution, thanks! I had a few comments, but good job. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-metron issue #193: METRON-314: Kibana Default Dashboard - Map Brok...

2016-07-21 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/193 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-metron issue #188: METRON-227 (Time based flushing)

2016-07-21 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/188 @mmiklavc That is absolutely what the tick tuple was designed for. What are the pro/con versus the current proposed approach? --- If your project is set up for it, you can reply

[GitHub] incubator-metron issue #200: METRON-333 Add excludes to metron.spec for test...

2016-07-21 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/200 Honestly, we don't want ANY of those flux topologies for the parsers anymore. They should be removed from the RPM as well as from the underlying project. Is there a JIRA to complete

[GitHub] incubator-metron issue #188: METRON-227 (Time based flushing)

2016-07-21 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/188 There is one downside that I see, but I think it's acceptable. We currently keep configuration around the indexing in zookeeper so that the topology configuration can be adjusted

[GitHub] incubator-metron issue #198: METRON-336 Update README.md to use brew instead...

2016-07-21 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/198 I get ya, yeah, we have half the instructions in brew and then the ansible switching in pip.Sounds good, I'm +1. --- If your project is set up for it, you can reply to this email

[GitHub] incubator-metron issue #196: METRON-334 Travis cache Maven dependencies

2016-07-20 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/196 +1 via inspection. Great job, Justin. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-metron pull request #192: METRON-154: Decouple enrichment and inde...

2016-07-15 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/192 METRON-154: Decouple enrichment and indexing This PR is intended to fulfill https://issues.apache.org/jira/browse/METRON-154 You can merge this pull request into a Git repository

[GitHub] incubator-metron pull request #188: METRON-227 (Time based flushing)

2016-07-15 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/188#discussion_r71034703 --- Diff: metron-platform/metron-integration-test/src/main/config/zookeeper/global.json --- @@ -7,10 +7,12 @@ "solr.collection"

[GitHub] incubator-metron issue #191: Metron-214 Build RPM Packages for Deployment

2016-07-14 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/191 Ok, after some out of band discussion, this is fine..lots of small subtasks that had a lot of interdependency. I'm +1 upon inspection. --- If your project is set up for it, you can

[GitHub] incubator-metron pull request #186: METRON-298 Remove the effective_tld_name...

2016-07-11 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/186 METRON-298 Remove the effective_tld_names.dat files Remove these files because they are mozilla licensed and seem to cause problems during the releases. We have a different way of doing

[GitHub] incubator-metron issue #186: METRON-298 Remove the effective_tld_names.dat f...

2016-07-13 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/186 Just for posterity, I ran it up in vagrant --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-metron issue #185: METRON-154 Refactor parser topology builder

2016-07-08 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/185 Can we please not call this METRON-154, since METRON-154 is about decoupling indexing from enrichment and this is not that? I do understand that this might be a prerequisite task

[GitHub] incubator-metron pull request #184: METRON-284: SensorParserConfig object ca...

2016-07-07 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/184 METRON-284: SensorParserConfig object cannot be serialized with the default Jackson ObjectMapper The SensorParserConfig object cannot be serialized without a custom Jackson

<    1   2   3   4   5   6   7   8   9   10   >