[GitHub] incubator-metron issue #361: Add tarLongFileMode posix to maven-assembly-plu...

2016-12-09 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/361 OK - so the previous PR resolved the issue completely on my managed macbook so I can't test if this 'fixes' the issue - but I have built this on that machine without issue, and we

[GitHub] incubator-metron issue #392: METRON-616: Added support for float and long li...

2016-12-09 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/392 So - the case I am thinking of is a stellar transform on an incoming string field that contains a number, but that number will not be marked - so only doubles would work unless I'm

[GitHub] incubator-metron issue #391: METRON-618 Eliminate Javac Warnings in metron-a...

2016-12-09 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/391 +1 on inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-metron issue #392: METRON-616: Added support for double and long l...

2016-12-09 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/392 Just a question to start - does this only work if the input value has the marking ( D,L etc )? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-metron issue #220: Metron-342 Fix permissions of {{ metron_directo...

2016-12-09 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/220 It would be better if we understood why it was happening in this setup a little better --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-metron issue #219: METRON-196 Fix support of ansible 2.1 in metron...

2016-12-09 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/219 I think this issues should be part of a scheduled release effort. It involves changes to the wiki and other places where we have set out the required versions for working

[GitHub] incubator-metron issue #392: METRON-616: Added support for float and long li...

2016-12-09 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/392 @cestella - should I be able to do TO_FLOAT(field) when the field is a string and could be 1231 or 12.31? --- If your project is set up for it, you can reply to this email and have

[GitHub] incubator-metron issue #392: METRON-616: Added support for float and long li...

2016-12-09 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/392 OK - thanks for explaining --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-metron issue #395: METRON-590 Enable Use of Event Time in Profiler

2016-12-15 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/395 Could we have a way of marking parts of STELLAR as preview or beta? Just get them out there, and have a review/feedback period. --- If your project is set up for it, you can reply

[GitHub] incubator-metron issue #393: METRON-622: Create a Metron Docker Compose appl...

2016-12-15 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/393 I will continue to validate this when that next push goes out. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-metron issue #395: METRON-590 Enable Use of Event Time in Profiler

2016-12-15 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/395 OK - I'll create a jira for that - and tag you guys for comments/editing? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-metron issue #396: METRON-625: Parser Filters cannot be specified ...

2016-12-15 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/396 Are there upgrade issues with the QUERY change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-metron issue #396: METRON-625: Parser Filters cannot be specified ...

2016-12-15 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/396 So it there is nothing with that value out there so there are no serialization issues --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-metron issue #374: METRON-587 Integration tests should use common ...

2016-12-16 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/374 Done. Sorry about that --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-metron issue #392: METRON-616: Added support for float and long li...

2016-12-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/392 +1 by inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-metron issue #393: METRON-622: Create a Metron Docker Compose appl...

2016-12-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/393 I have followed the instructions, and it looks like it all worked but I am not sure what to do next to test this out. The README is missing a usage example or something similar

[GitHub] incubator-metron pull request #396: METRON-625: Parser Filters cannot be spe...

2016-12-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/396#discussion_r92497084 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/bolt/ParserBolt.java --- @@ -76,12 +77,15 @@ public void

[GitHub] incubator-metron issue #394: METRON-623: Management UI

2016-12-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/394 Does this depend on the docker branch being landed first? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-metron pull request #395: METRON-590 Enable Use of Event Time in P...

2016-12-17 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/395#discussion_r92921099 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/functions/TimeFunctions.java --- @@ -0,0 +1,48

[GitHub] incubator-metron pull request #395: METRON-590 Enable Use of Event Time in P...

2016-12-17 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/395#discussion_r92921070 --- Diff: metron-platform/metron-common/src/test/java/org/apache/metron/common/utils/StellarExecutor.java --- @@ -0,0 +1,84 @@ +package

[GitHub] incubator-metron issue #397: METRON-627: Add HyperLogLogPlus implementation ...

2016-12-16 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/397 In that case, we should have multiple concise README's with more detail and a top level overview readme --- If your project is set up for it, you can reply to this email and have

[GitHub] incubator-metron issue #397: METRON-627: Add HyperLogLogPlus implementation ...

2016-12-16 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/397 Maybe we could build a readme-wiki, like a section of our wiki which is just the readme's from the current build? --- If your project is set up for it, you can reply to this email

[GitHub] incubator-metron issue #397: METRON-627: Add HyperLogLogPlus implementation ...

2016-12-16 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/397 Should functions like this have a more expansive description, that perhaps includes a set of sample data and the outcome? Similar to what the Profiler functions have? --- If your

[GitHub] incubator-metron pull request #316: METRON-503: Metron REST API

2016-12-16 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/316#discussion_r92865739 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/SensorParserConfigService.java --- @@ -0,0 +1,169

[GitHub] incubator-metron pull request #397: METRON-627: Add HyperLogLogPlus implemen...

2016-12-16 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/397#discussion_r92866062 --- Diff: metron-platform/metron-common/README.md --- @@ -229,21 +249,33 @@ Using parens such as: "foo" : "\<ok\>"

[GitHub] incubator-metron issue #395: METRON-590 Enable Use of Event Time in Profiler

2016-12-16 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/395 @nickwallen @cestella METRON-628 Please update or comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-metron issue #397: METRON-627: Add HyperLogLogPlus implementation ...

2016-12-16 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/397 I agree with keeping the README's lean. What I'm struggling with ( and this may just be as an FOSS noob ) is that there seems to be no process around calling out documentation

[GitHub] incubator-metron issue #397: METRON-627: Add HyperLogLogPlus implementation ...

2016-12-16 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/397 what we need is a plan, whatever it is ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-metron issue #415: METRON-652: Extract indexing config from enrich...

2017-01-12 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/415 Just a side note: with the rpms and docker everything, it is more difficult than ever to have a handle on all the places you need to consider for changes, I don't know if you want

[GitHub] incubator-metron pull request #400: METRON-636: Capture memory and cpu detai...

2017-01-12 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/400#discussion_r95818504 --- Diff: metron-deployment/scripts/platform-info.sh --- @@ -62,3 +62,39 @@ mvn --version # operating system echo "--"

[GitHub] incubator-metron issue #393: METRON-622: Create a Metron Docker Compose appl...

2017-01-10 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/393 +1 - this is great work Ryan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-metron pull request #401: METRON-637: Add a STATS_BIN function to ...

2017-01-10 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/401#discussion_r95372290 --- Diff: metron-analytics/metron-statistics/src/test/java/org/apache/metron/statistics/StellarStatisticsFunctionsTest.java --- @@ -356,6

[GitHub] incubator-metron issue #393: METRON-622: Create a Metron Docker Compose appl...

2017-01-10 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/393 Just waiting on the docs for a +1 on this, then we can get it in --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-metron issue #380: METRON-597 Sporadic Failures of Profiler Integr...

2016-11-30 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/380 can this be done in the pom/surefire? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-metron issue #380: METRON-597 Sporadic Failures of Profiler Integr...

2016-11-30 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/380 Configuration only change. So, let's say that there is another pr that changes that test, it can do so without worrying about the commented out code etc. not a big deal, really

[GitHub] incubator-metron issue #380: METRON-597 Sporadic Failures of Profiler Integr...

2016-12-01 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/380 I think you closed the wrong one --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-metron issue #382: METRON-598 Add Kyle Richardson to committers

2016-12-01 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/382 +1 inspection and ran site in per document --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-metron pull request #370: METRON-586 add FILL_LEFT and FILL_RIGHT ...

2016-12-03 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/370#discussion_r90770201 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/functions/StringFunctions.java --- @@ -222,4 +222,71

[GitHub] incubator-metron pull request #370: METRON-586 add FILL_LEFT and FILL_RIGHT ...

2016-12-03 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/370#discussion_r90770222 --- Diff: metron-platform/metron-common/src/test/java/org/apache/metron/common/stellar/StellarTest.java --- @@ -593,6 +595,39 @@ public void

[GitHub] incubator-metron pull request #370: METRON-586 add FILL_LEFT and FILL_RIGHT ...

2016-12-03 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/370#discussion_r90770215 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/functions/StringFunctions.java --- @@ -222,4 +222,71

[GitHub] incubator-metron pull request #370: METRON-586 add FILL_LEFT and FILL_RIGHT ...

2016-12-03 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/370#discussion_r90770168 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/functions/StringFunctions.java --- @@ -222,4 +222,71

[GitHub] incubator-metron pull request #374: METRON-587 Integration tests should use ...

2016-11-29 Thread ottobackwards
GitHub user ottobackwards reopened a pull request: https://github.com/apache/incubator-metron/pull/374 METRON-587 Integration tests should use common processor implementations where possible We have 7 or so integration tests that implement the Processor interface. Much of the code

[GitHub] incubator-metron issue #383: METRON-597 Sporadic Failures of Profiler Integr...

2016-12-02 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/383 +1 Ran pr on travis --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-metron issue #379: METRON-595: ES Writer uses more than one IP

2016-12-02 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/379 @dlyle65535 I did not test, I was answering the question of if quick-dev works at all --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-metron issue #393: METRON-622: Create a Metron Docker Compose appl...

2017-01-06 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/393 What step was supposed to start the virtual box machine? How do I do this 'using docker-machine' differently than the instructions? I followed them exactly from the top

[GitHub] incubator-metron issue #393: METRON-622: Create a Metron Docker Compose appl...

2017-01-06 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/393 9028 checkout-pr 393 9029 cd incubator-metron-pr-393 9030 mvn clean install -DskipTests 9031 export METRON_HOME=. 9032 export METRON_DOCKER_HOME=$METRON_HOME

[GitHub] incubator-metron issue #393: METRON-622: Create a Metron Docker Compose appl...

2017-01-06 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/393 I have run that - I have been able to do the steps in the readme ( except the topology which i haven't tried ) up until that point ( so my ZK is configured etc ) ottofowler

[GitHub] incubator-metron issue #393: METRON-622: Create a Metron Docker Compose appl...

2017-01-06 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/393 0 pr-393 % docker ps --format 'table {{.Names}}\t{{.Status}}' NAMESSTATUS metron_storm_1 Up About an hour metron_kibana_1 Up

[GitHub] incubator-metron issue #393: METRON-622: Create a Metron Docker Compose appl...

2017-01-06 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/393 I don't know enough about docker, i can exec into bash and populate zk etc so it is 'running' or something is --- If your project is set up for it, you can reply to this email

[GitHub] incubator-metron issue #393: METRON-622: Create a Metron Docker Compose appl...

2017-01-06 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/393 ottofowler@Winterfell ~/src/apache/work/incubator-metron-pr-393/metron-docker/compose 130 pr-393 % docker-machine ls NAME ACTIVE DRIVER STATE URL

[GitHub] incubator-metron issue #393: METRON-622: Create a Metron Docker Compose appl...

2017-01-06 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/393 Actually - the test output data stuff was failing too, I just hadn't waited long enough to see since I wasn't trying to read. --- If your project is set up for it, you can reply

[GitHub] incubator-metron issue #393: METRON-622: Create a Metron Docker Compose appl...

2017-01-06 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/393 When trying to verify the Run Sensor Data End to end with two terminals I get : ottofowler@Winterfell ~/src/apache/work/incubator-metron-pr-393/metron-docker/compose 1 pr-393

[GitHub] incubator-metron issue #393: METRON-622: Create a Metron Docker Compose appl...

2017-01-06 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/393 ` value=$(VBoxManage list vms | grep -ic "metron-machine" ) if [ $value -eq 1 ] then VBoxManage startvm "metron-machine&q

[GitHub] incubator-metron issue #393: METRON-622: Create a Metron Docker Compose appl...

2017-01-06 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/393 I don't think we can assume that dev's will just leave it up and running. The flow should be close to the vagrant flow shouldn't it? --- If your project is set up for it, you can

[GitHub] incubator-metron issue #393: METRON-622: Create a Metron Docker Compose appl...

2017-01-06 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/393 This is a great work. I am not sure what the right flow or scripts will end up being, but if we document it we can land it and iterate through pr's later. --- If your project

[GitHub] incubator-metron issue #393: METRON-622: Create a Metron Docker Compose appl...

2017-01-06 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/393 So - should we destroy the machine when we are done? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-metron issue #393: METRON-622: Create a Metron Docker Compose appl...

2017-01-06 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/393 ok - starting the machine fixed it. I think the issue is that I had a defined, but not running machine from a previous run. So either we need instructions to be clear on what to do

[GitHub] incubator-metron issue #393: METRON-622: Create a Metron Docker Compose appl...

2017-01-06 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/393 This does bring up an interesting point: when testing something like this - it is not enough to just run through the examples, you need to do the more realistic workflow - multiple

[GitHub] incubator-metron issue #393: METRON-622: Create a Metron Docker Compose appl...

2017-01-03 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/393 If the indices are not installed, then the topologies are moot. I am sorry, I don't mean to be difficult, I am just not sure if it is working and I don't understand what the result

[GitHub] incubator-metron issue #393: METRON-622: Create a Metron Docker Compose appl...

2017-01-03 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/393 ok, I was not using the updated examples in the read me to verify the pr. It was not clear to me, after starting everything up, what I should expect to be working and what should

[GitHub] incubator-metron issue #393: METRON-622: Create a Metron Docker Compose appl...

2017-01-03 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/393 Maybe we can create jiras for these, and someone else might help? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-metron issue #395: METRON-590 Enable Use of Event Time in Profiler

2016-12-19 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/395 I like the change tot he StellarProcessorUtils, should we rename it to StellarExecutorUtils? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-metron issue #361: Add tarLongFileMode posix to maven-assembly-plu...

2016-12-19 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/361 I have created METRON-630 for this. Please change the title of the pull request. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-metron pull request #395: METRON-590 Enable Use of Event Time in P...

2016-12-19 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/395#discussion_r93092757 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/manager/ZkConfigurationManager.java --- @@ -0,0

[GitHub] incubator-metron issue #399: METRON-600: Fix Metron Website

2016-12-20 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/399 Tested with jekyll serve and safari. Everything seems to work. I am wondering about the redundancy between the community resources and getting involved links and pulling

[GitHub] incubator-metron pull request #402: METRON-639: The Network Stellar function...

2016-12-22 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/402#discussion_r93649682 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/functions/NetworkFunctions.java --- @@ -163,12 +163,16

[GitHub] incubator-metron issue #393: METRON-622: Create a Metron Docker Compose appl...

2016-12-22 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/393 So just to be clear, the end result of this is the cluster deployed, but nothing installed? No topologies, no indices in ES etc? --- If your project is set up for it, you can reply

[GitHub] incubator-metron issue #402: METRON-639: The Network Stellar functions need ...

2016-12-22 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/402 +1 by inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-metron pull request #402: METRON-639: The Network Stellar function...

2016-12-22 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/402#discussion_r93650018 --- Diff: metron-platform/metron-common/src/test/java/org/apache/metron/common/stellar/network/NetworkFunctionsTest.java --- @@ -0,0 +1,164

[GitHub] incubator-metron issue #389: METRON-612: Clean up Error Prone generated warn...

2016-12-07 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/389 nope, it is fine. I was just thinking that since we are looking outward for reference and inspiration, we should continue to do that on some of these issues as they come up

[GitHub] incubator-metron issue #370: METRON-586 add FILL_LEFT and FILL_RIGHT functio...

2016-12-07 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/370 I am kicking this to travis again. I'm seeing integration test run timeout errors locally trying to verify before commit and I want to sanity check --- If your project is set up

[GitHub] incubator-metron issue #397: METRON-627: Add HyperLogLogPlus implementation ...

2016-12-16 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/397 But, I just download the binaries or install through ambari? You mean I have to look through the codebase? --- If your project is set up for it, you can reply to this email

[GitHub] incubator-metron issue #401: METRON-637: Add a STATS_BIN function to Stellar...

2016-12-22 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/401 Do these methods *have* to run on every tuple? Can you set some kind of sample rate parameter to give a way to play with performance? --- If your project is set up for it, you can

[GitHub] incubator-metron pull request #494: METRON-806 set posix

2017-03-28 Thread ottobackwards
GitHub user ottobackwards opened a pull request: https://github.com/apache/incubator-metron/pull/494 METRON-806 set posix for metron-rest ## Contributor Comments Any new assemblies added to the project need to have the tarLongFileMode set Tested by running

[GitHub] incubator-metron issue #494: METRON-806 set posix

2017-03-28 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/494 Ok - removed from child poms, put in parent --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-metron pull request #489: METRON-623: Management UI

2017-03-31 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/489#discussion_r109204340 --- Diff: metron-interface/metron-config/e2e/sensor-config-readonly/sensor-config-readonly.po.ts --- @@ -0,0 +1,125

[GitHub] incubator-metron issue #501: METRON-812: Make the bro-kafka plugin work with...

2017-03-31 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/501 +1 by inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-metron issue #516: METRON-830 Adding StringFunctions to Stellar - ...

2017-04-11 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/516 +1, thanks for the contribution --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-metron pull request #505: METRON-817: Customise output file path p...

2017-04-03 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/505#discussion_r109428569 --- Diff: metron-platform/metron-writer/src/main/java/org/apache/metron/writer/hdfs/HdfsWriter.java --- @@ -74,17 +91,43 @@ public

[GitHub] incubator-metron pull request #505: METRON-817: Customise output file path p...

2017-04-03 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/505#discussion_r109428017 --- Diff: metron-platform/metron-writer/src/main/java/org/apache/metron/writer/hdfs/HdfsWriter.java --- @@ -74,17 +91,43 @@ public

[GitHub] incubator-metron issue #508: METRON-820: StellarProcessor should have a stat...

2017-04-03 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/508 1 question -> does this require any relation to the VFS cache? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] incubator-metron issue #508: METRON-820: StellarProcessor should have a stat...

2017-04-03 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/508 +1 by inspection, although I'm inclined to think of a reason not to have a static cache, but instead an instance based one, I can't think of a specific case. --- If your project

[GitHub] incubator-metron pull request #516: METRON-830 Adding StringFunctions to Ste...

2017-04-10 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/516#discussion_r110629309 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/functions/StringFunctions.java --- @@ -343,4 +343,89

[GitHub] incubator-metron pull request #516: METRON-830 Adding StringFunctions to Ste...

2017-04-10 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/516#discussion_r110629490 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/functions/StringFunctions.java --- @@ -343,4 +343,89

[GitHub] incubator-metron issue #530: METRON-777 Metron Extension System and Parser E...

2017-04-13 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/530 So do you like want a listing of files? All the areas of functionality that are not bundle or parser extensions would be the areas to look at. Although I would say

[GitHub] incubator-metron issue #530: METRON-777 Metron Extension System and Parser E...

2017-04-13 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/530 RE: Travis I was getting these and going to vm was the only way I could get rid of them: The system is out of resources. Consult the following stack trace

[GitHub] incubator-metron issue #530: METRON-777 Metron Extension System and Parser E...

2017-04-13 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/530 if you don't review the parsers, because the code didn't change, you still need to review or think about the concept that each parser, as an extension should have all of the things

[GitHub] incubator-metron issue #528: METRON-838 Incorrect set of ts in FireEye parse...

2017-04-13 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/528 Hi bjigmp! Thanks for the contribution. We have a template for our PR's, that help us review and accept them. This PR is missing that, can you please add

[GitHub] incubator-metron issue #528: METRON-838 Incorrect set of ts in FireEye parse...

2017-04-13 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/528 No just the appropriate ones you can see. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-metron pull request #439: METRON-571 add stellar external function...

2017-03-09 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/439#discussion_r105328056 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/ExternalFunctions.java --- @@ -0,0 +1,292

[GitHub] incubator-metron issue #436: METRON-671: Refactor existing Ansible deploymen...

2017-03-09 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/436 I am +1. I have been working downstream and building off of this for a bit, and been able to get quick and full up with everything started. I have some things that I would like

[GitHub] incubator-metron issue #405: METRON-641: Fixed kibana_master.py Python3 miss

2017-03-09 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/405 I will later tonight or first thing tomorrow am --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-metron pull request #439: METRON-571 add stellar external function...

2017-03-09 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/439#discussion_r105325103 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/ExternalFunctions.java --- @@ -0,0 +1,292

[GitHub] incubator-metron issue #439: METRON-571 add stellar external functions featu...

2017-03-09 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/439 This is missing documentation. There are going to be requirements to the types of scripts that can be called, and they all need to be listed out. A sample script or even a template

[GitHub] incubator-metron pull request #439: METRON-571 add stellar external function...

2017-03-09 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/439#discussion_r105324915 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/ExternalFunctions.java --- @@ -0,0 +1,292

[GitHub] incubator-metron pull request #439: METRON-571 add stellar external function...

2017-03-09 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/439#discussion_r105325302 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/ExternalFunctions.java --- @@ -0,0 +1,292

[GitHub] incubator-metron pull request #439: METRON-571 add stellar external function...

2017-03-09 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/439#discussion_r105325249 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/ExternalFunctions.java --- @@ -0,0 +1,292

[GitHub] incubator-metron pull request #439: METRON-571 add stellar external function...

2017-03-09 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/439#discussion_r105325529 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/ExternalFunctions.java --- @@ -0,0 +1,292

[GitHub] incubator-metron pull request #439: METRON-571 add stellar external function...

2017-03-09 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/439#discussion_r105325446 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/ExternalFunctions.java --- @@ -0,0 +1,292

[GitHub] incubator-metron pull request #439: METRON-571 add stellar external function...

2017-03-09 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/439#discussion_r105327868 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/ExternalFunctions.java --- @@ -0,0 +1,292

<    1   2   3   4   >