Github user cestella commented on the issue:
https://github.com/apache/incubator-metron/pull/456
+1 from me by inspection.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jjmeyer0 commented on the issue:
https://github.com/apache/incubator-metron/pull/456
@ottobackwards looks good to me. Again, great idea. I think it's ready to
be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user ottobackwards commented on the issue:
https://github.com/apache/incubator-metron/pull/456
I put a reference to the verification doc at the top ' for smoke test guide
' and then put a checkbox for running in vagrant - how's that?
---
If your project is set up for it, you
Github user cestella commented on the issue:
https://github.com/apache/incubator-metron/pull/456
Ok this isn't awesome work, Otto! I love this idea. I'll let it percolate
for a bit but my +1 is imminent. :)
---
If your project is set up for it, you can reply to this email and have
Github user jjmeyer0 commented on the issue:
https://github.com/apache/incubator-metron/pull/456
Oh, absolutely. Sorry, I didn't mean to suggest to add the whole page. I
just meant a check box that says something like: Have verified building and
running locally by creating `full-dev`
Github user cestella commented on the issue:
https://github.com/apache/incubator-metron/pull/456
Yeah I think that a smoke test on vagrant is sufficient. A smoke test
being that data flows through the topologies and into ES and is viewable by
kibana.
---
If your project is set up
Github user ottobackwards commented on the issue:
https://github.com/apache/incubator-metron/pull/456
So - why don't we come up with a cut down version of that, maybe restricted
to trying quick or full dev? or reference and link like we do with the full
dev guide?
---
If your
Github user jjmeyer0 commented on the issue:
https://github.com/apache/incubator-metron/pull/456
I agree it shouldn't be a duplicate of the dev guide. My thought on the
verify builds was that quite a few PRs state they've done it. That being said,
I'm not hung up on it. I'll defer to
Github user ottobackwards commented on the issue:
https://github.com/apache/incubator-metron/pull/456
Thanks for the review!
I am not sure about verifying builds. I don't think we should put
everything that is in the Dev Guide or the Verification in the PR template,
there
Github user jjmeyer0 commented on the issue:
https://github.com/apache/incubator-metron/pull/456
Also, what do you think about adding a check box for verifying builds?
https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds
---
If your project is set up for it, you can
10 matches
Mail list logo
