Re: Files modified after building
Well, if you are going to be so quick, how can I make you wait? working on it. On February 25, 2017 at 23:39:15, Casey Stella (ceste...@gmail.com) wrote: Sorry, couldn't wait for monday. Fix is submitted for your review and heckling: https://github.com/apache/incubator-metron/pull/466 :) On Sat, Feb 25, 2017 at 11:22 PM, Matt Foleywrote: > Well, the last three are in a path with “/generated/” in it. > > > On 2/25/17, 7:39 PM, "Casey Stella" wrote: > > Crap, those are generated by the new profile selector dsl committed > Friday. > I must've missed them on a commit on the PR. They are generated by the > build, so it was factored into the tests and such for the PR. Sorry > for the > inconvenience, I'll have to make another PR on Monday to get them in. > On Sat, Feb 25, 2017 at 22:21 Kyle Richardson < > kylerichards...@gmail.com> > wrote: > > > That's my guess. I noticed the same thing. > > > > -Kyle > > > > > On Feb 25, 2017, at 8:31 PM, Otto Fowler > > wrote: > > > > > > Changes not staged for commit: > > > > > > (use "git add ..." to update what will be committed) > > > > > > (use "git checkout -- ..." to discard changes in working > > directory) > > > > > > > > > modified: > > > metron-analytics/metron-profiler-client/src/main/java/ > Window.tokens > > > > > > modified: > > > metron-analytics/metron-profiler-client/src/main/java/ > WindowLexer.tokens > > > > > > modified: > > > > > metron-analytics/metron-profiler-client/src/main/java/ > org/apache/metron/profiler/client/window/generated/WindowLexer.java > > > > > > modified: > > > > > metron-analytics/metron-profiler-client/src/main/java/ > org/apache/metron/profiler/client/window/generated/WindowListener.java > > > > > > modified: > > > > > metron-analytics/metron-profiler-client/src/main/java/ > org/apache/metron/profiler/client/window/generated/WindowParser.java > > > > > > > > > > > > > > > Are these files changed by the build? > > > > > >
Re: Files modified after building
Sorry, couldn't wait for monday. Fix is submitted for your review and heckling: https://github.com/apache/incubator-metron/pull/466 :) On Sat, Feb 25, 2017 at 11:22 PM, Matt Foleywrote: > Well, the last three are in a path with “/generated/” in it. > > > On 2/25/17, 7:39 PM, "Casey Stella" wrote: > > Crap, those are generated by the new profile selector dsl committed > Friday. > I must've missed them on a commit on the PR. They are generated by the > build, so it was factored into the tests and such for the PR. Sorry > for the > inconvenience, I'll have to make another PR on Monday to get them in. > On Sat, Feb 25, 2017 at 22:21 Kyle Richardson < > kylerichards...@gmail.com> > wrote: > > > That's my guess. I noticed the same thing. > > > > -Kyle > > > > > On Feb 25, 2017, at 8:31 PM, Otto Fowler > > wrote: > > > > > > Changes not staged for commit: > > > > > > (use "git add ..." to update what will be committed) > > > > > > (use "git checkout -- ..." to discard changes in working > > directory) > > > > > > > > > modified: > > > metron-analytics/metron-profiler-client/src/main/java/ > Window.tokens > > > > > > modified: > > > metron-analytics/metron-profiler-client/src/main/java/ > WindowLexer.tokens > > > > > > modified: > > > > > metron-analytics/metron-profiler-client/src/main/java/ > org/apache/metron/profiler/client/window/generated/WindowLexer.java > > > > > > modified: > > > > > metron-analytics/metron-profiler-client/src/main/java/ > org/apache/metron/profiler/client/window/generated/WindowListener.java > > > > > > modified: > > > > > metron-analytics/metron-profiler-client/src/main/java/ > org/apache/metron/profiler/client/window/generated/WindowParser.java > > > > > > > > > > > > > > > Are these files changed by the build? > > > > > >
Re: Files modified after building
Well, the last three are in a path with “/generated/” in it. On 2/25/17, 7:39 PM, "Casey Stella"wrote: Crap, those are generated by the new profile selector dsl committed Friday. I must've missed them on a commit on the PR. They are generated by the build, so it was factored into the tests and such for the PR. Sorry for the inconvenience, I'll have to make another PR on Monday to get them in. On Sat, Feb 25, 2017 at 22:21 Kyle Richardson wrote: > That's my guess. I noticed the same thing. > > -Kyle > > > On Feb 25, 2017, at 8:31 PM, Otto Fowler > wrote: > > > > Changes not staged for commit: > > > > (use "git add ..." to update what will be committed) > > > > (use "git checkout -- ..." to discard changes in working > directory) > > > > > > modified: > > metron-analytics/metron-profiler-client/src/main/java/Window.tokens > > > > modified: > > metron-analytics/metron-profiler-client/src/main/java/WindowLexer.tokens > > > > modified: > > > metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/window/generated/WindowLexer.java > > > > modified: > > > metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/window/generated/WindowListener.java > > > > modified: > > > metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/window/generated/WindowParser.java > > > > > > > > > > Are these files changed by the build? >
Re: Files modified after building
Crap, those are generated by the new profile selector dsl committed Friday. I must've missed them on a commit on the PR. They are generated by the build, so it was factored into the tests and such for the PR. Sorry for the inconvenience, I'll have to make another PR on Monday to get them in. On Sat, Feb 25, 2017 at 22:21 Kyle Richardsonwrote: > That's my guess. I noticed the same thing. > > -Kyle > > > On Feb 25, 2017, at 8:31 PM, Otto Fowler > wrote: > > > > Changes not staged for commit: > > > > (use "git add ..." to update what will be committed) > > > > (use "git checkout -- ..." to discard changes in working > directory) > > > > > > modified: > > metron-analytics/metron-profiler-client/src/main/java/Window.tokens > > > > modified: > > metron-analytics/metron-profiler-client/src/main/java/WindowLexer.tokens > > > > modified: > > > metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/window/generated/WindowLexer.java > > > > modified: > > > metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/window/generated/WindowListener.java > > > > modified: > > > metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/window/generated/WindowParser.java > > > > > > > > > > Are these files changed by the build? >
Re: Files modified after building
That's my guess. I noticed the same thing. -Kyle > On Feb 25, 2017, at 8:31 PM, Otto Fowlerwrote: > > Changes not staged for commit: > > (use "git add ..." to update what will be committed) > > (use "git checkout -- ..." to discard changes in working directory) > > > modified: > metron-analytics/metron-profiler-client/src/main/java/Window.tokens > > modified: > metron-analytics/metron-profiler-client/src/main/java/WindowLexer.tokens > > modified: > metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/window/generated/WindowLexer.java > > modified: > metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/window/generated/WindowListener.java > > modified: > metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/window/generated/WindowParser.java > > > > > Are these files changed by the build?
Files modified after building
Changes not staged for commit: (use "git add ..." to update what will be committed) (use "git checkout -- ..." to discard changes in working directory) modified: metron-analytics/metron-profiler-client/src/main/java/Window.tokens modified: metron-analytics/metron-profiler-client/src/main/java/WindowLexer.tokens modified: metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/window/generated/WindowLexer.java modified: metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/window/generated/WindowListener.java modified: metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/window/generated/WindowParser.java Are these files changed by the build?