Re: MINA Wiki cleanup

2011-04-18 Thread Ashish
On Sat, Apr 16, 2011 at 1:47 PM, Emmanuel Lecharny elecha...@gmail.com wrote: Hi guys, I'm going to remove the MINA 2 wiki space,  it's totally useless now that we have moved back all the pages it contains to the main MINA space. +1, go for it :) I'm also updating the User guide, making it

Re: [MINA 3] Session write queue

2011-04-18 Thread Steve Ulrich
Hi! I'm sceptical about it. Maybe you could design it in a way, that the IoProcessor is replaceable, so one could test the behaviour. Cons: * Imagine a bunch of smaller write requests per session. Currently an IoProcessor at least have a chance to optimize the writes by flushing all data of

Re: [MINA 3] Session write queue

2011-04-18 Thread Emmanuel Lecharny
On 4/18/11 10:01 AM, Steve Ulrich wrote: Hi! I'm sceptical about it. Maybe you could design it in a way, that the IoProcessor is replaceable, so one could test the behaviour. And this is why I posted my suggestion on the mailing list :) My idea might well be totally off base. Cons: *

[jira] [Commented] (DIRMINA-653) IoSession.write not thread-safe? Loosing messages under heavy multi-threaded write on same session.

2011-04-18 Thread Christian Schwarz (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13020955#comment-13020955 ] Christian Schwarz commented on DIRMINA-653: --- Yes, the BufferDataException is

RE: [MINA 3] Session write queue

2011-04-18 Thread Steve Ulrich
D4n Outlook. This time with a better quotation... I hope Emmanuel Lecharny [mailto:elecha...@gmail.com] wrote Fair enough. But we can mitigate this risk on the IoProcessor too, by pulling out of the queue all the messages for a session, until the socket can't accept any more writing.

Re: [MINA 3] Session write queue

2011-04-18 Thread Julien Vermillard
Le Mon, 18 Apr 2011 10:26:42 +0200, Emmanuel Lecharny elecha...@gmail.com a écrit : On 4/18/11 10:01 AM, Steve Ulrich wrote: Hi! I'm sceptical about it. Maybe you could design it in a way, that the IoProcessor is replaceable, so one could test the behaviour. And this is why I posted my

Re: [MINA 3] Session write queue

2011-04-18 Thread Emmanuel Lécharny
On 4/18/11 12:13 PM, Steve Ulrich wrote: D4n Outlook. This time with a better quotation... I hope Emmanuel Lecharny [mailto:elecha...@gmail.com] wrote Fair enough. But we can mitigate this risk on the IoProcessor too, by pulling out of the queue all the messages for a session, until the

Re: [MINA 3] Session write queue

2011-04-18 Thread Emmanuel Lecharny
On 4/18/11 12:14 PM, Julien Vermillard wrote: Le Mon, 18 Apr 2011 10:26:42 +0200, Emmanuel Lecharnyelecha...@gmail.com a écrit : On 4/18/11 10:01 AM, Steve Ulrich wrote: Hi! I'm sceptical about it. Maybe you could design it in a way, that the IoProcessor is replaceable, so one could test

[jira] [Created] (DIRMINA-830) Unconditional wait() in Read- and WriteWorker of SerialSessionImpl

2011-04-18 Thread Christian Schwarz (JIRA)
Unconditional wait() in Read- and WriteWorker of SerialSessionImpl -- Key: DIRMINA-830 URL: https://issues.apache.org/jira/browse/DIRMINA-830 Project: MINA Issue Type: Bug

[jira] [Resolved] (FTPSERVER-405) Make Map field final (improve thread-safety)

2011-04-18 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/FTPSERVER-405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved FTPSERVER-405. Resolution: Fixed Make Map field final (improve thread-safety)

[jira] [Resolved] (FTPSERVER-406) StringBuffer = StringBuilder for internal use

2011-04-18 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/FTPSERVER-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved FTPSERVER-406. Resolution: Fixed StringBuffer = StringBuilder for internal use

[jira] [Resolved] (FTPSERVER-407) Wherever possible, immutable private fields should be marked final

2011-04-18 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/FTPSERVER-407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved FTPSERVER-407. Resolution: Fixed Wherever possible, immutable private fields should be marked final

[jira] [Updated] (DIRMINA-830) Unconditional wait() in Read- and WriteWorker of SerialSessionImpl

2011-04-18 Thread Julien Vermillard (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien Vermillard updated DIRMINA-830: -- Attachment: patch.diff Unconditional wait() in Read- and WriteWorker of

[jira] [Commented] (DIRMINA-830) Unconditional wait() in Read- and WriteWorker of SerialSessionImpl

2011-04-18 Thread Julien Vermillard (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13021067#comment-13021067 ] Julien Vermillard commented on DIRMINA-830: --- Since I can't reproduce the bug

[jira] [Updated] (SSHD-118) uploading and then renaming a file doesn't work (on windows)

2011-04-18 Thread Otto Frost (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Otto Frost updated SSHD-118: raf.close() should be changed to if (raf!=null) raf.close();

[jira] [Commented] (SSHD-118) uploading and then renaming a file doesn't work (on windows)

2011-04-18 Thread Bobby Powers (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13021105#comment-13021105 ] Bobby Powers commented on SSHD-118: --- This is interesting, I think I've seen the same thing

[jira] [Updated] (SSHD-118) uploading and then renaming a file doesn't work (on windows)

2011-04-18 Thread Otto Frost (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Otto Frost updated SSHD-118: Environment: windows xp professional sun jdk 1.5.0.22, jre 1.6 windows 2003 server SP2 sun jdk jre 1.5.0.22

[jira] [Commented] (SSHD-118) uploading and then renaming a file doesn't work (on windows)

2011-04-18 Thread Bobby Powers (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13021112#comment-13021112 ] Bobby Powers commented on SSHD-118: --- do you mean on line 383 of NativeSshFile? Under what

[jira] [Updated] (SSHD-118) uploading and then renaming a file doesn't work (on windows)

2011-04-18 Thread Otto Frost (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Otto Frost updated SSHD-118: Description: I logon, and then put xx xx rename xx yy O1706@WKE198515 ~ $ sftp -oport=

[jira] [Updated] (SSHD-118) uploading and then renaming a file doesn't work (on windows)

2011-04-18 Thread Otto Frost (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Otto Frost updated SSHD-118: Description: I logon, and then put xx xx rename xx yy O1706@WKE198515 ~ $ sftp -oport= a@localhost

[jira] [Commented] (SSHD-118) uploading and then renaming a file doesn't work (on windows)

2011-04-18 Thread Otto Frost (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13021155#comment-13021155 ] Otto Frost commented on SSHD-118: - if (raf!=null) raf.close();

[jira] [Updated] (SSHD-118) uploading and then renaming a file doesn't work (on windows)

2011-04-18 Thread Otto Frost (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Otto Frost updated SSHD-118: Description: I logon, and then put xx xx rename xx yy O1706@WKE198515 ~ $ sftp -oport= a@localhost

[jira] [Commented] (SSHD-118) uploading and then renaming a file doesn't work (on windows)

2011-04-18 Thread Otto Frost (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13021164#comment-13021164 ] Otto Frost commented on SSHD-118: - Added fix for the real problem in the description

Re: [MINA 3] Session write queue

2011-04-18 Thread Emmanuel Lécharny
After a second (third ?) thought, sounds like trying to have only one queue per IoProcessor is not really a good idea. It brings little, and cost a lot. Let's get back to one session/one writing queue. Thanks for the good feedback, Steve ! -- Regards, Cordialement, Emmanuel Lécharny

[jira] [Created] (SSHD-119) [PATCH] more specific docstring for Command interface

2011-04-18 Thread Bobby Powers (JIRA)
[PATCH] more specific docstring for Command interface - Key: SSHD-119 URL: https://issues.apache.org/jira/browse/SSHD-119 Project: MINA SSHD Issue Type: Improvement Reporter:

[jira] [Updated] (SSHD-119) [PATCH] more specific docstring for Command interface

2011-04-18 Thread Bobby Powers (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bobby Powers updated SSHD-119: -- Attachment: 0001-Command-update-javadoc-for-start-to-be-more-specific.patch [PATCH] more specific

[jira] [Updated] (SSHD-119) [PATCH] more specific docstring for Command interface

2011-04-18 Thread Bobby Powers (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bobby Powers updated SSHD-119: -- Attachment: (was: 0001-Command-update-javadoc-for-start-to-be-more-specific.patch) [PATCH] more

[jira] [Updated] (SSHD-119) [PATCH] more specific docstring for Command interface

2011-04-18 Thread Bobby Powers (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bobby Powers updated SSHD-119: -- Attachment: 0001-Command-update-javadoc-for-start-to-be-more-specific.patch [PATCH] more specific