Re: Q: SSHD - Should we add dependencies to Apache Commons or not ?

2018-08-17 Thread Lyor Goldstein
>>> We should be careful when trying to replace existing code with external libraries because there is rarely a guarantee that it will work exactly as the old code does. I agree in principle, but am not sure about "rarely a guarantee" - especially in this case where the code is a 100% duplicate

Re: Q: SSHD - Should we add dependencies to Apache Commons or not ?

2018-08-17 Thread Jonathan Valliere
Code which was already made shouldn’t be an issue unless it is full of bugs. We should be careful when trying to replace existing code with external libraries because there is rarely a guarantee that it will work exactly as the old code does. Dependencies create problems when the dependent

Re: Q: SSHD - Should we add dependencies to Apache Commons or not ?

2018-08-17 Thread Lyor Goldstein
>>> Of course, it's all about the size of what is copied. At some point, it would be better to go witha third party dependency instead of copying its code. Valid observation - we will need to "weigh" the amount of copied code and see how "heavy" it is. >>> On important aspect of adding external